From: Petr Cvek <petr.cvek@tul.cz>
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v1, TRIVIAL] Fix pxafb nonstd field documentation and add errata info
Date: Sat, 08 Aug 2015 18:20:20 +0000 [thread overview]
Message-ID: <55C64864.6070405@tul.cz> (raw)
Fix pxafb nonstd field documentation and add warning comment to Kconfig
and pxafb.c (errata: YUV420 hangs LCD).
Signed-off-by: Petr Cvek <petr.cvek@tul.cz>
---
Documentation/fb/pxafb.txt | 8 ++++----
drivers/video/fbdev/Kconfig | 5 +++++
drivers/video/fbdev/pxafb.c | 4 ++++
3 files changed, 13 insertions(+), 4 deletions(-)
diff --git a/Documentation/fb/pxafb.txt b/Documentation/fb/pxafb.txt
index d143a0a..dbbf5eb 100644
--- a/Documentation/fb/pxafb.txt
+++ b/Documentation/fb/pxafb.txt
@@ -123,12 +123,12 @@ Overlay Support for PXA27x and later LCD controllers
framebuffer framework, application has to take care of the offsets
and lengths of each component within the framebuffer.
- 4. var->nonstd is used to pass starting (x, y) position and color format,
+ 4. var->nonstd is used to pass starting (y, x) position and color format,
the detailed bit fields are shown below:
31 23 20 10 0
+-----------------+---+----------+----------+
- | ... unused ... |FOR| XPOS | YPOS |
+ | ... unused ... |FOR| YPOS | XPOS | (as in OVLxC2 register)
+-----------------+---+----------+----------+
FOR - color format, as defined by OVERLAY_FORMAT_* in pxafb.h
@@ -136,7 +136,7 @@ Overlay Support for PXA27x and later LCD controllers
1 - YUV444 PACKED
2 - YUV444 PLANAR
3 - YUV422 PLANAR
- 4 - YUR420 PLANAR
+ 4 - YUV420 PLANAR
- XPOS - starting horizontal position
YPOS - starting vertical position
+ XPOS - starting horizontal position
diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
index 2d98de5..8f485ec 100644
--- a/drivers/video/fbdev/Kconfig
+++ b/drivers/video/fbdev/Kconfig
@@ -1893,6 +1893,11 @@ config FB_PXA_OVERLAY
bool "Support PXA27x/PXA3xx Overlay(s) as framebuffer"
default n
depends on FB_PXA && (PXA27x || PXA3xx)
+ ---help---
+ Using the overlay 2 and YUV420 mode on a PXA27x C0 chip revision will
+ hang the LCD until the next SoC restart (errata E24).
+
+ If unsure, say N or check /proc/cpuinfo for "CPU revision : 4".
config FB_PXA_SMARTPANEL
bool "PXA Smartpanel LCD support"
diff --git a/drivers/video/fbdev/pxafb.c b/drivers/video/fbdev/pxafb.c
index 7245611..e573699 100644
--- a/drivers/video/fbdev/pxafb.c
+++ b/drivers/video/fbdev/pxafb.c
@@ -30,6 +30,10 @@
*
* Copyright (C) 2006-2008 Marvell International Ltd.
* All Rights Reserved
+ *
+ * NOTICE
+ * According to PXA27x errata E24 an enable of the overlay 2 in YUV420 mode
+ * on C0 chip revision will hang the LCD until the next SoC reset.
*/
#include <linux/module.h>
--
1.7.12.1
WARNING: multiple messages have this Message-ID (diff)
From: petr.cvek@tul.cz (Petr Cvek)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v1, TRIVIAL] Fix pxafb nonstd field documentation and add errata info
Date: Sat, 08 Aug 2015 20:20:20 +0200 [thread overview]
Message-ID: <55C64864.6070405@tul.cz> (raw)
Fix pxafb nonstd field documentation and add warning comment to Kconfig
and pxafb.c (errata: YUV420 hangs LCD).
Signed-off-by: Petr Cvek <petr.cvek@tul.cz>
---
Documentation/fb/pxafb.txt | 8 ++++----
drivers/video/fbdev/Kconfig | 5 +++++
drivers/video/fbdev/pxafb.c | 4 ++++
3 files changed, 13 insertions(+), 4 deletions(-)
diff --git a/Documentation/fb/pxafb.txt b/Documentation/fb/pxafb.txt
index d143a0a..dbbf5eb 100644
--- a/Documentation/fb/pxafb.txt
+++ b/Documentation/fb/pxafb.txt
@@ -123,12 +123,12 @@ Overlay Support for PXA27x and later LCD controllers
framebuffer framework, application has to take care of the offsets
and lengths of each component within the framebuffer.
- 4. var->nonstd is used to pass starting (x, y) position and color format,
+ 4. var->nonstd is used to pass starting (y, x) position and color format,
the detailed bit fields are shown below:
31 23 20 10 0
+-----------------+---+----------+----------+
- | ... unused ... |FOR| XPOS | YPOS |
+ | ... unused ... |FOR| YPOS | XPOS | (as in OVLxC2 register)
+-----------------+---+----------+----------+
FOR - color format, as defined by OVERLAY_FORMAT_* in pxafb.h
@@ -136,7 +136,7 @@ Overlay Support for PXA27x and later LCD controllers
1 - YUV444 PACKED
2 - YUV444 PLANAR
3 - YUV422 PLANAR
- 4 - YUR420 PLANAR
+ 4 - YUV420 PLANAR
- XPOS - starting horizontal position
YPOS - starting vertical position
+ XPOS - starting horizontal position
diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
index 2d98de5..8f485ec 100644
--- a/drivers/video/fbdev/Kconfig
+++ b/drivers/video/fbdev/Kconfig
@@ -1893,6 +1893,11 @@ config FB_PXA_OVERLAY
bool "Support PXA27x/PXA3xx Overlay(s) as framebuffer"
default n
depends on FB_PXA && (PXA27x || PXA3xx)
+ ---help---
+ Using the overlay 2 and YUV420 mode on a PXA27x C0 chip revision will
+ hang the LCD until the next SoC restart (errata E24).
+
+ If unsure, say N or check /proc/cpuinfo for "CPU revision : 4".
config FB_PXA_SMARTPANEL
bool "PXA Smartpanel LCD support"
diff --git a/drivers/video/fbdev/pxafb.c b/drivers/video/fbdev/pxafb.c
index 7245611..e573699 100644
--- a/drivers/video/fbdev/pxafb.c
+++ b/drivers/video/fbdev/pxafb.c
@@ -30,6 +30,10 @@
*
* Copyright (C) 2006-2008 Marvell International Ltd.
* All Rights Reserved
+ *
+ * NOTICE
+ * According to PXA27x errata E24 an enable of the overlay 2 in YUV420 mode
+ * on C0 chip revision will hang the LCD until the next SoC reset.
*/
#include <linux/module.h>
--
1.7.12.1
next reply other threads:[~2015-08-08 18:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-08 18:20 Petr Cvek [this message]
2015-08-08 18:20 ` [PATCH v1, TRIVIAL] Fix pxafb nonstd field documentation and add errata info Petr Cvek
2015-08-08 19:15 ` Robert Jarzmik
2015-08-08 19:15 ` Robert Jarzmik
2015-08-20 10:55 ` Tomi Valkeinen
2015-08-20 10:55 ` Tomi Valkeinen
2015-08-20 20:07 ` Petr Cvek
2015-08-20 20:07 ` Petr Cvek
2015-08-21 6:53 ` Tomi Valkeinen
2015-08-21 6:53 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55C64864.6070405@tul.cz \
--to=petr.cvek@tul.cz \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.