linux-4.2-rc6/drivers/extcon/extcon.c: 3 * bad tests ?

linux-4.2-rc6/drivers/extcon/extcon.c: 3 * bad tests ?

[David Binderman]

Hello there,

1.

[linux-4.2-rc6/drivers/extcon/extcon.c:153]: (style) Checking if unsigned variable 'id' is less than zero.

Source code is

    id = find_cable_id_by_name(edev, name);
    if (id < 0)

but

   unsigned int id;

Suggest sanity check return value from find_cable_id_by_name
*before* assigning it into an unsigned variable.

2.

[linux-4.2-rc6/drivers/extcon/extcon.c:384]: (style) Checking if unsigned variable 'id' is less than zero.

Duplicate.

3.

[linux-4.2-rc6/drivers/extcon/extcon.c:432]: (style) Checking if unsigned variable 'id' is less than zero.

Another duplicate.


Regards

David Binderman
 		 	   		  

Re: linux-4.2-rc6/drivers/extcon/extcon.c: 3 * bad tests ?

[Chanwoo Choi]

Hi David,

I knew this issue. So, I'll send following patch[1] to solve it for Linux 4.3
[1] http://git.kernel.org/cgit/linux/kernel/git/chanwoo/extcon.git/commit/?h=extcon-next&id=4e491fe7920cb84dd0a2ea79800173ab1802fa22

Thanks,
Chanwoo Choi

On 08/10/2015 06:30 AM, David Binderman wrote:
> Hello there,
> 
> 1.
> 
> [linux-4.2-rc6/drivers/extcon/extcon.c:153]: (style) Checking if unsigned variable 'id' is less than zero.
> 
> Source code is
> 
>     id = find_cable_id_by_name(edev, name);
>     if (id < 0)
> 
> but
> 
>    unsigned int id;
> 
> Suggest sanity check return value from find_cable_id_by_name
> *before* assigning it into an unsigned variable.
> 
> 2.
> 
> [linux-4.2-rc6/drivers/extcon/extcon.c:384]: (style) Checking if unsigned variable 'id' is less than zero.
> 
> Duplicate.
> 
> 3.
> 
> [linux-4.2-rc6/drivers/extcon/extcon.c:432]: (style) Checking if unsigned variable 'id' is less than zero.
> 
> Another duplicate.
> 
> 
> Regards
> 
> David Binderman
>  		 	   		  
>