From: Vlastimil Babka <vbabka@suse.cz>
To: PINTU KUMAR <pintu_agarwal@yahoo.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Hugh Dickins <hughd@google.com>,
Andrea Arcangeli <aarcange@redhat.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Rik van Riel <riel@redhat.com>, Mel Gorman <mgorman@suse.de>,
David Rientjes <rientjes@google.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Pintu Kumar <pintu.k@samsung.com>
Subject: Re: [RFC v3 2/2] mm, compaction: make kcompactd rely on sysctl_extfrag_threshold
Date: Mon, 10 Aug 2015 11:54:17 +0200 [thread overview]
Message-ID: <55C874C9.4050803@suse.cz> (raw)
In-Reply-To: <166622926.1247366.1439140873216.JavaMail.yahoo@mail.yahoo.com>
On 08/09/2015 07:21 PM, PINTU KUMAR wrote:
>>
>> -extern int fragmentation_index(struct zone *zone, unsigned int order);
>> +extern int fragmentation_index(struct zone *zone, unsigned int order,
>
>> + bool ignore_suitable);
>
> We would like to retain the original fragmentation_index as it is.
> Because in some cases people may be using it without kcompactd.
> In such cases, future kernel upgrades will suffer.
> In my opinion fragmentation_index should work just based on zones and order.
I don't understand the concern. If you pass 'false' to ignore_suitable,
you get the standard behavior. Only kcompactd uses the altered behavior.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Vlastimil Babka <vbabka@suse.cz>
To: PINTU KUMAR <pintu_agarwal@yahoo.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Hugh Dickins <hughd@google.com>,
Andrea Arcangeli <aarcange@redhat.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Rik van Riel <riel@redhat.com>, Mel Gorman <mgorman@suse.de>,
David Rientjes <rientjes@google.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Pintu Kumar <pintu.k@samsung.com>
Subject: Re: [RFC v3 2/2] mm, compaction: make kcompactd rely on sysctl_extfrag_threshold
Date: Mon, 10 Aug 2015 11:54:17 +0200 [thread overview]
Message-ID: <55C874C9.4050803@suse.cz> (raw)
In-Reply-To: <166622926.1247366.1439140873216.JavaMail.yahoo@mail.yahoo.com>
On 08/09/2015 07:21 PM, PINTU KUMAR wrote:
>>
>> -extern int fragmentation_index(struct zone *zone, unsigned int order);
>> +extern int fragmentation_index(struct zone *zone, unsigned int order,
>
>> + bool ignore_suitable);
>
> We would like to retain the original fragmentation_index as it is.
> Because in some cases people may be using it without kcompactd.
> In such cases, future kernel upgrades will suffer.
> In my opinion fragmentation_index should work just based on zones and order.
I don't understand the concern. If you pass 'false' to ignore_suitable,
you get the standard behavior. Only kcompactd uses the altered behavior.
next prev parent reply other threads:[~2015-08-10 9:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-03 16:25 [RFC v3 1/2] mm, compaction: introduce kcompactd Vlastimil Babka
2015-08-03 16:25 ` Vlastimil Babka
2015-08-03 16:25 ` [RFC v3 2/2] mm, compaction: make kcompactd rely on sysctl_extfrag_threshold Vlastimil Babka
2015-08-03 16:25 ` Vlastimil Babka
2015-08-09 17:21 ` PINTU KUMAR
2015-08-10 9:54 ` Vlastimil Babka [this message]
2015-08-10 9:54 ` Vlastimil Babka
2015-08-09 15:37 ` [RFC v3 1/2] mm, compaction: introduce kcompactd PINTU KUMAR
2015-08-10 9:44 ` Vlastimil Babka
2015-08-10 9:44 ` Vlastimil Babka
2015-08-11 8:50 ` PINTU KUMAR
2015-08-11 8:50 ` PINTU KUMAR
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55C874C9.4050803@suse.cz \
--to=vbabka@suse.cz \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=pintu.k@samsung.com \
--cc=pintu_agarwal@yahoo.com \
--cc=riel@redhat.com \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.