From: Zefan Li <lizefan@huawei.com>
To: Tejun Heo <tj@kernel.org>, Johannes Weiner <hannes@cmpxchg.org>
Cc: cgroups@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-team@fb.com
Subject: Re: [PATCH cgroup/for-4.3 1/3] cgroup: replace error handling in cgroup_init() with WARN_ON()s
Date: Mon, 10 Aug 2015 18:19:31 +0800 [thread overview]
Message-ID: <55C87AB3.1040105@huawei.com> (raw)
In-Reply-To: <20150805172012.GO17598@mtj.duckdns.org>
On 2015/8/6 1:20, Tejun Heo wrote:
> The init sequence shouldn't fail short of bugs and even when it does
> it's better to continue with the rest of initialization and we were
> silently ignoring /proc/cgroups creation failure.
>
> Drop the explicit error handling and wrap sysfs_create_mount_point(),
> register_filesystem() and proc_create() with WARN_ON()s.
>
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Cc: Li Zefan <lizefan@huawei.com>
> Cc: Johannes Weiner <hannes@cmpxchg.org>
acked
WARNING: multiple messages have this Message-ID (diff)
From: Zefan Li <lizefan@huawei.com>
To: Tejun Heo <tj@kernel.org>, Johannes Weiner <hannes@cmpxchg.org>
Cc: <cgroups@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<kernel-team@fb.com>
Subject: Re: [PATCH cgroup/for-4.3 1/3] cgroup: replace error handling in cgroup_init() with WARN_ON()s
Date: Mon, 10 Aug 2015 18:19:31 +0800 [thread overview]
Message-ID: <55C87AB3.1040105@huawei.com> (raw)
In-Reply-To: <20150805172012.GO17598@mtj.duckdns.org>
On 2015/8/6 1:20, Tejun Heo wrote:
> The init sequence shouldn't fail short of bugs and even when it does
> it's better to continue with the rest of initialization and we were
> silently ignoring /proc/cgroups creation failure.
>
> Drop the explicit error handling and wrap sysfs_create_mount_point(),
> register_filesystem() and proc_create() with WARN_ON()s.
>
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Cc: Li Zefan <lizefan@huawei.com>
> Cc: Johannes Weiner <hannes@cmpxchg.org>
acked
next prev parent reply other threads:[~2015-08-10 10:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-05 17:20 [PATCH cgroup/for-4.3 1/3] cgroup: replace error handling in cgroup_init() with WARN_ON()s Tejun Heo
2015-08-05 17:20 ` Tejun Heo
[not found] ` <20150805172012.GO17598-qYNAdHglDFBN0TnZuCh8vA@public.gmane.org>
2015-08-05 17:20 ` [PATCH cgroup/for-4.3 2/3] cgroup: drop cgroup__DEVEL__legacy_files_on_dfl Tejun Heo
2015-08-05 17:20 ` Tejun Heo
[not found] ` <20150805172043.GP17598-qYNAdHglDFBN0TnZuCh8vA@public.gmane.org>
2015-08-05 17:21 ` [PATCH cgroup/for-4.3 3/3] cgroup: replace __DEVEL__sane_behavior with cgroup2 fs type Tejun Heo
2015-08-05 17:21 ` Tejun Heo
2015-08-10 10:19 ` Zefan Li
2015-08-10 10:19 ` Zefan Li
2015-10-15 20:59 ` [PATCH cgroup/for-4.3 2/3] cgroup: drop cgroup__DEVEL__legacy_files_on_dfl Tejun Heo
2015-10-15 20:59 ` Tejun Heo
2015-08-10 10:19 ` Zefan Li [this message]
2015-08-10 10:19 ` [PATCH cgroup/for-4.3 1/3] cgroup: replace error handling in cgroup_init() with WARN_ON()s Zefan Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55C87AB3.1040105@huawei.com \
--to=lizefan@huawei.com \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.