From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] ARM: shmobile: silk: add QSPI DT support
Date: Mon, 10 Aug 2015 18:18:24 +0000 [thread overview]
Message-ID: <55C8EAF0.7060600@cogentembedded.com> (raw)
In-Reply-To: <CAMuHMdXQJ4Hju477Ys0ujXCNdUjWOa6AuKGzLPc3YFJc_eLz+g@mail.gmail.com>
Hello.
On 08/10/2015 05:38 PM, Geert Uytterhoeven wrote:
>> Define the SILK board dependent part of the QSPI device node.
>> Add device nodes for Spansion S25FL512S SPI flash and MTD partitions on it.
>> Based on the original patch by Vladimir Barinov
>> <vladimir.barinov@cogentembedded.com>.
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>> --- renesas.orig/arch/arm/boot/dts/r8a7794-silk.dts
>> +++ renesas/arch/arm/boot/dts/r8a7794-silk.dts
>
>> +&qspi {
>> + pinctrl-0 = <&qspi_pins>;
>> + pinctrl-names = "default";
>> +
>> + status = "okay";
>> +
>> + flash@0 {
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> + compatible = "spansion,s25fl512s";
> Please add the "jedec,spi-nor" fallback.
Hm, spi-nor.c alone can't control this device, it's rather m25p80.c that's
the real driver. So if a fallback needs to be added indeed it should be
"st,m25p80" I think...
[...]
> Gr{oetje,eeting}s,
MBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ARM: shmobile: silk: add QSPI DT support
Date: Mon, 10 Aug 2015 21:18:24 +0300 [thread overview]
Message-ID: <55C8EAF0.7060600@cogentembedded.com> (raw)
In-Reply-To: <CAMuHMdXQJ4Hju477Ys0ujXCNdUjWOa6AuKGzLPc3YFJc_eLz+g@mail.gmail.com>
Hello.
On 08/10/2015 05:38 PM, Geert Uytterhoeven wrote:
>> Define the SILK board dependent part of the QSPI device node.
>> Add device nodes for Spansion S25FL512S SPI flash and MTD partitions on it.
>> Based on the original patch by Vladimir Barinov
>> <vladimir.barinov@cogentembedded.com>.
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>> --- renesas.orig/arch/arm/boot/dts/r8a7794-silk.dts
>> +++ renesas/arch/arm/boot/dts/r8a7794-silk.dts
>
>> +&qspi {
>> + pinctrl-0 = <&qspi_pins>;
>> + pinctrl-names = "default";
>> +
>> + status = "okay";
>> +
>> + flash at 0 {
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> + compatible = "spansion,s25fl512s";
> Please add the "jedec,spi-nor" fallback.
Hm, spi-nor.c alone can't control this device, it's rather m25p80.c that's
the real driver. So if a fallback needs to be added indeed it should be
"st,m25p80" I think...
[...]
> Gr{oetje,eeting}s,
MBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Simon Horman <horms@verge.net.au>,
Linux-sh list <linux-sh@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Magnus Damm <magnus.damm@gmail.com>,
Russell King <linux@arm.linux.org.uk>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 2/2] ARM: shmobile: silk: add QSPI DT support
Date: Mon, 10 Aug 2015 21:18:24 +0300 [thread overview]
Message-ID: <55C8EAF0.7060600@cogentembedded.com> (raw)
In-Reply-To: <CAMuHMdXQJ4Hju477Ys0ujXCNdUjWOa6AuKGzLPc3YFJc_eLz+g@mail.gmail.com>
Hello.
On 08/10/2015 05:38 PM, Geert Uytterhoeven wrote:
>> Define the SILK board dependent part of the QSPI device node.
>> Add device nodes for Spansion S25FL512S SPI flash and MTD partitions on it.
>> Based on the original patch by Vladimir Barinov
>> <vladimir.barinov@cogentembedded.com>.
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>> --- renesas.orig/arch/arm/boot/dts/r8a7794-silk.dts
>> +++ renesas/arch/arm/boot/dts/r8a7794-silk.dts
>
>> +&qspi {
>> + pinctrl-0 = <&qspi_pins>;
>> + pinctrl-names = "default";
>> +
>> + status = "okay";
>> +
>> + flash@0 {
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> + compatible = "spansion,s25fl512s";
> Please add the "jedec,spi-nor" fallback.
Hm, spi-nor.c alone can't control this device, it's rather m25p80.c that's
the real driver. So if a fallback needs to be added indeed it should be
"st,m25p80" I think...
[...]
> Gr{oetje,eeting}s,
MBR, Sergei
next prev parent reply other threads:[~2015-08-10 18:18 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-08 22:24 [PATCH 0/2] Add R8A7794/SILK QSPI DT support Sergei Shtylyov
2015-08-08 22:24 ` Sergei Shtylyov
2015-08-08 22:24 ` Sergei Shtylyov
2015-08-08 22:26 ` [PATCH 1/2] ARM: shmobile: r8a7794: add " Sergei Shtylyov
2015-08-08 22:26 ` Sergei Shtylyov
2015-08-08 22:26 ` Sergei Shtylyov
2015-08-10 14:35 ` Geert Uytterhoeven
2015-08-10 14:35 ` Geert Uytterhoeven
2015-08-10 14:35 ` Geert Uytterhoeven
2015-08-08 22:27 ` [PATCH 2/2] ARM: shmobile: silk: " Sergei Shtylyov
2015-08-08 22:27 ` Sergei Shtylyov
2015-08-08 22:27 ` Sergei Shtylyov
2015-08-10 14:38 ` Geert Uytterhoeven
2015-08-10 14:38 ` Geert Uytterhoeven
2015-08-10 14:38 ` Geert Uytterhoeven
2015-08-10 18:18 ` Sergei Shtylyov [this message]
2015-08-10 18:18 ` Sergei Shtylyov
2015-08-10 18:18 ` Sergei Shtylyov
2015-08-10 18:52 ` Geert Uytterhoeven
2015-08-10 18:52 ` Geert Uytterhoeven
2015-08-10 18:52 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55C8EAF0.7060600@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.