All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christopher Covington <cov@codeaurora.org>
To: "Alex Bennée" <alex.bennee@linaro.org>,
	qemu-devel@nongnu.org, "Peter Maydell" <peter.maydell@linaro.org>
Cc: qemu-trivial@nongnu.org, pbonzini@redhat.com,
	crosthwaitepeter@gmail.com, rth@twiddle.net
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH v4 05/11] qemu-log: Improve the "exec" TB execution logging
Date: Mon, 10 Aug 2015 15:40:56 -0400	[thread overview]
Message-ID: <55C8FE48.6010900@codeaurora.org> (raw)
In-Reply-To: <1438593291-27109-6-git-send-email-alex.bennee@linaro.org>

Hi Peter, Alex,

On 08/03/2015 05:14 AM, Alex Bennée wrote:
> From: Peter Maydell <peter.maydell@linaro.org>
> 
> Improve the TB execution logging so that it is easier to identify
> what is happening from trace logs:
>  * move the "Trace" logging of executed TBs into cpu_tb_exec()
>    so that it is emitted if and only if we actually execute a TB,
>    and for consistency for the CPU state logging
>  * log when we link two TBs together via tb_add_jump()
>  * log when cpu_tb_exec() returns early from a chain of TBs
> 
> The new style logging looks like this:
> 
> Trace 0x7fb7cc822ca0 [ffffffc0000dce00]
> Linking TBs 0x7fb7cc822ca0 [ffffffc0000dce00] index 0 -> 0x7fb7cc823110 [ffffffc0000dce10]
> Trace 0x7fb7cc823110 [ffffffc0000dce10]
> Trace 0x7fb7cc823420 [ffffffc000302688]
> Trace 0x7fb7cc8234a0 [ffffffc000302698]
> Trace 0x7fb7cc823520 [ffffffc0003026a4]
> Trace 0x7fb7cc823560 [ffffffc0000dce44]
> Linking TBs 0x7fb7cc823560 [ffffffc0000dce44] index 1 -> 0x7fb7cc8235d0 [ffffffc0000dce70]
> Trace 0x7fb7cc8235d0 [ffffffc0000dce70]
> Abandoned execution of TB chain before 0x7fb7cc8235d0 [ffffffc0000dce70]
> Trace 0x7fb7cc8235d0 [ffffffc0000dce70]
> Trace 0x7fb7cc822fd0 [ffffffc0000dd52c]

Do you think there's some way to log the loop count when a circular chain is
executed?

System Emulation started at Mon Aug 10 15:30:49 2015
Invocation:aarch64-softmmu/qemu-system-aarch64 -M virt -cpu cortex-a57 -m 2G
-kernel psci-exit -d exec,int,in_asm -nodefaults -nographic -monitor none
-icount shift=0
----------------
IN:
0x0000000080000000:  d2800140      mov x0, #0xa
0x0000000080000004:  f1000400      subs x0, x0, #0x1 (1)
0x0000000080000008:  54ffffe1      b.ne #-0x4 (addr 0x80000004)

Trace 0x7f38787cb000 [0000000080000000]
----------------
IN:
0x0000000080000004:  f1000400      subs x0, x0, #0x1 (1)
0x0000000080000008:  54ffffe1      b.ne #-0x4 (addr 0x80000004)

Linking TBs 0x7f38787cb000 [0000000080000000] index 1 -> 0x7f38787cb0d0
[0000000080000004]
Trace 0x7f38787cb0d0 [0000000080000004]
Linking TBs 0x7f38787cb0d0 [0000000080000004] index 1 -> 0x7f38787cb0d0
[0000000080000004]
Trace 0x7f38787cb0d0 [0000000080000004]
----------------
IN:
0x000000008000000c:  d2800100      mov x0, #0x8
0x0000000080000010:  f2b08000      movk x0, #0x8400, lsl #16
0x0000000080000014:  d4000002      hvc #0x0

Linking TBs 0x7f38787cb0d0 [0000000080000004] index 0 -> 0x7f38787cb1c0
[000000008000000c]
Trace 0x7f38787cb1c0 [000000008000000c]
Taking exception 11 [Hypervisor Call]
...from EL1
...with ESR 0x5a000000

Thanks,
Christopher Covington

-- 
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project


WARNING: multiple messages have this Message-ID (diff)
From: Christopher Covington <cov@codeaurora.org>
To: "Alex Bennée" <alex.bennee@linaro.org>,
	qemu-devel@nongnu.org, "Peter Maydell" <peter.maydell@linaro.org>
Cc: qemu-trivial@nongnu.org, pbonzini@redhat.com,
	crosthwaitepeter@gmail.com, aurelien@aurel32.net,
	rth@twiddle.net
Subject: Re: [Qemu-devel] [PATCH v4 05/11] qemu-log: Improve the "exec" TB execution logging
Date: Mon, 10 Aug 2015 15:40:56 -0400	[thread overview]
Message-ID: <55C8FE48.6010900@codeaurora.org> (raw)
In-Reply-To: <1438593291-27109-6-git-send-email-alex.bennee@linaro.org>

Hi Peter, Alex,

On 08/03/2015 05:14 AM, Alex Bennée wrote:
> From: Peter Maydell <peter.maydell@linaro.org>
> 
> Improve the TB execution logging so that it is easier to identify
> what is happening from trace logs:
>  * move the "Trace" logging of executed TBs into cpu_tb_exec()
>    so that it is emitted if and only if we actually execute a TB,
>    and for consistency for the CPU state logging
>  * log when we link two TBs together via tb_add_jump()
>  * log when cpu_tb_exec() returns early from a chain of TBs
> 
> The new style logging looks like this:
> 
> Trace 0x7fb7cc822ca0 [ffffffc0000dce00]
> Linking TBs 0x7fb7cc822ca0 [ffffffc0000dce00] index 0 -> 0x7fb7cc823110 [ffffffc0000dce10]
> Trace 0x7fb7cc823110 [ffffffc0000dce10]
> Trace 0x7fb7cc823420 [ffffffc000302688]
> Trace 0x7fb7cc8234a0 [ffffffc000302698]
> Trace 0x7fb7cc823520 [ffffffc0003026a4]
> Trace 0x7fb7cc823560 [ffffffc0000dce44]
> Linking TBs 0x7fb7cc823560 [ffffffc0000dce44] index 1 -> 0x7fb7cc8235d0 [ffffffc0000dce70]
> Trace 0x7fb7cc8235d0 [ffffffc0000dce70]
> Abandoned execution of TB chain before 0x7fb7cc8235d0 [ffffffc0000dce70]
> Trace 0x7fb7cc8235d0 [ffffffc0000dce70]
> Trace 0x7fb7cc822fd0 [ffffffc0000dd52c]

Do you think there's some way to log the loop count when a circular chain is
executed?

System Emulation started at Mon Aug 10 15:30:49 2015
Invocation:aarch64-softmmu/qemu-system-aarch64 -M virt -cpu cortex-a57 -m 2G
-kernel psci-exit -d exec,int,in_asm -nodefaults -nographic -monitor none
-icount shift=0
----------------
IN:
0x0000000080000000:  d2800140      mov x0, #0xa
0x0000000080000004:  f1000400      subs x0, x0, #0x1 (1)
0x0000000080000008:  54ffffe1      b.ne #-0x4 (addr 0x80000004)

Trace 0x7f38787cb000 [0000000080000000]
----------------
IN:
0x0000000080000004:  f1000400      subs x0, x0, #0x1 (1)
0x0000000080000008:  54ffffe1      b.ne #-0x4 (addr 0x80000004)

Linking TBs 0x7f38787cb000 [0000000080000000] index 1 -> 0x7f38787cb0d0
[0000000080000004]
Trace 0x7f38787cb0d0 [0000000080000004]
Linking TBs 0x7f38787cb0d0 [0000000080000004] index 1 -> 0x7f38787cb0d0
[0000000080000004]
Trace 0x7f38787cb0d0 [0000000080000004]
----------------
IN:
0x000000008000000c:  d2800100      mov x0, #0x8
0x0000000080000010:  f2b08000      movk x0, #0x8400, lsl #16
0x0000000080000014:  d4000002      hvc #0x0

Linking TBs 0x7f38787cb0d0 [0000000080000004] index 0 -> 0x7f38787cb1c0
[000000008000000c]
Trace 0x7f38787cb1c0 [000000008000000c]
Taking exception 11 [Hypervisor Call]
...from EL1
...with ESR 0x5a000000

Thanks,
Christopher Covington

-- 
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

  parent reply	other threads:[~2015-08-10 19:41 UTC|newest]

Thread overview: 110+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-03  9:14 [Qemu-trivial] [PATCH v4 00/11] qemu-log, perfmap and other logging tweaks Alex Bennée
2015-08-03  9:14 ` [Qemu-devel] " Alex Bennée
2015-08-03  9:14 ` [Qemu-trivial] [PATCH v4 01/11] tcg: add ability to dump /tmp/perf-<pid>.map files Alex Bennée
2015-08-03  9:14   ` [Qemu-devel] " Alex Bennée
2015-08-03 13:40   ` [Qemu-trivial] " Paolo Bonzini
2015-08-03 13:40     ` [Qemu-devel] " Paolo Bonzini
2015-08-04  7:39     ` [Qemu-trivial] " Alex Bennée
2015-08-04  7:39       ` [Qemu-devel] " Alex Bennée
2015-08-04 10:02       ` [Qemu-trivial] " Paolo Bonzini
2015-08-04 10:02         ` [Qemu-devel] " Paolo Bonzini
2015-08-04 11:59       ` [Qemu-trivial] " Aurelien Jarno
2015-08-04 11:59         ` [Qemu-devel] " Aurelien Jarno
2015-08-04 12:55         ` [Qemu-trivial] " Alex Bennée
2015-08-04 12:55           ` [Qemu-devel] " Alex Bennée
2015-08-04 19:01           ` [Qemu-trivial] " Aurelien Jarno
2015-08-04 19:01             ` Aurelien Jarno
2015-08-04 12:15   ` [Qemu-trivial] " Aurelien Jarno
2015-08-04 12:15     ` [Qemu-devel] " Aurelien Jarno
2015-08-03  9:14 ` [Qemu-trivial] [PATCH v4 02/11] tcg: light re-factor and pass down TranslationBlock Alex Bennée
2015-08-03  9:14   ` [Qemu-devel] " Alex Bennée
2015-08-04 12:36   ` [Qemu-trivial] " Aurelien Jarno
2015-08-04 12:36     ` [Qemu-devel] " Aurelien Jarno
2016-02-03 18:38     ` [Qemu-trivial] " Alex Bennée
2016-02-03 18:38       ` [Qemu-devel] " Alex Bennée
2015-08-03  9:14 ` [Qemu-trivial] [PATCH v4 03/11] qemu-log: correct help text for -d cpu Alex Bennée
2015-08-03  9:14   ` [Qemu-devel] " Alex Bennée
2015-08-04 12:16   ` [Qemu-trivial] " Aurelien Jarno
2015-08-04 12:16     ` [Qemu-devel] " Aurelien Jarno
2015-08-04 15:11     ` [Qemu-trivial] " Alex Bennée
2015-08-04 15:11       ` [Qemu-devel] " Alex Bennée
2015-08-04 15:15       ` [Qemu-trivial] " Peter Maydell
2015-08-04 15:15         ` Peter Maydell
2015-08-04 15:21         ` [Qemu-trivial] " Richard Henderson
2015-08-04 15:21           ` Richard Henderson
2015-08-04 17:22           ` [Qemu-trivial] " Alex Bennée
2015-08-04 17:22             ` Alex Bennée
2015-08-04 18:09             ` [Qemu-trivial] " Richard Henderson
2015-08-04 18:09               ` Richard Henderson
2015-08-04 19:08               ` [Qemu-trivial] " Alex Bennée
2015-08-04 19:08                 ` Alex Bennée
2015-08-04 19:16                 ` [Qemu-trivial] " Richard Henderson
2015-08-04 19:16                   ` Richard Henderson
2015-09-15 19:28                   ` [Qemu-trivial] " Peter Maydell
2015-09-15 19:28                     ` Peter Maydell
2015-09-15 19:41                     ` [Qemu-trivial] " Richard Henderson
2015-09-15 19:41                       ` Richard Henderson
2015-08-03  9:14 ` [Qemu-trivial] [PATCH v4 04/11] qemu-log: Avoid function call for disabled qemu_log_mask logging Alex Bennée
2015-08-03  9:14   ` [Qemu-devel] " Alex Bennée
2015-08-04 12:17   ` [Qemu-trivial] " Aurelien Jarno
2015-08-04 12:17     ` [Qemu-devel] " Aurelien Jarno
2015-08-03  9:14 ` [Qemu-trivial] [PATCH v4 05/11] qemu-log: Improve the "exec" TB execution logging Alex Bennée
2015-08-03  9:14   ` [Qemu-devel] " Alex Bennée
2015-08-04 12:17   ` [Qemu-trivial] " Aurelien Jarno
2015-08-04 12:17     ` [Qemu-devel] " Aurelien Jarno
2015-08-10 19:40   ` Christopher Covington [this message]
2015-08-10 19:40     ` Christopher Covington
2016-02-03 18:45     ` [Qemu-trivial] " Alex Bennée
2016-02-03 18:45       ` Alex Bennée
2015-08-03  9:14 ` [Qemu-trivial] [PATCH v4 06/11] qemu-log: support simple pid substitution in logfile Alex Bennée
2015-08-03  9:14   ` [Qemu-devel] " Alex Bennée
2015-08-04 12:17   ` [Qemu-trivial] " Aurelien Jarno
2015-08-04 12:17     ` [Qemu-devel] " Aurelien Jarno
2015-08-03  9:14 ` [Qemu-trivial] [PATCH v4 07/11] qemu-log: new option -dfilter to limit output Alex Bennée
2015-08-03  9:14   ` [Qemu-devel] " Alex Bennée
2015-08-04 12:21   ` [Qemu-trivial] " Aurelien Jarno
2015-08-04 12:21     ` [Qemu-devel] " Aurelien Jarno
2015-08-10 16:59   ` [Qemu-trivial] " Christopher Covington
2015-08-10 16:59     ` Christopher Covington
2015-08-10 18:30     ` [Qemu-trivial] " Alex Bennée
2015-08-10 18:30       ` Alex Bennée
2015-08-03  9:14 ` [Qemu-trivial] [PATCH v4 08/11] qemu-log: dfilter-ise exec, out_asm, and op_opt Alex Bennée
2015-08-03  9:14   ` [Qemu-devel] " Alex Bennée
2015-08-04 12:22   ` [Qemu-trivial] " Aurelien Jarno
2015-08-04 12:22     ` [Qemu-devel] " Aurelien Jarno
2015-08-03  9:14 ` [Qemu-trivial] [PATCH v4 09/11] target-arm: dfilter support for in_asm, op, opt_op Alex Bennée
2015-08-03  9:14   ` [Qemu-devel] " Alex Bennée
2015-08-04 12:23   ` [Qemu-trivial] " Aurelien Jarno
2015-08-04 12:23     ` [Qemu-devel] " Aurelien Jarno
2015-08-04 14:44   ` [Qemu-trivial] " Richard Henderson
2015-08-04 14:44     ` [Qemu-devel] " Richard Henderson
2015-08-04 17:26     ` [Qemu-trivial] " Alex Bennée
2015-08-04 17:26       ` [Qemu-devel] " Alex Bennée
2015-08-04 18:11       ` [Qemu-trivial] " Richard Henderson
2015-08-04 18:11         ` [Qemu-devel] " Richard Henderson
2015-08-03  9:14 ` [Qemu-trivial] [PATCH v4 10/11] vl.c: log system invocation when enabled Alex Bennée
2015-08-03  9:14   ` [Qemu-devel] " Alex Bennée
2015-08-04 12:30   ` [Qemu-trivial] " Aurelien Jarno
2015-08-04 12:30     ` [Qemu-devel] " Aurelien Jarno
2015-08-04 12:40   ` [Qemu-trivial] " Peter Maydell
2015-08-04 12:40     ` Peter Maydell
2015-08-04 12:46     ` [Qemu-trivial] " Aurelien Jarno
2015-08-04 12:46       ` Aurelien Jarno
2015-08-04 13:14       ` [Qemu-trivial] " Peter Maydell
2015-08-04 13:14         ` Peter Maydell
2015-08-04 15:12         ` [Qemu-trivial] " Alex Bennée
2015-08-04 15:12           ` Alex Bennée
2015-08-03  9:14 ` [Qemu-trivial] [PATCH v4 11/11] cputlb: modernise the debug support Alex Bennée
2015-08-03  9:14   ` [Qemu-devel] " Alex Bennée
2015-08-04 12:33   ` [Qemu-trivial] " Aurelien Jarno
2015-08-04 12:33     ` [Qemu-devel] " Aurelien Jarno
2016-02-03 18:54     ` [Qemu-trivial] " Alex Bennée
2016-02-03 18:54       ` [Qemu-devel] " Alex Bennée
2016-02-03 19:05       ` [Qemu-trivial] " Peter Maydell
2016-02-03 19:05         ` Peter Maydell
2016-02-04  7:03         ` [Qemu-trivial] " Alex Bennée
2016-02-04  7:03           ` Alex Bennée
2015-09-11  7:54 ` [Qemu-trivial] [PATCH v4 00/11] qemu-log, perfmap and other logging tweaks Michael Tokarev
2015-09-11  7:54   ` [Qemu-devel] " Michael Tokarev
2015-09-11 14:07   ` [Qemu-trivial] " Alex Bennée
2015-09-11 14:07     ` [Qemu-devel] " Alex Bennée

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55C8FE48.6010900@codeaurora.org \
    --to=cov@codeaurora.org \
    --cc=alex.bennee@linaro.org \
    --cc=crosthwaitepeter@gmail.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.