From: Jiri Slaby <jslaby@suse.cz>
To: Joakim Tjernlund <joakim.tjernlund@transmode.se>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Cc: "ulf.hansson@linaro.org" <ulf.hansson@linaro.org>,
Greg KH <gregkh@linuxfoundation.org>
Subject: Re: [patch added to the 3.12 stable tree] mmc: sdhci-esdhc: Make 8BIT bus work
Date: Tue, 11 Aug 2015 09:16:31 +0200 [thread overview]
Message-ID: <55C9A14F.8060609@suse.cz> (raw)
In-Reply-To: <1439220420.3120.83.camel@transmode.se>
On 08/10/2015, 05:27 PM, Joakim Tjernlund wrote:
> On Mon, 2015-08-10 at 16:17 +0200, Jiri Slaby wrote:
>> From: Joakim Tjernlund <Joakim.Tjernlund@transmode.se>
>>
>> This patch has been added to the 3.12 stable tree. If you have any
>> objections, please let us know.
>
> I think 8BIT support was added after 3.12 and if so I do not think this
> is appropriate for 3.12
It's in 3.12 already:
$ git describe --exact-match --contains 66b50a00992d
v3.11-rc1~50^2~5
But 3.10 does not need the patch. 3.10.86 was released with that though.
Is it worth reverting or can it cause any havoc to the system?
>> ===============
>>
>> commit 8e91125ff3f57f15c6568e2a6d32743b3f7815e4 upstream.
>>
>> Support for 8BIT bus with was added some time ago to sdhci-esdhc but
>> then missed to remove the 8BIT from the reserved bit mask which made
>> 8BIT non functional.
>>
>> Fixes: 66b50a00992d ("mmc: esdhc: Add support for 8-bit bus width and..")
>> Signed-off-by: Joakim Tjernlund <joakim.tjernlund@transmode.se>
>> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
>> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
>> ---
>> drivers/mmc/host/sdhci-esdhc.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/mmc/host/sdhci-esdhc.h b/drivers/mmc/host/sdhci-esdhc.h
>> index a2a06420e463..ebff71092743 100644
>> --- a/drivers/mmc/host/sdhci-esdhc.h
>> +++ b/drivers/mmc/host/sdhci-esdhc.h
>> @@ -47,7 +47,7 @@
>> #define ESDHC_DMA_SYSCTL 0x40c
>> #define ESDHC_DMA_SNOOP 0x00000040
>>
>> -#define ESDHC_HOST_CONTROL_RES 0x05
>> +#define ESDHC_HOST_CONTROL_RES 0x01
>>
>> static inline void esdhc_set_clock(struct sdhci_host *host, unsigned int clock,
>> unsigned int host_clock)
thanks,
--
js
suse labs
next prev parent reply other threads:[~2015-08-11 7:16 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-10 14:17 [patch added to the 3.12 stable tree] HID: usbhid: add Chicony/Pixart usb optical mouse that needs QUIRK_ALWAYS_POLL Jiri Slaby
2015-08-10 14:17 ` [patch added to the 3.12 stable tree] mm: avoid setting up anonymous pages into file mapping Jiri Slaby
2015-08-10 14:17 ` [patch added to the 3.12 stable tree] freeing unlinked file indefinitely delayed Jiri Slaby
2015-08-10 14:17 ` [patch added to the 3.12 stable tree] s390/sclp: clear upper register halves in _sclp_print_early Jiri Slaby
2015-08-10 14:17 ` [patch added to the 3.12 stable tree] ARC: make sure instruction_pointer() returns unsigned value Jiri Slaby
2015-08-10 14:17 ` [patch added to the 3.12 stable tree] genirq: Prevent resend to interrupts marked IRQ_NESTED_THREAD Jiri Slaby
2015-08-10 14:17 ` [patch added to the 3.12 stable tree] ALSA: usb-audio: Add MIDI support for Steinberg MI2/MI4 Jiri Slaby
2015-08-10 14:17 ` [patch added to the 3.12 stable tree] ALSA: usb-audio: add dB range mapping for some devices Jiri Slaby
2015-08-10 14:17 ` [patch added to the 3.12 stable tree] ALSA: hda - Fix MacBook Pro 5,2 quirk Jiri Slaby
2015-08-10 14:17 ` [patch added to the 3.12 stable tree] st: null pointer dereference panic caused by use after kref_put by st_open Jiri Slaby
2015-08-10 14:17 ` [patch added to the 3.12 stable tree] mac80211: clear subdir_stations when removing debugfs Jiri Slaby
2015-08-10 14:17 ` [patch added to the 3.12 stable tree] mmc: sdhci-esdhc: Make 8BIT bus work Jiri Slaby
2015-08-10 15:27 ` Joakim Tjernlund
2015-08-11 7:16 ` Jiri Slaby [this message]
2015-08-11 8:26 ` Joakim Tjernlund
2015-08-10 14:17 ` [patch added to the 3.12 stable tree] mmc: sdhci-pxav3: fix platform_data is not initialized Jiri Slaby
2015-08-10 14:17 ` [patch added to the 3.12 stable tree] md/raid1: fix test for 'was read error from last working device' Jiri Slaby
2015-08-10 14:17 ` [patch added to the 3.12 stable tree] tile: use free_bootmem_late() for initrd Jiri Slaby
2015-08-10 14:17 ` [patch added to the 3.12 stable tree] Input: usbtouchscreen - avoid unresponsive TSC-30 touch screen Jiri Slaby
2015-08-10 14:17 ` [patch added to the 3.12 stable tree] blkcg: fix gendisk reference leak in blkg_conf_prep() Jiri Slaby
2015-08-10 14:17 ` [patch added to the 3.12 stable tree] ata: pmp: add quirk for Marvell 4140 SATA PMP Jiri Slaby
2015-08-10 14:17 ` [patch added to the 3.12 stable tree] usb-storage: ignore ZTE MF 823 card reader in mode 0x1225 Jiri Slaby
2015-08-10 14:18 ` [patch added to the 3.12 stable tree] xhci: Calculate old endpoints correctly on device reset Jiri Slaby
2015-08-10 14:18 ` [patch added to the 3.12 stable tree] xhci: report U3 when link is in resume state Jiri Slaby
2015-08-10 14:18 ` [patch added to the 3.12 stable tree] xhci: prevent bus_suspend if SS port resuming in phase 1 Jiri Slaby
2015-08-10 14:18 ` [patch added to the 3.12 stable tree] xhci: do not report PLC when link is in internal resume state Jiri Slaby
2015-08-10 14:18 ` [patch added to the 3.12 stable tree] rds: rds_ib_device.refcount overflow Jiri Slaby
2015-08-10 14:18 ` [patch added to the 3.12 stable tree] vhost: actually track log eventfd file Jiri Slaby
2015-08-10 14:18 ` [patch added to the 3.12 stable tree] iscsi-target: Fix use-after-free during TPG session shutdown Jiri Slaby
2015-08-10 14:18 ` [patch added to the 3.12 stable tree] iscsi-target: Fix iser explicit logout TX kthread leak Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55C9A14F.8060609@suse.cz \
--to=jslaby@suse.cz \
--cc=gregkh@linuxfoundation.org \
--cc=joakim.tjernlund@transmode.se \
--cc=stable@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.