From: Aravind Gopalakrishnan <aravind.gopalakrishnan@amd.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>,
Jan Beulich <JBeulich@suse.com>
Cc: boris.ostrovsky@oracle.com, keir@xen.org,
Suravee.Suthikulpanit@amd.com, xen-devel@lists.xen.org
Subject: Re: [PATCH V3] x86, amd_ucode: Skip microcode updates for final levels
Date: Tue, 11 Aug 2015 10:28:17 -0500 [thread overview]
Message-ID: <55CA1491.7040502@amd.com> (raw)
In-Reply-To: <55CA1220.8030209@citrix.com>
On 8/11/2015 10:17 AM, Andrew Cooper wrote:
>>
>>>> + 0x01000098,
>>>> + 0x0100009f,
>>>> + 0x010000af
>>>> +};
>>>> +
>>>> +static bool_t check_final_patch_levels(int cpu)
>>> unsigned int
>>>
>> I can change this too, but- Any specific reason for this?
>> The other sanity checker or verification functions like
>> verify_patch_size() or microcode_fits() return a bool_t too..
> "int cpu" is the issue (I am guessing), not the return type.
>
Thought about that too.. but all the microcode_ops functions accept an
'int cpu'.
I'm just using the same type in check_final_patch_levels().
Anyway, will wait for Jan's feedback..
Thanks,
-Aravind.
next prev parent reply other threads:[~2015-08-11 15:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-03 19:34 [PATCH V3] x86, amd_ucode: Skip microcode updates for final levels Aravind Gopalakrishnan
2015-08-03 19:54 ` Boris Ostrovsky
2015-08-03 22:51 ` Andrew Cooper
2015-08-11 14:53 ` Jan Beulich
2015-08-11 15:14 ` Aravind Gopalakrishnan
2015-08-11 15:17 ` Andrew Cooper
2015-08-11 15:28 ` Aravind Gopalakrishnan [this message]
2015-08-11 15:32 ` Jan Beulich
2015-08-11 15:43 ` Aravind Gopalakrishnan
2015-08-11 15:57 ` Jan Beulich
2015-08-11 15:29 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55CA1491.7040502@amd.com \
--to=aravind.gopalakrishnan@amd.com \
--cc=JBeulich@suse.com \
--cc=Suravee.Suthikulpanit@amd.com \
--cc=andrew.cooper3@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=keir@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.