From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>,
xen-devel <xen-devel@lists.xenproject.org>
Cc: Kevin Tian <kevin.tian@intel.com>, Wei Liu <wei.liu2@citrix.com>,
George Dunlap <George.Dunlap@eu.citrix.com>,
Yang Z Zhang <yang.z.zhang@intel.com>,
"tiejun.chen@intel.com" <tiejun.chen@intel.com>,
Keir Fraser <keir@xen.org>
Subject: Re: [PATCH] x86/p2m: clear_identity_p2m_entry() must cope with 'relaxed' RDM mode
Date: Wed, 12 Aug 2015 17:06:26 +0100 [thread overview]
Message-ID: <55CB6F02.10308@citrix.com> (raw)
In-Reply-To: <55CB7CE7020000780009A345@prv-mh.provo.novell.com>
On 12/08/15 16:05, Jan Beulich wrote:
> Tearing down a 1:1 mapping that was never established isn't really nice
> (and in fact hits an ASSERT() in p2m_remove_page()). Convert from a
> wrapper macro to a proper function which then can take care of the
> situation.
>
> Also take the opportunity to remove the 'page_order' parameter of
> clear_identity_p2m_entry(), to make it match set_identity_p2m_entry().
What about identity mapping with 2MB frames? IMO, the RMRR code is
incorrect in assuming that only 4K frames will be wanted, but that is a
separate issue.
As this at least matches the set_identity side of things, and improves
the situation, so
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
(I presume you intended to include a SoB tag?)
~Andrew
next prev parent reply other threads:[~2015-08-12 16:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-12 15:05 [PATCH] x86/p2m: clear_identity_p2m_entry() must cope with 'relaxed' RDM mode Jan Beulich
2015-08-12 16:06 ` Andrew Cooper [this message]
2015-08-13 6:24 ` Jan Beulich
2015-08-13 9:26 ` Wei Liu
2015-08-14 7:26 ` Tian, Kevin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55CB6F02.10308@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=keir@xen.org \
--cc=kevin.tian@intel.com \
--cc=tiejun.chen@intel.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
--cc=yang.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.