From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Lars-Peter Clausen <lars@metafoo.de>,
Xander Huff <xander.huff@ni.com>,
jic23@kernel.org
Cc: knaack.h@gmx.de, pmeerw@pmeerw.net, michal.simek@xilinx.com,
soren.brinkmann@xilinx.com, linux-iio@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rt-users@vger.kernel.org, linux-kernel@vger.kernel.org,
joe.hershberger@ni.com, joshc@ni.com, nathan.sullivan@ni.com,
jaeden.amero@ni.com
Subject: Re: [PATCH v4] iio: adc: xilinx-xadc: Push interrupts into hardirq context
Date: Wed, 12 Aug 2015 18:33:28 +0200 [thread overview]
Message-ID: <55CB7558.3090608@linutronix.de> (raw)
In-Reply-To: <55CB6391.7060502@metafoo.de>
On 08/12/2015 05:17 PM, Lars-Peter Clausen wrote:
> On 08/12/2015 01:00 AM, Xander Huff wrote:
>> Unfortunately, this breaks PREEMPT_RT builds, where a spinlock can sleep,
>> and is thus not able to be acquired from a hardirq handler. This patch gets
>> rid of the threaded handler and pushes all interrupt handling into the
>> hardirq context, and uses request_irq().
>>
>> To validate that this change has no impact on RT performance, here are
>> cyclictest values with no processes running:
>
> Looks good, thanks.
>
> Acked-by: Lars-Peter Clausen <lars@metafoo.de>
Yes, I'm fine with the rework, too.
Sebastian
WARNING: multiple messages have this Message-ID (diff)
From: Sebastian Andrzej Siewior <bigeasy-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
To: Lars-Peter Clausen <lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>,
Xander Huff <xander.huff-acOepvfBmUk@public.gmane.org>,
jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org
Cc: knaack.h-Mmb7MZpHnFY@public.gmane.org,
pmeerw-jW+XmwGofnusTnJN9+BGXg@public.gmane.org,
michal.simek-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org,
soren.brinkmann-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org,
linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-rt-users-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
joe.hershberger-acOepvfBmUk@public.gmane.org,
joshc-acOepvfBmUk@public.gmane.org,
nathan.sullivan-acOepvfBmUk@public.gmane.org,
jaeden.amero-acOepvfBmUk@public.gmane.org
Subject: Re: [PATCH v4] iio: adc: xilinx-xadc: Push interrupts into hardirq context
Date: Wed, 12 Aug 2015 18:33:28 +0200 [thread overview]
Message-ID: <55CB7558.3090608@linutronix.de> (raw)
In-Reply-To: <55CB6391.7060502-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>
On 08/12/2015 05:17 PM, Lars-Peter Clausen wrote:
> On 08/12/2015 01:00 AM, Xander Huff wrote:
>> Unfortunately, this breaks PREEMPT_RT builds, where a spinlock can sleep,
>> and is thus not able to be acquired from a hardirq handler. This patch gets
>> rid of the threaded handler and pushes all interrupt handling into the
>> hardirq context, and uses request_irq().
>>
>> To validate that this change has no impact on RT performance, here are
>> cyclictest values with no processes running:
>
> Looks good, thanks.
>
> Acked-by: Lars-Peter Clausen <lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>
Yes, I'm fine with the rework, too.
Sebastian
WARNING: multiple messages have this Message-ID (diff)
From: bigeasy@linutronix.de (Sebastian Andrzej Siewior)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4] iio: adc: xilinx-xadc: Push interrupts into hardirq context
Date: Wed, 12 Aug 2015 18:33:28 +0200 [thread overview]
Message-ID: <55CB7558.3090608@linutronix.de> (raw)
In-Reply-To: <55CB6391.7060502@metafoo.de>
On 08/12/2015 05:17 PM, Lars-Peter Clausen wrote:
> On 08/12/2015 01:00 AM, Xander Huff wrote:
>> Unfortunately, this breaks PREEMPT_RT builds, where a spinlock can sleep,
>> and is thus not able to be acquired from a hardirq handler. This patch gets
>> rid of the threaded handler and pushes all interrupt handling into the
>> hardirq context, and uses request_irq().
>>
>> To validate that this change has no impact on RT performance, here are
>> cyclictest values with no processes running:
>
> Looks good, thanks.
>
> Acked-by: Lars-Peter Clausen <lars@metafoo.de>
Yes, I'm fine with the rework, too.
Sebastian
next prev parent reply other threads:[~2015-08-12 16:33 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-07 15:38 [PATCH] iio: adc: xilinx-xadc: Convert to raw spinlock Xander Huff
2015-05-07 15:38 ` Xander Huff
2015-05-07 15:38 ` Xander Huff
2015-05-14 17:10 ` Sebastian Andrzej Siewior
2015-05-14 17:10 ` Sebastian Andrzej Siewior
2015-05-14 17:10 ` Sebastian Andrzej Siewior
2015-05-14 22:45 ` Xander Huff
2015-05-14 22:45 ` Xander Huff
2015-05-14 22:45 ` Xander Huff
2015-05-18 21:17 ` Sebastian Andrzej Siewior
2015-05-18 21:17 ` Sebastian Andrzej Siewior
2015-05-18 21:17 ` Sebastian Andrzej Siewior
2015-05-23 11:36 ` Jonathan Cameron
2015-05-23 11:36 ` Jonathan Cameron
2015-06-07 15:29 ` Jonathan Cameron
2015-06-07 15:29 ` Jonathan Cameron
2015-06-07 15:29 ` Jonathan Cameron
2015-06-08 14:44 ` Xander Huff
2015-06-08 14:44 ` Xander Huff
2015-06-08 14:44 ` Xander Huff
2015-07-08 21:38 ` [PATCH v2] iio: adc: xilinx-xadc: Push interrupts into threaded context Xander Huff
2015-07-08 21:38 ` Xander Huff
2015-07-08 21:38 ` Xander Huff
2015-07-09 5:03 ` Shubhrajyoti Datta
2015-07-15 15:57 ` Xander Huff
2015-07-15 15:57 ` Xander Huff
2015-07-15 15:57 ` Xander Huff
2015-07-20 23:14 ` [PATCH v3] " Xander Huff
2015-07-20 23:14 ` Xander Huff
2015-07-20 23:14 ` Xander Huff
2015-07-24 12:38 ` Lars-Peter Clausen
2015-07-24 12:38 ` Lars-Peter Clausen
2015-07-24 12:38 ` Lars-Peter Clausen
2015-08-03 20:18 ` Xander Huff
2015-08-03 20:18 ` Xander Huff
2015-08-03 20:18 ` Xander Huff
2015-08-04 8:01 ` Lars-Peter Clausen
2015-08-04 8:01 ` Lars-Peter Clausen
2015-08-04 8:01 ` Lars-Peter Clausen
2015-08-11 23:00 ` [PATCH v4] iio: adc: xilinx-xadc: Push interrupts into hardirq context Xander Huff
2015-08-11 23:00 ` Xander Huff
2015-08-12 15:17 ` Lars-Peter Clausen
2015-08-12 15:17 ` Lars-Peter Clausen
2015-08-12 15:17 ` Lars-Peter Clausen
2015-08-12 16:33 ` Sebastian Andrzej Siewior [this message]
2015-08-12 16:33 ` Sebastian Andrzej Siewior
2015-08-12 16:33 ` Sebastian Andrzej Siewior
2015-08-15 19:55 ` Jonathan Cameron
2015-08-15 19:55 ` Jonathan Cameron
2015-08-15 19:55 ` Jonathan Cameron
2015-08-04 5:34 ` [PATCH v3] iio: adc: xilinx-xadc: Push interrupts into threaded context Shubhrajyoti Datta
2015-08-04 5:34 ` Shubhrajyoti Datta
2015-08-04 8:05 ` Lars-Peter Clausen
2015-08-04 8:05 ` Lars-Peter Clausen
2015-08-04 8:05 ` Lars-Peter Clausen
2015-08-07 3:55 ` Shubhrajyoti Datta
2015-08-07 3:55 ` Shubhrajyoti Datta
2015-08-07 3:55 ` Shubhrajyoti Datta
2015-07-14 14:28 ` [PATCH v2] " Sebastian Andrzej Siewior
2015-07-14 14:28 ` Sebastian Andrzej Siewior
2015-07-15 15:59 ` Xander Huff
2015-07-15 15:59 ` Xander Huff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55CB7558.3090608@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=jaeden.amero@ni.com \
--cc=jic23@kernel.org \
--cc=joe.hershberger@ni.com \
--cc=joshc@ni.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=nathan.sullivan@ni.com \
--cc=pmeerw@pmeerw.net \
--cc=soren.brinkmann@xilinx.com \
--cc=xander.huff@ni.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.