From: Hannes Reinecke <hare@suse.de>
To: Kent Overstreet <kent.overstreet@gmail.com>
Cc: device-mapper development <dm-devel@redhat.com>,
Christoph Hellwig <hch@lst.de>,
Neil@redhat.com, Mike Snitzer <snitzer@redhat.com>,
Ming Lei <ming.lei@canonical.com>,
Al@redhat.com, Alasdair Kergon <agk@redhat.com>,
Lars Ellenberg <drbd-dev@lists.linbit.com>,
Philip Kelleher <pjk1939@linux.vnet.ibm.com>,
Christoph Hellwig <hch@infradead.org>,
Nitin Gupta <ngupta@vflare.org>,
Ming Lin <ming.l@ssi.samsung.com>,
Oleg Drokin <oleg.drokin@intel.com>,
Viro <viro@zeniv.linux.org.uk>, Jens Axboe <axboe@kernel.dk>,
Andreas Dilger <andreas.dilger@intel.com>,
Geoff Levand <geoff@infradead.org>, Jiri Kosina <jkosina@suse.cz>,
lkml <linux-kernel@vger.kernel.org>, Jim Paris <jim@jtan.com>,
Minchan Kim <minchan@kernel.org>, Dongsu Park <dpark@posteo.net>,
drbd-user@lists.linbit.com
Subject: Re: [dm-devel] [PATCH v5 01/11] block: make generic_make_request handle arbitrarily sized bios
Date: Thu, 13 Aug 2015 08:04:42 +0200 [thread overview]
Message-ID: <55CC337A.1050608@suse.de> (raw)
In-Reply-To: <20150808090205.GA15061@kmo-pixel>
On 08/08/2015 11:02 AM, Kent Overstreet wrote:
> On Sat, Aug 08, 2015 at 10:52:24AM +0200, Hannes Reinecke wrote:
>> Wouldn't it be easier to move both max_write_same_sectors and
>> max_discard sectors to 64 bit (ie to type sector_t) and be done with the
>> overflow?
>> Seems to me this is far too much coding around self-imposed restrictions...
>
> It's bio->bi_iter.bi_size that would have to be increased to 64 bits. Which I
> suppose wouldn't actually increase the size of struct bio (when sector_t is 64
> bits), since struct bvec_iter has padding right now...
>
Which I guess we should be doing anyway.
Devices are getting larger and larger, so in the long run in need to
be moved to 64 bits.
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
WARNING: multiple messages have this Message-ID (diff)
From: Hannes Reinecke <hare@suse.de>
To: Kent Overstreet <kent.overstreet@gmail.com>
Cc: Mike Snitzer <snitzer@redhat.com>,
Ming Lei <ming.lei@canonical.com>,
Neil@redhat.com, device-mapper development <dm-devel@redhat.com>,
Christoph Hellwig <hch@lst.de>, Alasdair Kergon <agk@redhat.com>,
Lars Ellenberg <drbd-dev@lists.linbit.com>,
Philip Kelleher <pjk1939@linux.vnet.ibm.com>,
Christoph Hellwig <hch@infradead.org>,
Nitin Gupta <ngupta@vflare.org>,
Ming Lin <ming.l@ssi.samsung.com>,
Al@redhat.com, Oleg Drokin <oleg.drokin@intel.com>,
Viro <viro@zeniv.linux.org.uk>, Jens Axboe <axboe@kernel.dk>,
Andreas Dilger <andreas.dilger@intel.com>,
Geoff Levand <geoff@infradead.org>, Jiri Kosina <jkosina@suse.cz>,
lkml <linux-kernel@vger.kernel.org>, Jim Paris <jim@jtan.com>,
Minchan Kim <minchan@kernel.org>, Dongsu Park <dpark@posteo.net>,
drbd-user@lists.linbit.com
Subject: Re: [Drbd-dev] [dm-devel] [PATCH v5 01/11] block: make generic_make_request handle arbitrarily sized bios
Date: Fri, 11 Sep 2015 13:22:37 -0000 [thread overview]
Message-ID: <55CC337A.1050608@suse.de> (raw)
In-Reply-To: <20150808090205.GA15061@kmo-pixel>
On 08/08/2015 11:02 AM, Kent Overstreet wrote:
> On Sat, Aug 08, 2015 at 10:52:24AM +0200, Hannes Reinecke wrote:
>> Wouldn't it be easier to move both max_write_same_sectors and
>> max_discard sectors to 64 bit (ie to type sector_t) and be done with the
>> overflow?
>> Seems to me this is far too much coding around self-imposed restrictions...
>
> It's bio->bi_iter.bi_size that would have to be increased to 64 bits. Which I
> suppose wouldn't actually increase the size of struct bio (when sector_t is 64
> bits), since struct bvec_iter has padding right now...
>
Which I guess we should be doing anyway.
Devices are getting larger and larger, so in the long run in need to
be moved to 64 bits.
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
next prev parent reply other threads:[~2015-08-13 6:04 UTC|newest]
Thread overview: 148+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-06 7:44 [PATCH v5 01/11] block: make generic_make_request handle arbitrarily sized bios Ming Lin
2015-07-06 7:44 ` [Drbd-dev] " Ming Lin
2015-07-06 7:44 ` [PATCH v5 02/11] block: simplify bio_add_page() Ming Lin
2015-07-06 7:44 ` [PATCH v5 03/11] bcache: remove driver private bio splitting code Ming Lin
2015-07-06 7:44 ` [PATCH v5 04/11] btrfs: remove bio splitting and merge_bvec_fn() calls Ming Lin
2015-07-06 7:44 ` [PATCH v5 05/11] block: remove split code in blkdev_issue_discard Ming Lin
2015-07-06 7:44 ` [PATCH v5 06/11] md/raid5: split bio for chunk_aligned_read Ming Lin
2015-07-06 7:44 ` [PATCH v5 07/11] md/raid5: get rid of bio_fits_rdev() Ming Lin
2015-07-06 7:44 ` [PATCH v5 08/11] block: kill merge_bvec_fn() completely Ming Lin
2015-07-06 7:44 ` [Drbd-dev] " Ming Lin
2015-07-06 7:44 ` [PATCH v5 09/11] fs: use helper bio_add_page() instead of open coding on bi_io_vec Ming Lin
2015-07-06 7:44 ` [PATCH v5 10/11] block: remove bio_get_nr_vecs() Ming Lin
2015-07-06 10:58 ` Steven Whitehouse
2015-07-06 17:21 ` Ming Lin
2015-07-07 9:04 ` Steven Whitehouse
2015-07-06 7:44 ` [PATCH v5 11/11] Documentation: update notes in biovecs about arbitrarily sized bios Ming Lin
2015-07-31 19:23 ` [PATCH v5 01/11] block: make generic_make_request handle " Mike Snitzer
2015-07-31 19:23 ` [Drbd-dev] " Mike Snitzer
[not found] ` <20150731192337.GA8907-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-07-31 21:19 ` Ming Lin
2015-07-31 21:19 ` Ming Lin
2015-07-31 21:19 ` [Drbd-dev] " Ming Lin
[not found] ` <CAF1ivSZbMDgyo_-wFGusSNSZ1fonSMWmNU9aVavGFaQsmEyYmQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-07-31 21:38 ` Mike Snitzer
2015-07-31 21:38 ` Mike Snitzer
2015-07-31 21:38 ` [Drbd-dev] " Mike Snitzer
2015-07-31 22:02 ` Ming Lin
2015-07-31 22:18 ` Ming Lin
[not found] ` <20150731213831.GA16464-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-08-01 6:58 ` Ming Lin
2015-08-01 6:58 ` Ming Lin
2015-08-01 6:58 ` [Drbd-dev] " Ming Lin
2015-08-01 16:33 ` Mike Snitzer
2015-08-01 16:33 ` [Drbd-dev] " Mike Snitzer
[not found] ` <20150801163356.GA21478-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-08-03 5:58 ` Ming Lin
2015-08-03 5:58 ` Ming Lin
2015-08-03 5:58 ` [Drbd-dev] " Ming Lin
2015-08-04 11:36 ` Christoph Hellwig
2015-08-04 11:36 ` [Drbd-dev] " Christoph Hellwig
[not found] ` <20150804113626.GA12682-jcswGhMUV9g@public.gmane.org>
2015-08-05 6:03 ` Ming Lin
2015-08-05 6:03 ` Ming Lin
2015-08-05 6:03 ` [Drbd-dev] " Ming Lin
2015-08-07 7:30 ` Christoph Hellwig
2015-08-07 7:30 ` Christoph Hellwig
2015-08-07 7:30 ` [Drbd-dev] " Christoph Hellwig
[not found] ` <20150807073001.GA17485-jcswGhMUV9g@public.gmane.org>
2015-08-07 23:40 ` Ming Lin
2015-08-07 23:40 ` Ming Lin
2015-08-07 23:40 ` [Drbd-dev] " Ming Lin
2015-08-08 0:30 ` Kent Overstreet
2015-09-11 13:20 ` [Drbd-dev] " Kent Overstreet
2015-08-08 5:17 ` Ming Lin
2015-08-08 5:17 ` Ming Lin
2015-08-08 5:17 ` [Drbd-dev] " Ming Lin
2015-08-08 5:22 ` Kent Overstreet
2015-09-11 13:20 ` [Drbd-dev] " Kent Overstreet
2015-08-08 12:35 ` Christoph Hellwig
2015-08-08 12:35 ` Christoph Hellwig
2015-08-08 12:35 ` [Drbd-dev] " Christoph Hellwig
2015-08-08 8:52 ` [dm-devel] " Hannes Reinecke
2015-09-11 13:21 ` [Drbd-dev] " Hannes Reinecke
2015-08-08 9:02 ` Kent Overstreet
2015-09-11 13:21 ` [Drbd-dev] " Kent Overstreet
2015-08-13 6:04 ` Hannes Reinecke [this message]
2015-09-11 13:22 ` Hannes Reinecke
2015-08-07 0:00 ` Kent Overstreet
[not found] ` <20150807000004.GB30757-jC9Py7bek1znysI04z7BkA@public.gmane.org>
2015-08-07 7:30 ` Christoph Hellwig
2015-08-07 7:30 ` Christoph Hellwig
2015-08-07 7:30 ` [Drbd-dev] " Christoph Hellwig
2015-08-08 16:19 ` [dm-devel] " Martin K. Petersen
2015-08-08 16:19 ` Martin K. Petersen
2015-08-08 16:19 ` [Drbd-dev] " Martin K. Petersen
[not found] ` <yq18u9liwhj.fsf-+q57XtR/GgMb6DWv4sQWN6xOck334EZe@public.gmane.org>
2015-08-09 5:59 ` Ming Lin
2015-08-09 5:59 ` Ming Lin
2015-08-09 5:59 ` [Drbd-dev] " Ming Lin
2015-08-09 6:41 ` Christoph Hellwig
2015-08-09 6:41 ` Christoph Hellwig
2015-08-09 6:41 ` [Drbd-dev] " Christoph Hellwig
[not found] ` <20150809064128.GB2436-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2015-08-09 6:55 ` Ming Lin
2015-08-09 6:55 ` Ming Lin
2015-08-09 6:55 ` [Drbd-dev] " Ming Lin
2015-08-09 7:01 ` Christoph Hellwig
2015-08-09 7:01 ` Christoph Hellwig
2015-08-09 7:01 ` [Drbd-dev] " Christoph Hellwig
[not found] ` <20150809070128.GA25739-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2015-08-09 7:18 ` Ming Lin
2015-08-09 7:18 ` Ming Lin
2015-08-09 7:18 ` [Drbd-dev] " Ming Lin
2015-08-10 15:02 ` Mike Snitzer
2015-08-10 15:02 ` Mike Snitzer
2015-08-10 15:02 ` [Drbd-dev] " Mike Snitzer
[not found] ` <20150810150216.GA22719-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-08-10 16:14 ` Ming Lin
2015-08-10 16:14 ` Ming Lin
2015-08-10 16:14 ` [Drbd-dev] " Ming Lin
2015-08-10 16:18 ` Ming Lin
2015-08-10 16:18 ` Ming Lin
2015-08-10 16:18 ` [Drbd-dev] " Ming Lin
2015-08-10 16:40 ` Martin K. Petersen
2015-08-10 16:40 ` Martin K. Petersen
2015-08-10 16:40 ` [Drbd-dev] " Martin K. Petersen
2015-08-10 18:13 ` Mike Snitzer
2015-08-10 18:13 ` [Drbd-dev] " Mike Snitzer
[not found] ` <20150810181325.GA24125-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-08-10 22:30 ` Ming Lin
2015-08-10 22:30 ` Ming Lin
2015-08-10 22:30 ` [Drbd-dev] " Ming Lin
2015-08-10 16:22 ` Martin K. Petersen
2015-08-10 16:22 ` Martin K. Petersen
2015-08-10 16:22 ` [Drbd-dev] " Martin K. Petersen
2015-08-10 18:18 ` Ming Lin
2015-08-10 18:18 ` [Drbd-dev] " Ming Lin
2015-08-11 2:00 ` Martin K. Petersen
2015-08-11 2:00 ` Martin K. Petersen
2015-08-11 2:00 ` [Drbd-dev] " Martin K. Petersen
[not found] ` <yq1bneeh9df.fsf-+q57XtR/GgMb6DWv4sQWN6xOck334EZe@public.gmane.org>
2015-08-11 2:41 ` Mike Snitzer
2015-08-11 2:41 ` Mike Snitzer
2015-08-11 2:41 ` [Drbd-dev] " Mike Snitzer
2015-08-11 3:38 ` Kent Overstreet
2015-09-11 13:22 ` [Drbd-dev] " Kent Overstreet
2015-08-11 14:08 ` Mike Snitzer
2015-08-11 14:08 ` Mike Snitzer
2015-08-11 14:08 ` [Drbd-dev] " Mike Snitzer
2015-08-11 17:49 ` Martin K. Petersen
2015-08-11 17:49 ` Martin K. Petersen
2015-08-11 17:49 ` [Drbd-dev] " Martin K. Petersen
[not found] ` <yq11tf9hg01.fsf-+q57XtR/GgMb6DWv4sQWN6xOck334EZe@public.gmane.org>
2015-08-11 18:05 ` Martin K. Petersen
2015-08-11 18:05 ` Martin K. Petersen
2015-08-11 18:05 ` [Drbd-dev] " Martin K. Petersen
[not found] ` <yq1si7pg0px.fsf-+q57XtR/GgMb6DWv4sQWN6xOck334EZe@public.gmane.org>
2015-08-11 20:56 ` Ming Lin
2015-08-11 20:56 ` Ming Lin
2015-08-11 20:56 ` [Drbd-dev] " Ming Lin
2015-08-12 0:24 ` Martin K. Petersen
2015-08-12 0:24 ` Martin K. Petersen
2015-08-12 0:24 ` [Drbd-dev] " Martin K. Petersen
[not found] ` <yq137zpfj5j.fsf-+q57XtR/GgMb6DWv4sQWN6xOck334EZe@public.gmane.org>
2015-08-12 4:41 ` Ming Lin
2015-08-12 4:41 ` Ming Lin
2015-08-12 4:41 ` [Drbd-dev] " Ming Lin
[not found] ` <20150811024154.GA26351-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-08-11 17:36 ` Martin K. Petersen
2015-08-11 17:36 ` Martin K. Petersen
2015-08-11 17:36 ` [Drbd-dev] " Martin K. Petersen
[not found] ` <yq17fp1hgm0.fsf-+q57XtR/GgMb6DWv4sQWN6xOck334EZe@public.gmane.org>
2015-08-11 17:47 ` Mike Snitzer
2015-08-11 17:47 ` Mike Snitzer
2015-08-11 17:47 ` [Drbd-dev] " Mike Snitzer
[not found] ` <20150811174717.GA30439-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-08-11 18:01 ` [dm-devel] " Martin K. Petersen
2015-08-11 18:01 ` Martin K. Petersen
2015-08-11 18:01 ` [Drbd-dev] " Martin K. Petersen
2015-08-18 5:09 ` Ming Lin
2015-08-18 7:04 ` Ming Lin
2015-08-18 14:45 ` Mike Snitzer
2015-08-18 17:32 ` Ming Lin
2015-08-18 19:59 ` Mike Snitzer
2015-08-18 21:16 ` Ming Lin
2015-08-18 21:22 ` Mike Snitzer
2015-08-18 22:17 ` Ming Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55CC337A.1050608@suse.de \
--to=hare@suse.de \
--cc=Al@redhat.com \
--cc=Neil@redhat.com \
--cc=agk@redhat.com \
--cc=andreas.dilger@intel.com \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=dpark@posteo.net \
--cc=drbd-dev@lists.linbit.com \
--cc=drbd-user@lists.linbit.com \
--cc=geoff@infradead.org \
--cc=hch@infradead.org \
--cc=hch@lst.de \
--cc=jim@jtan.com \
--cc=jkosina@suse.cz \
--cc=kent.overstreet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=minchan@kernel.org \
--cc=ming.l@ssi.samsung.com \
--cc=ming.lei@canonical.com \
--cc=ngupta@vflare.org \
--cc=oleg.drokin@intel.com \
--cc=pjk1939@linux.vnet.ibm.com \
--cc=snitzer@redhat.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.