All of lore.kernel.org
 help / color / mirror / Atom feed
From: Roger Quadros <rogerq@ti.com>
To: Jim Davis <jim.epost@gmail.com>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	linux-next <linux-next@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	myungjoo.ham@samsung.com, cw00.choi@samsung.com
Subject: Re: randconfig build error with next-20150812, in drivers/extcon/extcon-palmas.c
Date: Thu, 13 Aug 2015 10:09:27 +0300	[thread overview]
Message-ID: <55CC42A7.1090806@ti.com> (raw)
In-Reply-To: <CA+r1ZhgSAhSaEgWUnJGSXjJdx7WcQOjjP0XHpn930XjG9xE_CQ@mail.gmail.com>

Hi,

On 12/08/15 17:46, Jim Davis wrote:
> Building with the attached random configuration file,
> 
> warning: (INTEL_SOC_DTS_IOSF_CORE && PUNIT_ATOM_DEBUG) selects
> IOSF_MBI which has unmet direct dependencies (PCI)
> 
> drivers/extcon/extcon-palmas.c: In function ‘palmas_gpio_id_detect’:
> drivers/extcon/extcon-palmas.c:136:2: error: implicit declaration of
> function ‘gpiod_get_value_cansleep’
> [-Werror=implicit-function-declaration]
>   id = gpiod_get_value_cansleep(palmas_usb->id_gpiod);
>   ^
> drivers/extcon/extcon-palmas.c: In function ‘palmas_usb_probe’:
> drivers/extcon/extcon-palmas.c:211:2: error: implicit declaration of
> function ‘devm_gpiod_get_optional’
> [-Werror=implicit-function-declaration]
>   palmas_usb->id_gpiod = devm_gpiod_get_optional(&pdev->dev, "id", GPIOD_ASIS);
>   ^
> drivers/extcon/extcon-palmas.c:211:67: error: ‘GPIOD_ASIS’ undeclared
> (first use in this function)
>   palmas_usb->id_gpiod = devm_gpiod_get_optional(&pdev->dev, "id", GPIOD_ASIS);
>                                                                    ^
> drivers/extcon/extcon-palmas.c:211:67: note: each undeclared
> identifier is reported only once for each function it appears in
> drivers/extcon/extcon-palmas.c:228:3: error: implicit declaration of
> function ‘gpiod_set_debounce’ [-Werror=implicit-function-declaration]
>    status = gpiod_set_debounce(palmas_usb->id_gpiod,
>    ^
> drivers/extcon/extcon-palmas.c:275:3: error: implicit declaration of
> function ‘gpiod_to_irq’ [-Werror=implicit-function-declaration]
>    palmas_usb->gpio_id_irq = gpiod_to_irq(palmas_usb->id_gpiod);
>    ^
> 
> 

Thanks for the catch.

This is because extcon-palmas.c doesn't include the header
include/linux/gpio/consumer.h

It will be addressed in the following thread
http://thread.gmane.org/gmane.linux.kernel/2019235

cheers,
-roger

WARNING: multiple messages have this Message-ID (diff)
From: Roger Quadros <rogerq@ti.com>
To: Jim Davis <jim.epost@gmail.com>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	linux-next <linux-next@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	<myungjoo.ham@samsung.com>, <cw00.choi@samsung.com>
Subject: Re: randconfig build error with next-20150812, in drivers/extcon/extcon-palmas.c
Date: Thu, 13 Aug 2015 10:09:27 +0300	[thread overview]
Message-ID: <55CC42A7.1090806@ti.com> (raw)
In-Reply-To: <CA+r1ZhgSAhSaEgWUnJGSXjJdx7WcQOjjP0XHpn930XjG9xE_CQ@mail.gmail.com>

Hi,

On 12/08/15 17:46, Jim Davis wrote:
> Building with the attached random configuration file,
> 
> warning: (INTEL_SOC_DTS_IOSF_CORE && PUNIT_ATOM_DEBUG) selects
> IOSF_MBI which has unmet direct dependencies (PCI)
> 
> drivers/extcon/extcon-palmas.c: In function ‘palmas_gpio_id_detect’:
> drivers/extcon/extcon-palmas.c:136:2: error: implicit declaration of
> function ‘gpiod_get_value_cansleep’
> [-Werror=implicit-function-declaration]
>   id = gpiod_get_value_cansleep(palmas_usb->id_gpiod);
>   ^
> drivers/extcon/extcon-palmas.c: In function ‘palmas_usb_probe’:
> drivers/extcon/extcon-palmas.c:211:2: error: implicit declaration of
> function ‘devm_gpiod_get_optional’
> [-Werror=implicit-function-declaration]
>   palmas_usb->id_gpiod = devm_gpiod_get_optional(&pdev->dev, "id", GPIOD_ASIS);
>   ^
> drivers/extcon/extcon-palmas.c:211:67: error: ‘GPIOD_ASIS’ undeclared
> (first use in this function)
>   palmas_usb->id_gpiod = devm_gpiod_get_optional(&pdev->dev, "id", GPIOD_ASIS);
>                                                                    ^
> drivers/extcon/extcon-palmas.c:211:67: note: each undeclared
> identifier is reported only once for each function it appears in
> drivers/extcon/extcon-palmas.c:228:3: error: implicit declaration of
> function ‘gpiod_set_debounce’ [-Werror=implicit-function-declaration]
>    status = gpiod_set_debounce(palmas_usb->id_gpiod,
>    ^
> drivers/extcon/extcon-palmas.c:275:3: error: implicit declaration of
> function ‘gpiod_to_irq’ [-Werror=implicit-function-declaration]
>    palmas_usb->gpio_id_irq = gpiod_to_irq(palmas_usb->id_gpiod);
>    ^
> 
> 

Thanks for the catch.

This is because extcon-palmas.c doesn't include the header
include/linux/gpio/consumer.h

It will be addressed in the following thread
http://thread.gmane.org/gmane.linux.kernel/2019235

cheers,
-roger

  reply	other threads:[~2015-08-13  7:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-12 14:46 randconfig build error with next-20150812, in drivers/extcon/extcon-palmas.c Jim Davis
2015-08-13  7:09 ` Roger Quadros [this message]
2015-08-13  7:09   ` Roger Quadros

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55CC42A7.1090806@ti.com \
    --to=rogerq@ti.com \
    --cc=cw00.choi@samsung.com \
    --cc=jim.epost@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=myungjoo.ham@samsung.com \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.