How to submit patches upstream for repos at git.yoctoproject.org (eg meta-renesas)

How to submit patches upstream for repos at git.yoctoproject.org (eg meta-renesas)

[Paul Sherwood]

Hi all,
I am not affiliated to any Yocto Project member organisation, but am 
assisting with integration at the Automotive Grade Linux project, which 
is re-using some work from upstreams at git.yoctoproject.org

Recently members of the AGL community have started contributing patches 
for meta-renesas at our mirror [1]. We would like to offer this and 
future work to upstream, and I am hoping to understand so that I can 
help guide AGL's activities so that we are properly aligned. Please can 
someone guide us on the accepted way to offer these and subsequent 
patches?

br
Paul

[1] https://gerrit.automotivelinux.org/gerrit/#/c/4047/

Re: How to submit patches upstream for repos at git.yoctoproject.org (eg meta-renesas)

[Nikolay Dimitrov]

Hi Paul,

On 08/13/2015 02:21 PM, Paul Sherwood wrote:
> Hi all,
> I am not affiliated to any Yocto Project member organisation, but am
> assisting with integration at the Automotive Grade Linux project, which
> is re-using some work from upstreams at git.yoctoproject.org
>
> Recently members of the AGL community have started contributing patches
> for meta-renesas at our mirror [1]. We would like to offer this and
> future work to upstream, and I am hoping to understand so that I can
> help guide AGL's activities so that we are properly aligned. Please can
> someone guide us on the accepted way to offer these and subsequent patches?
>
> br
> Paul
>
> [1] https://gerrit.automotivelinux.org/gerrit/#/c/4047/

Haven't seen you for a quite a while after Karlsruhe, hope you're doing
fine.

Regarding the upstreaming guidelines, the usual steps apply - ask
contributors to push patches as close to the upstream project as
possible, and just then go downstream, like this (in order of
preference):

1. Upstream components
2. Yocto meta layer (which you are reusing)
3. AGL repos

Also, it would be great if your AGL maintainers can enforce appropriate
patch tracking by Upstream-status tag + description, as it will help
everyone.

Kind regards,
Nikolay

Re: How to submit patches upstream for repos at git.yoctoproject.org (eg meta-renesas)

[Alexander Kanavin]

On 08/13/2015 02:21 PM, Paul Sherwood wrote:
> I am not affiliated to any Yocto Project member organisation, but am
> assisting with integration at the Automotive Grade Linux project, which
> is re-using some work from upstreams at git.yoctoproject.org
>
> Recently members of the AGL community have started contributing patches
> for meta-renesas at our mirror [1]. We would like to offer this and
> future work to upstream, and I am hoping to understand so that I can
> help guide AGL's activities so that we are properly aligned. Please can
> someone guide us on the accepted way to offer these and subsequent patches?

I think these two pages provide a comprehensive answer:

http://www.openembedded.org/wiki/How_to_submit_a_patch_to_OpenEmbedded
http://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines


Alex

Re: How to submit patches upstream for repos at git.yoctoproject.org (eg meta-renesas)

[Paul Sherwood]

Hi Nikolay!
On 2015-08-13 13:32, Nikolay Dimitrov wrote:
> On 08/13/2015 02:21 PM, Paul Sherwood wrote:
>> Hi all,
>> I am not affiliated to any Yocto Project member organisation, but am
>> assisting with integration at the Automotive Grade Linux project, 
>> which
>> is re-using some work from upstreams at git.yoctoproject.org
>>
>> Recently members of the AGL community have started contributing 
>> patches
>> for meta-renesas at our mirror [1]. We would like to offer this and
>> future work to upstream, and I am hoping to understand so that I can
>> help guide AGL's activities so that we are properly aligned. Please 
>> can
>> someone guide us on the accepted way to offer these and subsequent 
>> patches?
>>
>> br
>> Paul
>>
>> [1] https://gerrit.automotivelinux.org/gerrit/#/c/4047/
>
> Haven't seen you for a quite a while after Karlsruhe, hope you're 
> doing
> fine.

Small world! I am  very well thank you - it's great to re-connect with 
old friends here :-)

> Regarding the upstreaming guidelines, the usual steps apply - ask
> contributors to push patches as close to the upstream project as
> possible, and just then go downstream, like this (in order of
> preference):
>
> 1. Upstream components
> 2. Yocto meta layer (which you are reusing)
> 3. AGL repos

Understood, thank you. So in this case, for patches to meta-renesas, 
should we email them to this list, or another list, or send directly to 
the maintainer, or is there another mechanism established?

> Also, it would be great if your AGL maintainers can enforce 
> appropriate
> patch tracking by Upstream-status tag + description, as it will help
> everyone.

Yes, I completely agree.

br
Paul

> Kind regards,
> Nikolay

Re: How to submit patches upstream for repos at git.yoctoproject.org (eg meta-renesas)

[Nikolay Dimitrov]

Hi Paul,

On 08/13/2015 04:24 PM, Paul Sherwood wrote:
> Hi Nikolay!
> On 2015-08-13 13:32, Nikolay Dimitrov wrote:
>> On 08/13/2015 02:21 PM, Paul Sherwood wrote:
>>> Hi all,
>>> I am not affiliated to any Yocto Project member organisation, but am
>>> assisting with integration at the Automotive Grade Linux project, which
>>> is re-using some work from upstreams at git.yoctoproject.org
>>>
>>> Recently members of the AGL community have started contributing patches
>>> for meta-renesas at our mirror [1]. We would like to offer this and
>>> future work to upstream, and I am hoping to understand so that I can
>>> help guide AGL's activities so that we are properly aligned. Please can
>>> someone guide us on the accepted way to offer these and subsequent
>>> patches?
>>>
>>> br
>>> Paul
>>>
>>> [1] https://gerrit.automotivelinux.org/gerrit/#/c/4047/
>>
>> Haven't seen you for a quite a while after Karlsruhe, hope you're doing
>> fine.
>
> Small world! I am  very well thank you - it's great to re-connect with
> old friends here :-)
>
>> Regarding the upstreaming guidelines, the usual steps apply - ask
>> contributors to push patches as close to the upstream project as
>> possible, and just then go downstream, like this (in order of
>> preference):
>>
>> 1. Upstream components
>> 2. Yocto meta layer (which you are reusing)
>> 3. AGL repos
>
> Understood, thank you. So in this case, for patches to meta-renesas,
> should we email them to this list, or another list, or send directly to
> the maintainer, or is there another mechanism established?

Usually I would advice to send the patches to a Renesas-specific ML,
but I couldn't find it in the OE layers index, so it would be best to
ask the Renesas team.

@Stephen, Takeshi, Nobuhiro: Can you please advice which is the proper
ML for sending meta-renesas patches? Thanks.

>> Also, it would be great if your AGL maintainers can enforce appropriate
>> patch tracking by Upstream-status tag + description, as it will help
>> everyone.
>
> Yes, I completely agree.
>
> br
> Paul

Have a nice day,
Nikolay

Re: How to submit patches upstream for repos at git.yoctoproject.org (eg meta-renesas)

[Stephen Lawrence]

Hi,

> -----Original Message-----
> From: Nikolay Dimitrov [mailto:picmaster@mail.bg]
> Sent: 13 August 2015 15:11
> To: Paul Sherwood <paul.sherwood@codethink.co.uk>
> Cc: yocto@yoctoproject.org; automotive-discussions@lists.linuxfoundation.org;
> Stephen Lawrence <stephen.lawrence@renesas.com>; Takeshi Saito
> <takeshi.saito.xv@renesas.com>; Nobuhiro Iwamatsu(Retired)
> <nobuhiro.iwamatsu.yj@renesas.com>
> Subject: Re: [yocto] How to submit patches upstream for repos at
> git.yoctoproject.org (eg meta-renesas)
> 

[snip]

> > Understood, thank you. So in this case, for patches to meta-renesas,
> > should we email them to this list, or another list, or send directly to
> > the maintainer, or is there another mechanism established?
> 
> Usually I would advice to send the patches to a Renesas-specific ML,
> but I couldn't find it in the OE layers index, so it would be best to
> ask the Renesas team.
> 
> @Stephen, Takeshi, Nobuhiro: Can you please advice which is the proper
> ML for sending meta-renesas patches? Thanks.

The MAINTAINERS file [1] says email Genivi branch changes directly to me :).
However in the case of AGL I recall the AGL meeting minutes saying they were
going to start with a local branch. I don't know the reasoning, perhaps to facilitate 
the aggressive  timescale for the first release before processes bed down or 
are agreed. So that appears to be the short term upstream. Can the attendees
share the detail?

In the medium term a shared source would simplify but the utility of that will depend
largely on the extent to which version roadmaps can be aligned for both alliances
else there will just be separate branches anyway.
 
[1] https://github.com/slawr/meta-renesas/blob/genivi-7.0-bsp-1.8.0/MAINTAINERS

Regards

Steve