From: Al Stone <al.stone@linaro.org>
To: Timur Tabi <timur@codeaurora.org>
Cc: linux-acpi@vger.kernel.org,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
linaro-kernel@lists.linaro.org, linux-ia64@vger.kernel.org,
patches@linaro.org, linux-pm@vger.kernel.org,
linaro-acpi@lists.linaro.org,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
lkml <linux-kernel@vger.kernel.org>, Len Brown <lenb@kernel.org>
Subject: Re: [Linaro-acpi] [PATCH 1/5] ACPI: add in a bad_madt_entry() function to eventually replace the macro
Date: Thu, 13 Aug 2015 09:43:46 -0600 [thread overview]
Message-ID: <55CCBB32.6000103@linaro.org> (raw)
In-Reply-To: <CAOZdJXVZomskfpvEjmDUiptW3SndJWvfKyzd9SwJp3dh7h3pig@mail.gmail.com>
On 08/12/2015 04:35 PM, Timur Tabi wrote:
> On Thu, Aug 6, 2015 at 3:59 PM, Al Stone <al.stone@linaro.org> wrote:
>> + while (ms->num_types != 0) {
>> + if (ms->major_version == major &&
>> + ms->minor_version == minor &&
>> + ms->madt_version == madt->header.revision)
>> + break;
>> + ms++;
>> + }
>> + if (!ms) {
>
> Shouldn't this be
>
> if (!ms->num_types) {
>
> instead?
>
Argh. Yes, it should. It will always be false, otherwise.
Will fix for next version. Thanks for catching that.
--
ciao,
al
-----------------------------------
Al Stone
Software Engineer
Linaro Enterprise Group
al.stone@linaro.org
-----------------------------------
WARNING: multiple messages have this Message-ID (diff)
From: Al Stone <al.stone@linaro.org>
To: Timur Tabi <timur@codeaurora.org>
Cc: linux-acpi@vger.kernel.org,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
linaro-kernel@lists.linaro.org, linux-ia64@vger.kernel.org,
patches@linaro.org, linux-pm@vger.kernel.org,
linaro-acpi@lists.linaro.org,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
lkml <linux-kernel@vger.kernel.org>, Len Brown <lenb@kernel.org>
Subject: Re: [Linaro-acpi] [PATCH 1/5] ACPI: add in a bad_madt_entry() function to eventually replace the mac
Date: Thu, 13 Aug 2015 15:43:46 +0000 [thread overview]
Message-ID: <55CCBB32.6000103@linaro.org> (raw)
In-Reply-To: <CAOZdJXVZomskfpvEjmDUiptW3SndJWvfKyzd9SwJp3dh7h3pig@mail.gmail.com>
On 08/12/2015 04:35 PM, Timur Tabi wrote:
> On Thu, Aug 6, 2015 at 3:59 PM, Al Stone <al.stone@linaro.org> wrote:
>> + while (ms->num_types != 0) {
>> + if (ms->major_version = major &&
>> + ms->minor_version = minor &&
>> + ms->madt_version = madt->header.revision)
>> + break;
>> + ms++;
>> + }
>> + if (!ms) {
>
> Shouldn't this be
>
> if (!ms->num_types) {
>
> instead?
>
Argh. Yes, it should. It will always be false, otherwise.
Will fix for next version. Thanks for catching that.
--
ciao,
al
-----------------------------------
Al Stone
Software Engineer
Linaro Enterprise Group
al.stone@linaro.org
-----------------------------------
WARNING: multiple messages have this Message-ID (diff)
From: al.stone@linaro.org (Al Stone)
To: linux-arm-kernel@lists.infradead.org
Subject: [Linaro-acpi] [PATCH 1/5] ACPI: add in a bad_madt_entry() function to eventually replace the macro
Date: Thu, 13 Aug 2015 09:43:46 -0600 [thread overview]
Message-ID: <55CCBB32.6000103@linaro.org> (raw)
In-Reply-To: <CAOZdJXVZomskfpvEjmDUiptW3SndJWvfKyzd9SwJp3dh7h3pig@mail.gmail.com>
On 08/12/2015 04:35 PM, Timur Tabi wrote:
> On Thu, Aug 6, 2015 at 3:59 PM, Al Stone <al.stone@linaro.org> wrote:
>> + while (ms->num_types != 0) {
>> + if (ms->major_version == major &&
>> + ms->minor_version == minor &&
>> + ms->madt_version == madt->header.revision)
>> + break;
>> + ms++;
>> + }
>> + if (!ms) {
>
> Shouldn't this be
>
> if (!ms->num_types) {
>
> instead?
>
Argh. Yes, it should. It will always be false, otherwise.
Will fix for next version. Thanks for catching that.
--
ciao,
al
-----------------------------------
Al Stone
Software Engineer
Linaro Enterprise Group
al.stone at linaro.org
-----------------------------------
next prev parent reply other threads:[~2015-08-13 15:43 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-06 20:59 [PATCH 0/5] ACPI: Provide better MADT subtable sanity checks Al Stone
2015-08-06 20:59 ` Al Stone
2015-08-06 20:59 ` Al Stone
2015-08-06 20:59 ` [PATCH 1/5] ACPI: add in a bad_madt_entry() function to eventually replace the macro Al Stone
2015-08-06 20:59 ` Al Stone
2015-08-06 20:59 ` Al Stone
2015-08-12 22:35 ` [Linaro-acpi] " Timur Tabi
2015-08-12 22:35 ` Timur Tabi
2015-08-12 22:35 ` [Linaro-acpi] [PATCH 1/5] ACPI: add in a bad_madt_entry() function to eventually replace the mac Timur Tabi
2015-08-13 9:30 ` [Linaro-acpi] [PATCH 1/5] ACPI: add in a bad_madt_entry() function to eventually replace the macro Hanjun Guo
2015-08-13 9:30 ` Hanjun Guo
2015-08-13 9:30 ` [Linaro-acpi] [PATCH 1/5] ACPI: add in a bad_madt_entry() function to eventually replace the mac Hanjun Guo
2015-08-13 15:43 ` Al Stone [this message]
2015-08-13 15:43 ` [Linaro-acpi] [PATCH 1/5] ACPI: add in a bad_madt_entry() function to eventually replace the macro Al Stone
2015-08-13 15:43 ` [Linaro-acpi] [PATCH 1/5] ACPI: add in a bad_madt_entry() function to eventually replace the mac Al Stone
2015-08-13 9:28 ` [PATCH 1/5] ACPI: add in a bad_madt_entry() function to eventually replace the macro Hanjun Guo
2015-08-13 9:28 ` Hanjun Guo
2015-08-13 9:28 ` Hanjun Guo
2015-08-06 20:59 ` [PATCH 2/5] ACPI / ARM64: remove usage of BAD_MADT_ENTRY/BAD_MADT_GICC_ENTRY Al Stone
2015-08-06 20:59 ` Al Stone
2015-08-06 20:59 ` Al Stone
2015-08-07 9:04 ` Marc Zyngier
2015-08-07 9:04 ` Marc Zyngier
2015-08-07 9:04 ` Marc Zyngier
2015-08-07 16:57 ` Catalin Marinas
2015-08-07 16:57 ` Catalin Marinas
2015-08-07 16:57 ` Catalin Marinas
2015-08-06 20:59 ` [PATCH 3/5] ACPI / IA64: remove usage of BAD_MADT_ENTRY Al Stone
2015-08-06 20:59 ` Al Stone
2015-08-06 20:59 ` Al Stone
2015-08-06 20:59 ` Al Stone
2015-08-06 20:59 ` [PATCH 4/5] ACPI / X86: " Al Stone
2015-08-06 20:59 ` Al Stone
2015-08-06 20:59 ` Al Stone
2015-08-06 20:59 ` [PATCH 5/5] ACPI: remove definition of BAD_MADT_ENTRY macro Al Stone
2015-08-06 20:59 ` Al Stone
2015-08-06 20:59 ` Al Stone
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55CCBB32.6000103@linaro.org \
--to=al.stone@linaro.org \
--cc=lenb@kernel.org \
--cc=linaro-acpi@lists.linaro.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=patches@linaro.org \
--cc=rjw@rjwysocki.net \
--cc=timur@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.