ADF7242 driver ready for mainline inclusion?

ADF7242 driver ready for mainline inclusion?

[Stefan Schmidt]

Hello.

We have found the ADF7242 driver which lists you as author. :)

Alexander and myself are working on the linux-wpan subsystem which
handles IEEE 802.15.4. It seems the driver was submitted to the old
linux-zigbee project (ancestor of linux-wpan, renamed due to not being a
zigbee stack) but sadly never made it mainline when other parts have
been merged.

Are you still actively working on this driver? Is there an interest from
your side to get it into mainline? We would be happy to help you with
reviewing it.

So far I have only found these. Are they up to date?
http://wiki.analog.com/resources/tools-software/linux-drivers/networking-mac802154/adf7242
https://github.com/analogdevicesinc/linux/blob/xcomm_zynq/drivers/net/ieee802154/adf7242.c

regards
Stefan Schmidt

RE: ADF7242 driver ready for mainline inclusion?

[Hennerich, Michael]

Hi All,

I did tis driver a long time ago, when the Linux 802.15.4 support in general was at its beginning and pretty broken as well.
From time to time I update this driver - and actually it's pretty mature - and should apply to mainline without problems.

There is currently only one minor thing that I wanted to investigate (some ifdef in the ISR) before submitting the driver mainline.
Are you using the ADF7242 in a design already?
Do you have feedback already?

Best regards,
Michael

------------------------------------------------------------------
********* Analog Devices GmbH         michael.hennerich@analog.com
**  *****
**     ** Wilhelm-Wagenfeld-Strasse 6       phone +49-89-76903-322
**  ***** D-80807 Munich                      fax +49-89-76903-157
********* Germany                          mobile +49-175-295-0340

Sitz der Gesellschaft: München; Registergericht: München HRB 40368;
Geschäftsführer: Peter Kolberg, William A. Martin, Margaret K. Seif



-----Original Message-----
From: Stefan Schmidt [mailto:stefan@sostec.de] 
Sent: Thursday, August 13, 2015 11:02 AM
To: Hennerich, Michael
Cc: Alexander Aring; linux-wpan@vger.kernel.org
Subject: ADF7242 driver ready for mainline inclusion?

Hello.

We have found the ADF7242 driver which lists you as author. :)

Alexander and myself are working on the linux-wpan subsystem which handles IEEE 802.15.4. It seems the driver was submitted to the old linux-zigbee project (ancestor of linux-wpan, renamed due to not being a zigbee stack) but sadly never made it mainline when other parts have been merged.

Are you still actively working on this driver? Is there an interest from your side to get it into mainline? We would be happy to help you with reviewing it.

So far I have only found these. Are they up to date?
http://wiki.analog.com/resources/tools-software/linux-drivers/networking-mac802154/adf7242
https://github.com/analogdevicesinc/linux/blob/xcomm_zynq/drivers/net/ieee802154/adf7242.c

regards
Stefan Schmidt

Re: ADF7242 driver ready for mainline inclusion?

[Stefan Schmidt]

Hello.

On 13/08/15 20:50, Hennerich, Michael wrote:
> Hi All,
>
> I did tis driver a long time ago, when the Linux 802.15.4 support in general was at its beginning and pretty broken as well.
> From time to time I update this driver - and actually it's pretty mature - and should apply to mainline without problems.
>
> There is currently only one minor thing that I wanted to investigate (some ifdef in the ISR) before submitting the driver mainline.

This is great to hear! Looking forward to it. :)
> Are you using the ADF7242 in a design already?

No. The reason I wrote this is that I have an interest in the linux-wpan
subsystem in general and thought the driver would be a good candidate
for mainline.

I actually searched for some simple ADF7242which I could hook up to SPI
+ IRQ and maybe some more control lines. So far I only found the
official evaluation board which is to expensive for some hobbyist testing.
> Do you have feedback already?

The driver interface for ieee802154 has advanced since the it got merged
initially. Some of the new things you might want to look into and add
support are:

o Async transmit (xmit_async)
o LBT support (set_lbt)
o Set CC mode and ed level (set_cc_mode, set_cca_ed_level)
o Support for monitor mode (set_promiscuous_mode)

These I found missing when having a brief look over the driver.

regards
Stefan Schmidt

Re: ADF7242 driver ready for mainline inclusion?

[Michael Hennerich]

On 08/14/2015 09:13 AM, Stefan Schmidt wrote:
> Hello.
>
> On 13/08/15 20:50, Hennerich, Michael wrote:
>> Hi All,
>>
>> I did tis driver a long time ago, when the Linux 802.15.4 support in general was at its beginning and pretty broken as well.
>>  From time to time I update this driver - and actually it's pretty mature - and should apply to mainline without problems.
>>
>> There is currently only one minor thing that I wanted to investigate (some ifdef in the ISR) before submitting the driver mainline.
> This is great to hear! Looking forward to it. :)
>> Are you using the ADF7242 in a design already?
> No. The reason I wrote this is that I have an interest in the linux-wpan
> subsystem in general and thought the driver would be a good candidate
> for mainline.
>
> I actually searched for some simple ADF7242which I could hook up to SPI
> + IRQ and maybe some more control lines. So far I only found the
> official evaluation board which is to expensive for some hobbyist testing.

Well there is the EVAL-ADF7242-PMOD [1] which uses a PMOD [2] interface
basically a cheap 100mil spaced header, with SPI, IRQ and supply.

If you are really interested testing the driver I can provide you one FOC.

>> Do you have feedback already?
> The driver interface for ieee802154 has advanced since the it got merged
> initially. Some of the new things you might want to look into and add
> support are:
>
> o Async transmit (xmit_async)
> o LBT support (set_lbt)
> o Set CC mode and ed level (set_cc_mode, set_cca_ed_level)
> o Support for monitor mode (set_promiscuous_mode)
>
> These I found missing when having a brief look over the driver.

Thanks for the summary!

>
> regards
> Stefan Schmidt
>

[1] 
http://www.analog.com/en/design-center/evaluation-hardware-and-software/evaluation-boards-kits/EVAL-ADF7242-PMOD.html
[2] 
https://www.digilentinc.com/Pmods/Digilent-Pmod_%20Interface_Specification.pdf

-- 
Greetings,
Michael

--
Analog Devices GmbH      Wilhelm-Wagenfeld-Str. 6      80807 Muenchen
Sitz der Gesellschaft: Muenchen; Registergericht: Muenchen HRB 40368;
Geschaeftsfuehrer:Dr.Carsten Suckrow, Thomas Wessel, William A. Martin,
Margaret Seif

Re: ADF7242 driver ready for mainline inclusion?

[Stefan Schmidt]

Hello.

On 14/08/15 16:44, Michael Hennerich wrote:
> On 08/14/2015 09:13 AM, Stefan Schmidt wrote:
>> Hello.
>>
>> On 13/08/15 20:50, Hennerich, Michael wrote:
>>> Hi All,
>>>
>>> I did tis driver a long time ago, when the Linux 802.15.4 support in
>>> general was at its beginning and pretty broken as well.
>>>  From time to time I update this driver - and actually it's pretty
>>> mature - and should apply to mainline without problems.
>>>
>>> There is currently only one minor thing that I wanted to investigate
>>> (some ifdef in the ISR) before submitting the driver mainline.
>> This is great to hear! Looking forward to it. :)
>>> Are you using the ADF7242 in a design already?
>> No. The reason I wrote this is that I have an interest in the linux-wpan
>> subsystem in general and thought the driver would be a good candidate
>> for mainline.
>>
>> I actually searched for some simple ADF7242which I could hook up to SPI
>> + IRQ and maybe some more control lines. So far I only found the
>> official evaluation board which is to expensive for some hobbyist
>> testing.
>
> Well there is the EVAL-ADF7242-PMOD [1] which uses a PMOD [2] interface
> basically a cheap 100mil spaced header, with SPI, IRQ and supply.
>
I see. I have seen that one but was under the impression one needed the
mother board for this one as well. As it seems it should be easy to just
hookup the PMOD interface to all kind of boards via SPI, IRQ and some
more GPIOs.

> If you are really interested testing the driver I can provide you one
> FOC.
>

That is an interesting offer. Alex and myself try to keep a transceiver
around for every driver we have in tree, if possible. This helps during
review to test the patches as well as testing our own changes which
might touch all drivers. Given that Alex does the most work on this
right now I would propose to provide him with this board.

Alex, does that sound good to you?

>>> Do you have feedback already?
>> The driver interface for ieee802154 has advanced since the it got merged
>> initially. Some of the new things you might want to look into and add
>> support are:
>>
>> o Async transmit (xmit_async)
>> o LBT support (set_lbt)
>> o Set CC mode and ed level (set_cc_mode, set_cca_ed_level)
>> o Support for monitor mode (set_promiscuous_mode)
>>
>> These I found missing when having a brief look over the driver.
>
> Thanks for the summary!
>

These are not really a must to get the driver merged mainline. But if
you find some time working on it before submitting some of these might
be easy to add.

regards
Stefan Schmidt