From: Vlastimil Babka <vbabka@suse.cz>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: mhocko@kernel.org, linux-mm@kvack.org,
Mel Gorman <mgorman@suse.de>, Jiri Bohac <jbohac@suse.cz>,
Andrew Morton <akpm@linux-foundation.org>,
"David S. Miller" <davem@davemloft.net>,
LKML <linux-kernel@vger.kernel.org>,
netdev@vger.kernel.org, Michal Hocko <mhocko@suse.com>
Subject: Re: [PATCH] mm: make page pfmemalloc check more robust
Date: Fri, 14 Aug 2015 15:26:45 +0200 [thread overview]
Message-ID: <55CDEC95.5050307@suse.cz> (raw)
In-Reply-To: <1439476856.7960.8.camel@edumazet-glaptop2.roam.corp.google.com>
On 08/13/2015 04:40 PM, Eric Dumazet wrote:
> On Thu, 2015-08-13 at 11:13 +0200, Vlastimil Babka wrote:
>
>> Given that this apparently isn't the first case of this localhost issue,
>> I wonder if network code should just clear skb->pfmemalloc during send
>> (or maybe just send over localhost). That would be probably easier than
>> distinguish the __skb_fill_page_desc() callers for send vs receive.
>
> Would this still needed after this patch ?
Not until another corner case is discovered :) Or something passes a
genuine pfmemalloc page to a socket (sending contents of some slab
objects perhaps, where the slab page was allocated as pfmemalloc? Dunno
if that can happen right now).
> It is sad we do not have a SNMP counter to at least count how often we
> drop skb because pfmemalloc is set.
>
> I'll provide such a patch.
>
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Vlastimil Babka <vbabka@suse.cz>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: mhocko@kernel.org, linux-mm@kvack.org,
Mel Gorman <mgorman@suse.de>, Jiri Bohac <jbohac@suse.cz>,
Andrew Morton <akpm@linux-foundation.org>,
"David S. Miller" <davem@davemloft.net>,
LKML <linux-kernel@vger.kernel.org>,
netdev@vger.kernel.org, Michal Hocko <mhocko@suse.com>
Subject: Re: [PATCH] mm: make page pfmemalloc check more robust
Date: Fri, 14 Aug 2015 15:26:45 +0200 [thread overview]
Message-ID: <55CDEC95.5050307@suse.cz> (raw)
In-Reply-To: <1439476856.7960.8.camel@edumazet-glaptop2.roam.corp.google.com>
On 08/13/2015 04:40 PM, Eric Dumazet wrote:
> On Thu, 2015-08-13 at 11:13 +0200, Vlastimil Babka wrote:
>
>> Given that this apparently isn't the first case of this localhost issue,
>> I wonder if network code should just clear skb->pfmemalloc during send
>> (or maybe just send over localhost). That would be probably easier than
>> distinguish the __skb_fill_page_desc() callers for send vs receive.
>
> Would this still needed after this patch ?
Not until another corner case is discovered :) Or something passes a
genuine pfmemalloc page to a socket (sending contents of some slab
objects perhaps, where the slab page was allocated as pfmemalloc? Dunno
if that can happen right now).
> It is sad we do not have a SNMP counter to at least count how often we
> drop skb because pfmemalloc is set.
>
> I'll provide such a patch.
>
>
next prev parent reply other threads:[~2015-08-14 13:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-13 8:58 [PATCH] mm: make page pfmemalloc check more robust mhocko
2015-08-13 8:58 ` mhocko
2015-08-13 8:58 ` mhocko
2015-08-13 9:13 ` Vlastimil Babka
2015-08-13 9:13 ` Vlastimil Babka
2015-08-13 9:31 ` Michal Hocko
2015-08-13 9:31 ` Michal Hocko
2015-08-13 14:40 ` Eric Dumazet
2015-08-13 14:40 ` Eric Dumazet
2015-08-14 13:26 ` Vlastimil Babka [this message]
2015-08-14 13:26 ` Vlastimil Babka
2015-08-13 10:00 ` Mel Gorman
2015-08-13 10:00 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55CDEC95.5050307@suse.cz \
--to=vbabka@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=jbohac@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mhocko@kernel.org \
--cc=mhocko@suse.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.