From: Antonio Quartulli <antonio@meshcoding.com>
To: sergei.shtylyov@cogentembedded.com
Cc: netdev@vger.kernel.org,
The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>,
davem@davemloft.net, Marek Lindner <mareklindner@neomailbox.ch>
Subject: Re: [B.A.T.M.A.N.] [PATCH 03/10] batman-adv: Make DAT capability changes atomic
Date: Fri, 14 Aug 2015 22:49:03 +0200 [thread overview]
Message-ID: <55CE543F.1040507@meshcoding.com> (raw)
In-Reply-To: <55CA4ED2.9070207@cogentembedded.com>
[-- Attachment #1: Type: text/plain, Size: 516 bytes --]
On 11/08/15 21:36, Sergei Shtylyov wrote:
>> /* check if orig node candidate is running DAT */
>> - if (!(candidate->capabilities & BATADV_ORIG_CAPA_HAS_DAT))
>> + if (!(test_bit(BATADV_ORIG_CAPA_HAS_DAT, &candidate->capabilities)))
>
> () around the tst_bit() call not needed.
Thanks for the hint Sergei. Even if I don't remember having seen any
complaint from checkpatch.pl about this.
I'll resend the pull request with this fixed patches.
Cheers,
--
Antonio Quartulli
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Antonio Quartulli <antonio@meshcoding.com>
To: sergei.shtylyov@cogentembedded.com
Cc: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>,
davem@davemloft.net, netdev@vger.kernel.org,
Marek Lindner <mareklindner@neomailbox.ch>
Subject: Re: [B.A.T.M.A.N.] [PATCH 03/10] batman-adv: Make DAT capability changes atomic
Date: Fri, 14 Aug 2015 22:49:03 +0200 [thread overview]
Message-ID: <55CE543F.1040507@meshcoding.com> (raw)
In-Reply-To: <55CA4ED2.9070207@cogentembedded.com>
[-- Attachment #1: Type: text/plain, Size: 516 bytes --]
On 11/08/15 21:36, Sergei Shtylyov wrote:
>> /* check if orig node candidate is running DAT */
>> - if (!(candidate->capabilities & BATADV_ORIG_CAPA_HAS_DAT))
>> + if (!(test_bit(BATADV_ORIG_CAPA_HAS_DAT, &candidate->capabilities)))
>
> () around the tst_bit() call not needed.
Thanks for the hint Sergei. Even if I don't remember having seen any
complaint from checkpatch.pl about this.
I'll resend the pull request with this fixed patches.
Cheers,
--
Antonio Quartulli
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-08-14 20:49 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-11 16:35 [B.A.T.M.A.N.] pull request: batman-adv 20150811 Antonio Quartulli
2015-08-11 16:35 ` Antonio Quartulli
2015-08-11 16:35 ` [B.A.T.M.A.N.] [PATCH 01/10] batman-adv: Replace gw_reselect divisor with simple shift Antonio Quartulli
2015-08-11 16:35 ` Antonio Quartulli
2015-08-11 16:35 ` [PATCH 02/10] batman-adv: Avoid u32 overflow during gateway select Antonio Quartulli
2015-08-11 16:35 ` [B.A.T.M.A.N.] " Antonio Quartulli
2015-08-11 16:35 ` [B.A.T.M.A.N.] [PATCH 03/10] batman-adv: Make DAT capability changes atomic Antonio Quartulli
2015-08-11 16:35 ` Antonio Quartulli
2015-08-11 19:36 ` [B.A.T.M.A.N.] " Sergei Shtylyov
2015-08-11 19:36 ` Sergei Shtylyov
2015-08-14 20:49 ` Antonio Quartulli [this message]
2015-08-14 20:49 ` [B.A.T.M.A.N.] " Antonio Quartulli
2015-08-11 16:35 ` [B.A.T.M.A.N.] [PATCH 04/10] batman-adv: Make NC " Antonio Quartulli
2015-08-11 19:38 ` Sergei Shtylyov
2015-08-11 19:38 ` Sergei Shtylyov
2015-08-11 16:35 ` Antonio Quartulli
2015-08-11 16:35 ` [B.A.T.M.A.N.] [PATCH 05/10] batman-adv: Make TT " Antonio Quartulli
2015-08-11 16:35 ` Antonio Quartulli
2015-08-11 16:35 ` [B.A.T.M.A.N.] [PATCH 06/10] batman-adv: Make MCAST " Antonio Quartulli
2015-08-11 16:35 ` Antonio Quartulli
2015-08-11 16:35 ` [B.A.T.M.A.N.] [PATCH 07/10] batman-adv: Fix potential synchronization issues in mcast tvlv handler Antonio Quartulli
2015-08-11 16:35 ` Antonio Quartulli
2015-08-11 16:35 ` [B.A.T.M.A.N.] [PATCH 08/10] batman-adv: protect tt request from double deletion Antonio Quartulli
2015-08-11 16:35 ` Antonio Quartulli
2015-08-11 16:35 ` [B.A.T.M.A.N.] [PATCH 09/10] batman-adv: remove broadcast packets scheduled for purged outgoing if Antonio Quartulli
2015-08-11 16:35 ` Antonio Quartulli
2015-08-11 16:35 ` [PATCH 10/10] batman-adv: Fix potentially broken skb network header access Antonio Quartulli
2015-08-11 16:35 ` [B.A.T.M.A.N.] " Antonio Quartulli
-- strict thread matches above, loose matches on Subject: below --
2015-08-14 20:57 [B.A.T.M.A.N.] pull request: batman-adv 20150814 Antonio Quartulli
2015-08-14 20:57 ` [B.A.T.M.A.N.] [PATCH 03/10] batman-adv: Make DAT capability changes atomic Antonio Quartulli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55CE543F.1040507@meshcoding.com \
--to=antonio@meshcoding.com \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=davem@davemloft.net \
--cc=mareklindner@neomailbox.ch \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.