All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	linux-ia64@vger.kernel.org, Tony Luck <tony.luck@intel.com>,
	Fenghua Yu <fenghua.yu@intel.com>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFT PATCH] ia64: generic_defconfig: convert to use libata PATA drivers
Date: Mon, 17 Aug 2015 16:19:06 +0000	[thread overview]
Message-ID: <55D2097A.7090203@cogentembedded.com> (raw)
In-Reply-To: <1439826388-31456-2-git-send-email-b.zolnierkie@samsung.com>

Hello.

On 08/17/2015 06:46 PM, Bartlomiej Zolnierkiewicz wrote:

> IDE subsystem has been deprecated since 2009 and the majority
> (if not all) of Linux distributions have switched to use
> libata for ATA support exclusively.  However there are still
> some users (mostly old or/and embedded non-x86 systems) that
> have not converted from using IDE subsystem to libata PATA
> drivers.  This doesn't seem to be good thing in the long-term
> for Linux as while there is less and less PATA systems left
> in use:
>
> * testing efforts are divided between two subsystems
>
> * having duplicate drivers for same hardware confuses users
>
> This patch converts generic_defconfig to use libata PATA
> drivers (sgiioc4 IDE host driver has no corresponding libata
> driver yet so it is not converted).
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> ---
> Build tested only.
> If you have affected hardware please test.  Thank you.
>
>   arch/ia64/configs/generic_defconfig | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/ia64/configs/generic_defconfig b/arch/ia64/configs/generic_defconfig
> index 81f686d..f55be82 100644
> --- a/arch/ia64/configs/generic_defconfig
> +++ b/arch/ia64/configs/generic_defconfig
[...]
> @@ -62,6 +59,9 @@ CONFIG_SCSI_QLOGIC_1280=y
>   CONFIG_ATA=y
>   CONFIG_ATA_PIIX=y
>   CONFIG_SATA_VITESSE=y
> +CONFIG_PATA_CMD64X=y
> +CONFIG_PATA_MPIIX=y

    If you're enabling the MPIIX support (which I doubt is necessary), why not 
enable the "old" PIIX support?

> +CONFIG_ATA_GENERIC=y

MBR, Sergei


WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	linux-ia64@vger.kernel.org, Tony Luck <tony.luck@intel.com>,
	Fenghua Yu <fenghua.yu@intel.com>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFT PATCH] ia64: generic_defconfig: convert to use libata PATA drivers
Date: Mon, 17 Aug 2015 19:19:06 +0300	[thread overview]
Message-ID: <55D2097A.7090203@cogentembedded.com> (raw)
In-Reply-To: <1439826388-31456-2-git-send-email-b.zolnierkie@samsung.com>

Hello.

On 08/17/2015 06:46 PM, Bartlomiej Zolnierkiewicz wrote:

> IDE subsystem has been deprecated since 2009 and the majority
> (if not all) of Linux distributions have switched to use
> libata for ATA support exclusively.  However there are still
> some users (mostly old or/and embedded non-x86 systems) that
> have not converted from using IDE subsystem to libata PATA
> drivers.  This doesn't seem to be good thing in the long-term
> for Linux as while there is less and less PATA systems left
> in use:
>
> * testing efforts are divided between two subsystems
>
> * having duplicate drivers for same hardware confuses users
>
> This patch converts generic_defconfig to use libata PATA
> drivers (sgiioc4 IDE host driver has no corresponding libata
> driver yet so it is not converted).
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> ---
> Build tested only.
> If you have affected hardware please test.  Thank you.
>
>   arch/ia64/configs/generic_defconfig | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/ia64/configs/generic_defconfig b/arch/ia64/configs/generic_defconfig
> index 81f686d..f55be82 100644
> --- a/arch/ia64/configs/generic_defconfig
> +++ b/arch/ia64/configs/generic_defconfig
[...]
> @@ -62,6 +59,9 @@ CONFIG_SCSI_QLOGIC_1280=y
>   CONFIG_ATA=y
>   CONFIG_ATA_PIIX=y
>   CONFIG_SATA_VITESSE=y
> +CONFIG_PATA_CMD64X=y
> +CONFIG_PATA_MPIIX=y

    If you're enabling the MPIIX support (which I doubt is necessary), why not 
enable the "old" PIIX support?

> +CONFIG_ATA_GENERIC=y

MBR, Sergei

  reply	other threads:[~2015-08-17 16:19 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-17 15:46 [RFT PATCH] ia64: bigsur_defconfig: convert to use libata PATA drivers Bartlomiej Zolnierkiewicz
2015-08-17 15:46 ` Bartlomiej Zolnierkiewicz
2015-08-17 15:46 ` [RFT PATCH] ia64: generic_defconfig: " Bartlomiej Zolnierkiewicz
2015-08-17 15:46   ` Bartlomiej Zolnierkiewicz
2015-08-17 16:19   ` Sergei Shtylyov [this message]
2015-08-17 16:19     ` Sergei Shtylyov
2015-08-17 16:31     ` Bartlomiej Zolnierkiewicz
2015-08-17 16:31       ` Bartlomiej Zolnierkiewicz
2015-08-17 17:26       ` Sergei Shtylyov
2015-08-17 17:26         ` Sergei Shtylyov
2015-08-17 15:46 ` [RFT PATCH] ia64: gensparse_defconfig: " Bartlomiej Zolnierkiewicz
2015-08-17 15:46   ` Bartlomiej Zolnierkiewicz
2015-08-17 15:46 ` [RFT PATCH] ia64: tiger_defconfig: " Bartlomiej Zolnierkiewicz
2015-08-17 15:46   ` Bartlomiej Zolnierkiewicz
2015-08-17 15:46 ` [RFT PATCH] ia64: zx1_defconfig: " Bartlomiej Zolnierkiewicz
2015-08-17 15:46   ` Bartlomiej Zolnierkiewicz
2015-08-17 19:27   ` Émeric MASCHINO
2015-08-17 19:27     ` Émeric MASCHINO
2015-08-17 19:27     ` Émeric MASCHINO
2015-08-17 20:41     ` Luck, Tony
2015-08-17 20:41       ` Luck, Tony
2015-08-17 20:41       ` Luck, Tony
2015-08-18 22:45       ` Émeric MASCHINO
2015-08-18 22:45         ` Émeric MASCHINO
2015-08-18 22:45         ` Émeric MASCHINO

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55D2097A.7090203@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded.com \
    --cc=b.zolnierkie@samsung.com \
    --cc=fenghua.yu@intel.com \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.