[meta-fsl-arm] mesa-demos broken on nitrogen6x

[meta-fsl-arm] mesa-demos broken on nitrogen6x

[Ian Coolidge]

[-- Attachment #1: Type: text/plain, Size: 710 bytes --]

meta-fsl-arm/recipes-graphics/mesa/mesa-demos_%.bbappend has the following
lines of code:

# only apply patches on mx6 that have a GPU
SRC_URI_append_mx6q  = " ${MESA-DEMO-PATCH}"
SRC_URI_append_mx6dl = " ${MESA-DEMO-PATCH}"
SRC_URI_append_mx6sx = " ${MESA-DEMO-PATCH}"
SRC_URI_append_mx6sl = " ${MESA-DEMO-PATCH}"

And meta-fsl-arm-extra/conf/machine/nitrogen6x.conf declares its SOC_FAMILY
as:

SOC_FAMILY = "mx6:mx6dl:mx6q"

This causes the MESA-DEMO-PATCH to be applied twice as the nitrogen6x is
both mx6dl and mx6q since we have many CPU models of the nitrogen6x.

Is there any reason the recipe couldn't just have:

SRC_URI_append_mx6 = " ${MESA-DEMO-PATCH}"

Thanks for the help!

[-- Attachment #2: Type: text/html, Size: 1047 bytes --]

Re: [meta-fsl-arm] mesa-demos broken on nitrogen6x

[Doug Schwanke]

[-- Attachment #1: Type: text/plain, Size: 1050 bytes --]

Ian,

if I am not mistaken, the i.MX6UL does not have a GPU.

-Doug

From: meta-freescale-bounces@yoctoproject.org [mailto:meta-freescale-bounces@yoctoproject.org] On Behalf Of Ian Coolidge
Sent: Monday, August 17, 2015 2:29 PM
To: meta-freescale@yoctoproject.org
Subject: [meta-freescale] [meta-fsl-arm] mesa-demos broken on nitrogen6x

meta-fsl-arm/recipes-graphics/mesa/mesa-demos_%.bbappend has the following lines of code:

# only apply patches on mx6 that have a GPU
SRC_URI_append_mx6q  = " ${MESA-DEMO-PATCH}"
SRC_URI_append_mx6dl = " ${MESA-DEMO-PATCH}"
SRC_URI_append_mx6sx = " ${MESA-DEMO-PATCH}"
SRC_URI_append_mx6sl = " ${MESA-DEMO-PATCH}"

And meta-fsl-arm-extra/conf/machine/nitrogen6x.conf declares its SOC_FAMILY as:

SOC_FAMILY = "mx6:mx6dl:mx6q"

This causes the MESA-DEMO-PATCH to be applied twice as the nitrogen6x is both mx6dl and mx6q since we have many CPU models of the nitrogen6x.
Is there any reason the recipe couldn't just have:
SRC_URI_append_mx6 = " ${MESA-DEMO-PATCH}"
Thanks for the help!

[-- Attachment #2: Type: text/html, Size: 4316 bytes --]

Re: [meta-fsl-arm] mesa-demos broken on nitrogen6x

[Ann Thornton]

[-- Attachment #1: Type: text/plain, Size: 1100 bytes --]


The reason it doesn't just use _mx6 is that is doesn't apply to _mx6ul.

I don't think it is valid to have a machine that is both mx6dl and mx6q.

Ann Thornton

On 8/17/2015 2:29 PM, Ian Coolidge wrote:
> meta-fsl-arm/recipes-graphics/mesa/mesa-demos_%.bbappend has the 
> following lines of code:
>
> # only apply patches on mx6 that have a GPU
> SRC_URI_append_mx6q  = " ${MESA-DEMO-PATCH}"
> SRC_URI_append_mx6dl = " ${MESA-DEMO-PATCH}"
> SRC_URI_append_mx6sx = " ${MESA-DEMO-PATCH}"
> SRC_URI_append_mx6sl = " ${MESA-DEMO-PATCH}"
>
> And meta-fsl-arm-extra/conf/machine/nitrogen6x.conf declares its 
> SOC_FAMILY as:
>
> SOC_FAMILY = "mx6:mx6dl:mx6q"
>
> This causes the MESA-DEMO-PATCH to be applied twice as the nitrogen6x 
> is both mx6dl and mx6q since we have many CPU models of the nitrogen6x.
>
> Is there any reason the recipe couldn't just have:
>
> SRC_URI_append_mx6 = " ${MESA-DEMO-PATCH}"
>
> Thanks for the help!
>
>


-- 
Ann Thornton

/Microcontrollers Software and Applications
Freescale Semiconductors
email: Ann.Thornton@freescale.com/

[-- Attachment #2: Type: text/html, Size: 2693 bytes --]

Re: [meta-fsl-arm] mesa-demos broken on nitrogen6x

[Fabio Estevam]

Hi Ann,

On Mon, Aug 17, 2015 at 5:37 PM, Ann Thornton
<Ann.Thornton@freescale.com> wrote:
>
> The reason it doesn't just use _mx6 is that is doesn't apply to _mx6ul.
>
> I don't think it is valid to have a machine that is both mx6dl and mx6q.

We currently have machines that support multiple mx6 variants:

conf/machine/cgtqmx6.conf:SOC_FAMILY = "mx6:mx6dl:mx6q"
conf/machine/cm-fx6.conf:SOC_FAMILY = "mx6:mx6dl:mx6q"
conf/machine/cubox-i.conf:SOC_FAMILY = "mx6:mx6dl:mx6q"
conf/machine/nitrogen6x.conf:SOC_FAMILY = "mx6:mx6dl:mx6q"
conf/machine/ventana.conf:SOC_FAMILY = "mx6:mx6dl:mx6q"
conf/machine/wandboard.conf:SOC_FAMILY = "mx6:mx6dl:mx6q"

Re: [meta-fsl-arm] mesa-demos broken on nitrogen6x

[Otavio Salvador]

On Mon, Aug 17, 2015 at 6:43 PM, Fabio Estevam <festevam@gmail.com> wrote:
> On Mon, Aug 17, 2015 at 5:37 PM, Ann Thornton
> <Ann.Thornton@freescale.com> wrote:
>>
>> The reason it doesn't just use _mx6 is that is doesn't apply to _mx6ul.
>>
>> I don't think it is valid to have a machine that is both mx6dl and mx6q.
>
> We currently have machines that support multiple mx6 variants:
>
> conf/machine/cgtqmx6.conf:SOC_FAMILY = "mx6:mx6dl:mx6q"
> conf/machine/cm-fx6.conf:SOC_FAMILY = "mx6:mx6dl:mx6q"
> conf/machine/cubox-i.conf:SOC_FAMILY = "mx6:mx6dl:mx6q"
> conf/machine/nitrogen6x.conf:SOC_FAMILY = "mx6:mx6dl:mx6q"
> conf/machine/ventana.conf:SOC_FAMILY = "mx6:mx6dl:mx6q"
> conf/machine/wandboard.conf:SOC_FAMILY = "mx6:mx6dl:mx6q"

Ann, Fabio is right. This is a very valid use case.

Some boards has been using some strategies (SPI NOR for U-Boot or
U-Boot SPL) to support multiple SoCs in same images (Q or DL) with
great success.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

Re: [meta-fsl-arm] mesa-demos broken on nitrogen6x

[Ian Coolidge]

[-- Attachment #1: Type: text/plain, Size: 2022 bytes --]

>
> Some boards has been using some strategies (SPI NOR for U-Boot or
> U-Boot SPL) to support multiple SoCs in same images (Q or DL) with
> great success.


Is there a way to elegantly change the SRC_URI_append for the
mesa-demos_%.bbappend to handle the case where a board has multiple SoC's?
Changing it to:

# only apply patches on mx6 that have a GPU
SRC_URI_append_mx6  = " ${MESA-DEMO-PATCH}"
SRC_URI_remove_mx6ul = "${MESA-DEMO-PATCH}"

Would work, but it seems like there should be a better solution here.


On Mon, Aug 17, 2015 at 5:00 PM, Otavio Salvador <
otavio.salvador@ossystems.com.br> wrote:

> On Mon, Aug 17, 2015 at 6:43 PM, Fabio Estevam <festevam@gmail.com> wrote:
> > On Mon, Aug 17, 2015 at 5:37 PM, Ann Thornton
> > <Ann.Thornton@freescale.com> wrote:
> >>
> >> The reason it doesn't just use _mx6 is that is doesn't apply to _mx6ul.
> >>
> >> I don't think it is valid to have a machine that is both mx6dl and mx6q.
> >
> > We currently have machines that support multiple mx6 variants:
> >
> > conf/machine/cgtqmx6.conf:SOC_FAMILY = "mx6:mx6dl:mx6q"
> > conf/machine/cm-fx6.conf:SOC_FAMILY = "mx6:mx6dl:mx6q"
> > conf/machine/cubox-i.conf:SOC_FAMILY = "mx6:mx6dl:mx6q"
> > conf/machine/nitrogen6x.conf:SOC_FAMILY = "mx6:mx6dl:mx6q"
> > conf/machine/ventana.conf:SOC_FAMILY = "mx6:mx6dl:mx6q"
> > conf/machine/wandboard.conf:SOC_FAMILY = "mx6:mx6dl:mx6q"
>
> Ann, Fabio is right. This is a very valid use case.
>
> Some boards has been using some strategies (SPI NOR for U-Boot or
> U-Boot SPL) to support multiple SoCs in same images (Q or DL) with
> great success.
>
> --
> Otavio Salvador                             O.S. Systems
> http://www.ossystems.com.br        http://code.ossystems.com.br
> Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
> --
> _______________________________________________
> meta-freescale mailing list
> meta-freescale@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-freescale
>

[-- Attachment #2: Type: text/html, Size: 3428 bytes --]

Re: [meta-fsl-arm] mesa-demos broken on nitrogen6x

[Otavio Salvador]

On Mon, Aug 17, 2015 at 9:26 PM, Ian Coolidge <ian@boundarydevices.com> wrote:
>> Some boards has been using some strategies (SPI NOR for U-Boot or
>> U-Boot SPL) to support multiple SoCs in same images (Q or DL) with
>> great success.
>
>
> Is there a way to elegantly change the SRC_URI_append for the
> mesa-demos_%.bbappend to handle the case where a board has multiple SoC's?
> Changing it to:
>
> # only apply patches on mx6 that have a GPU
> SRC_URI_append_mx6  = " ${MESA-DEMO-PATCH}"
> SRC_URI_remove_mx6ul = "${MESA-DEMO-PATCH}"
>
> Would work, but it seems like there should be a better solution here.

Yes; this would work but it is ugly and makes hard for maintenance.

In meanwhile I reverted this in Fido branch and kept it broken in
master so we try to design a better technical solution for it.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750