All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Lieven <pl@kamp.de>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	Paolo Bonzini <pbonzini@redhat.com>,
	rkrcmar@redhat.com, Jan Kiszka <jan.kiszka@siemens.com>
Subject: Re: [Qemu-devel] Help debugging a regression in KVM Module
Date: Tue, 18 Aug 2015 16:54:28 +0200	[thread overview]
Message-ID: <55D34724.6000209@kamp.de> (raw)
In-Reply-To: <87zj1thc5z.fsf@linaro.org>

Am 14.08.2015 um 22:01 schrieb Alex Bennée:
> Peter Lieven <pl@kamp.de> writes:
>
>> Hi,
>>
>> some time a go I stumbled across a regression in the KVM Module that has been introduced somewhere
>> between 3.17 and 3.19.
>>
>> I have a rather old openSUSE guest with an XFS filesystem which realiably crashes after some live migrations.
>> I originally believed that the issue might be related to my setup with a 3.12 host kernel and kvm-kmod 3.19,
>> but I now found that it is also still present with a 3.19 host kernel with included 3.19 kvm module.
>>
>> My idea was to continue testing on a 3.12 host kernel and then bisect all commits to the kvm related parts.
>>
>> Now my question is how to best bisect only kvm related changes (those
>> that go into kvm-kmod)?
> In general I don't bother. As it is a bisection you eliminate half the
> commits at a time you get their fairly quickly anyway. However you can
> tell bisect which parts of the tree you car about:
>
>    git bisect start -- arch/arm64/kvm include/linux/kvm* include/uapi/linux/kvm* virt/kvm/

After some experiments I was able to find out the bad commit that introduced the regression:

commit f30ebc312ca9def25650b4e1d01cdb425c310dca
Author: Radim Krčmář <rkrcmar@redhat.com>
Date:   Thu Oct 30 15:06:47 2014 +0100

It seems that this optimisation is not working reliabliy after live migration. I can't reproduce if
I take a 3.19 kernel and revert this single commit.

Peter

WARNING: multiple messages have this Message-ID (diff)
From: Peter Lieven <pl@kamp.de>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	Jan Kiszka <jan.kiszka@siemens.com>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	rkrcmar@redhat.com
Subject: Re: [Qemu-devel] Help debugging a regression in KVM Module
Date: Tue, 18 Aug 2015 16:54:28 +0200	[thread overview]
Message-ID: <55D34724.6000209@kamp.de> (raw)
In-Reply-To: <87zj1thc5z.fsf@linaro.org>

Am 14.08.2015 um 22:01 schrieb Alex Bennée:
> Peter Lieven <pl@kamp.de> writes:
>
>> Hi,
>>
>> some time a go I stumbled across a regression in the KVM Module that has been introduced somewhere
>> between 3.17 and 3.19.
>>
>> I have a rather old openSUSE guest with an XFS filesystem which realiably crashes after some live migrations.
>> I originally believed that the issue might be related to my setup with a 3.12 host kernel and kvm-kmod 3.19,
>> but I now found that it is also still present with a 3.19 host kernel with included 3.19 kvm module.
>>
>> My idea was to continue testing on a 3.12 host kernel and then bisect all commits to the kvm related parts.
>>
>> Now my question is how to best bisect only kvm related changes (those
>> that go into kvm-kmod)?
> In general I don't bother. As it is a bisection you eliminate half the
> commits at a time you get their fairly quickly anyway. However you can
> tell bisect which parts of the tree you car about:
>
>    git bisect start -- arch/arm64/kvm include/linux/kvm* include/uapi/linux/kvm* virt/kvm/

After some experiments I was able to find out the bad commit that introduced the regression:

commit f30ebc312ca9def25650b4e1d01cdb425c310dca
Author: Radim Krčmář <rkrcmar@redhat.com>
Date:   Thu Oct 30 15:06:47 2014 +0100

It seems that this optimisation is not working reliabliy after live migration. I can't reproduce if
I take a 3.19 kernel and revert this single commit.

Peter

  parent reply	other threads:[~2015-08-18 14:54 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-14 11:11 Help debugging a regression in KVM Module Peter Lieven
2015-08-14 11:11 ` [Qemu-devel] " Peter Lieven
2015-08-14 13:01 ` Paolo Bonzini
2015-08-14 13:01   ` [Qemu-devel] " Paolo Bonzini
2015-08-14 19:36   ` Peter Lieven
2015-08-14 19:36     ` [Qemu-devel] " Peter Lieven
2015-08-14 20:01 ` Alex Bennée
2015-08-14 20:01   ` Alex Bennée
2015-08-17 12:33   ` Peter Lieven
2015-08-17 12:33     ` Peter Lieven
2015-08-18 14:54   ` Peter Lieven [this message]
2015-08-18 14:54     ` Peter Lieven
2015-08-18 15:25     ` Radim Krčmář
2015-08-18 15:25       ` Radim Krčmář
2015-08-18 15:37       ` Peter Lieven
2015-08-18 15:37         ` Peter Lieven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55D34724.6000209@kamp.de \
    --to=pl@kamp.de \
    --cc=alex.bennee@linaro.org \
    --cc=jan.kiszka@siemens.com \
    --cc=kvm@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rkrcmar@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.