Re: [PATCH v4 3/5] gadget: Support for the usb charger framework

[Sergei Shtylyov <sergei.shtylyov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>]

Hello.

On 8/19/2015 12:13 PM, Baolin Wang wrote:

> For supporting the usb charger, it adds the usb_charger_init() and
> usb_charger_exit() functions for usb charger initialization and exit.
>
> Introduce a callback 'get_charger_type' which will implemented by
> user for usb gadget operations to get the usb charger type.
>
> Signed-off-by: Baolin Wang <baolin.wang-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
[...]

> diff --git a/include/linux/usb/gadget.h b/include/linux/usb/gadget.h
> index 755e8bc..44d82f5 100644
> --- a/include/linux/usb/gadget.h
> +++ b/include/linux/usb/gadget.h
> @@ -537,6 +537,7 @@ struct usb_gadget_ops {
>   	struct usb_ep *(*match_ep)(struct usb_gadget *,
>   			struct usb_endpoint_descriptor *,
>   			struct usb_ss_ep_comp_descriptor *);
> +	enum usb_charger_type	(*get_charger_type)(struct usb_gadget *);
                              ^^^ please use space, not tab here

>   };
>
>   /**
> @@ -611,6 +612,7 @@ struct usb_gadget {
>   	struct usb_otg_caps		*otg_caps;
>   	struct raw_notifier_head	nh;
>   	struct mutex			lock;
> +	struct usb_charger		*uchger;

    Why not simply call the field 'charger'? :-)

[...]

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html