Re: [kernel.org bug 103071] Dead "security.*" xattr code in ubifs

[Dongsheng Yang <yangds.fnst@cn.fujitsu.com>]

On 08/19/2015 04:55 AM, Richard Weinberger wrote:
> Andreas,
>
> On Tue, Aug 18, 2015 at 2:15 PM, Andreas Grünbacher
> <andreas.gruenbacher@gmail.com> wrote:
>> Hello,
>>
>> FYI, I've filed the following bug report against ubifs:
>>
>>> ubifs sets sb->s_xattr to ubifs_xattr_handlers which contains a handler for
>>> "security.*" xattrs. The s_xattr handlers are never used because ubifs uses
>>> its own ubifs_{get,set,list,remove}xattr inode operations instead of
>>> generic_{get,set,list,remove}xattr inode operations though.
>>
>> https://bugzilla.kernel.org/show_bug.cgi?id=103071
>
> Thanks for reporting.
>
> CC'ing authors of commit d7f0b70d30ffb9bbe6b8a3e1035cf0b79965ef53
> Author: Subodh Nijsure <snijsure@grid-net.com>
> Date:   Fri Oct 31 13:50:30 2014 -0500
>
>      UBIFS: Add security.* XATTR support for the UBIFS
>
>
> Also xfstests' generic/062 test seems to fail (with USE_ATTR_SECURE=yes)
> ---cut---
> generic/062 1s ... - output mismatch (see
> /root/xfstests/results//generic/062.out.bad)
>      --- tests/generic/062.out   2015-08-18 20:13:00.714593141 +0000
>      +++ /root/xfstests/results//generic/062.out.bad     2015-08-18
> 20:50:06.450418217 +0000
>      @@ -203,6 +203,292 @@
>       SCRATCH_MNT/dev/p: user.name2: No such attribute or operation not permitted
>       *** final list (strings, type=dev/p, nsp=user)
>
>      +=== TYPE reg; NAMESPACE security
>      +
>      +*** set/get one initially empty attribute
>      +# file: SCRATCH_MNT/reg
>      ...
>      (Run 'diff -u tests/generic/062.out
> /root/xfstests/results//generic/062.out.bad'  to see the entire diff)
> Ran: generic/062
> Failures: generic/062
> Failed 1 of 1 tests

Hi Richard,
	Glad to know you are also using fstests for our ubifs. :)
About this case, I checked it and found it's a bug in fstests.
Because when we are setting USE_ATTR_SECURE=yes, the output
would be different with what it expected currently.
	So, I will send a patch out to fix it. And with a quick
fix, I found ubifs works well in xattr security.

Yang
> ---cut---
>
> Guys, how did you test this feature?
>