From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: yalin wang <yalin.wang2010@gmail.com>,
adaplas@gmail.com, plagnioj@jcrosoft.com,
linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC] fbdev/nvidia:change reverse_order() macro
Date: Thu, 20 Aug 2015 11:04:09 +0000 [thread overview]
Message-ID: <55D5B429.8040605@ti.com> (raw)
In-Reply-To: <1440053547-24193-1-git-send-email-yalin.wang2010@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 540 bytes --]
On 20/08/15 09:52, yalin wang wrote:
> This change reverse_order() to swab32(bitrev32()), so that
> it can have better performance on some platforms.
>
> Signed-off-by: yalin wang <yalin.wang2010@gmail.com>
> ---
> drivers/video/fbdev/nvidia/nv_accel.c | 4 ++--
> drivers/video/fbdev/nvidia/nv_local.h | 13 ++++---------
> 2 files changed, 6 insertions(+), 11 deletions(-)
I have more or less the same comments here as for the riva patch, except
in this one I'd change the macro to an static inline function.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: yalin wang <yalin.wang2010@gmail.com>, <adaplas@gmail.com>,
<plagnioj@jcrosoft.com>, <linux-fbdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [RFC] fbdev/nvidia:change reverse_order() macro
Date: Thu, 20 Aug 2015 14:04:09 +0300 [thread overview]
Message-ID: <55D5B429.8040605@ti.com> (raw)
In-Reply-To: <1440053547-24193-1-git-send-email-yalin.wang2010@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 540 bytes --]
On 20/08/15 09:52, yalin wang wrote:
> This change reverse_order() to swab32(bitrev32()), so that
> it can have better performance on some platforms.
>
> Signed-off-by: yalin wang <yalin.wang2010@gmail.com>
> ---
> drivers/video/fbdev/nvidia/nv_accel.c | 4 ++--
> drivers/video/fbdev/nvidia/nv_local.h | 13 ++++---------
> 2 files changed, 6 insertions(+), 11 deletions(-)
I have more or less the same comments here as for the riva patch, except
in this one I'd change the macro to an static inline function.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-08-20 11:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-20 6:52 [RFC] fbdev/nvidia:change reverse_order() macro yalin wang
2015-08-20 6:52 ` yalin wang
2015-08-20 11:04 ` Tomi Valkeinen [this message]
2015-08-20 11:04 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55D5B429.8040605@ti.com \
--to=tomi.valkeinen@ti.com \
--cc=adaplas@gmail.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=plagnioj@jcrosoft.com \
--cc=yalin.wang2010@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.