[PATCH 1/2] ipr: Inhibit underlength data check for AFDASD in raw mode.

[PATCH 1/2] ipr: Inhibit underlength data check for AFDASD in raw mode.

[Gabriel Krisman Bertazi]

Disable underlength error verification based on count of bytes actually
transferred for AF DASD devices when SIS pipe mode is enabled.

This avoids unexpected underlength errors when issuing some commands in
raw mode.

Signed-off-by: Gabriel Krisman Bertazi <krisman@linux.vnet.ibm.com>
---
 drivers/scsi/ipr.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/scsi/ipr.c b/drivers/scsi/ipr.c
index a9aa389..db0c2cf 100644
--- a/drivers/scsi/ipr.c
+++ b/drivers/scsi/ipr.c
@@ -6382,9 +6382,13 @@ static int ipr_queuecommand(struct Scsi_Host *shost,
 	    (!ipr_is_gscsi(res) || scsi_cmd->cmnd[0] == IPR_QUERY_RSRC_STATE)) {
 		ioarcb->cmd_pkt.request_type = IPR_RQTYPE_IOACMD;
 	}
-	if (res->raw_mode && ipr_is_af_dasd_device(res))
+	if (res->raw_mode && ipr_is_af_dasd_device(res)) {
 		ioarcb->cmd_pkt.request_type = IPR_RQTYPE_PIPE;
 
+		if (scsi_cmd->underflow == 0)
+			ioarcb->cmd_pkt.flags_hi |= IPR_FLAGS_HI_NO_ULEN_CHK;
+	}
+
 	if (ioa_cfg->sis64)
 		rc = ipr_build_ioadl64(ioa_cfg, ipr_cmd);
 	else
-- 
2.1.0

[PATCH 2/2] ipr: Enable SIS pipe commands for SIS-32 devices.

[Gabriel Krisman Bertazi]

Remove unnecessary check that disabled SIS pipe commands for SIS-32
devices.  This change was sufficient to enable raw mode and send SIS
pipe commands for a 57B3 device.

Fixes: f8ee25d7d239 ("ipr: AF DASD raw mode implementation in ipr driver")
Signed-off-by: Gabriel Krisman Bertazi <krisman@linux.vnet.ibm.com>
---
 drivers/scsi/ipr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/ipr.c b/drivers/scsi/ipr.c
index db0c2cf..b19719f 100644
--- a/drivers/scsi/ipr.c
+++ b/drivers/scsi/ipr.c
@@ -4554,7 +4554,7 @@ static ssize_t ipr_store_raw_mode(struct device *dev,
 	spin_lock_irqsave(ioa_cfg->host->host_lock, lock_flags);
 	res = (struct ipr_resource_entry *)sdev->hostdata;
 	if (res) {
-		if (ioa_cfg->sis64 && ipr_is_af_dasd_device(res)) {
+		if (ipr_is_af_dasd_device(res)) {
 			res->raw_mode = simple_strtoul(buf, NULL, 10);
 			len = strlen(buf);
 			if (res->sdev)
-- 
2.1.0

Re: [PATCH 2/2] ipr: Enable SIS pipe commands for SIS-32 devices.

[Brian King]

On 08/19/2015 09:47 AM, Gabriel Krisman Bertazi wrote:
> Remove unnecessary check that disabled SIS pipe commands for SIS-32
> devices.  This change was sufficient to enable raw mode and send SIS
> pipe commands for a 57B3 device.
> 
> Fixes: f8ee25d7d239 ("ipr: AF DASD raw mode implementation in ipr driver")
> Signed-off-by: Gabriel Krisman Bertazi <krisman@linux.vnet.ibm.com>
> ---

Thanks!

Acked-by: Brian King <brking@linux.vnet.ibm.com>

-- 
Brian King
Power Linux I/O
IBM Linux Technology Center

Re: [PATCH 2/2] ipr: Enable SIS pipe commands for SIS-32 devices.

[Wendy Xiong]

Gabriel Krisman Bertazi <krisman <at> linux.vnet.ibm.com> writes:

> 
> Remove unnecessary check that disabled SIS pipe commands for SIS-32
> devices.  This change was sufficient to enable raw mode and send SIS
> pipe commands for a 57B3 device.
> 

Reviewed-by: Wen Xiong <wenxiong@linux.vnet.ibm.com>

Thanks,

Wendy

Re: [PATCH 1/2] ipr: Inhibit underlength data check for AFDASD in raw mode.

[Brian King]

On 08/19/2015 09:47 AM, Gabriel Krisman Bertazi wrote:
> Disable underlength error verification based on count of bytes actually
> transferred for AF DASD devices when SIS pipe mode is enabled.
> 
> This avoids unexpected underlength errors when issuing some commands in
> raw mode.
> 
> Signed-off-by: Gabriel Krisman Bertazi <krisman@linux.vnet.ibm.com>
> ---

Looks good. Thanks!

Acked-by: Brian King <brking@linux.vnet.ibm.com>

-- 
Brian King
Power Linux I/O
IBM Linux Technology Center

Re: [PATCH 1/2] ipr: Inhibit underlength data check for AFDASD in raw mode.

[Wendy Xiong]

Gabriel Krisman Bertazi <krisman <at> linux.vnet.ibm.com> writes:

> 
> Disable underlength error verification based on count of bytes actually
> transferred for AF DASD devices when SIS pipe mode is enabled.
> 
> This avoids unexpected underlength errors when issuing some commands in
> raw mode.
> 
> Signed-off-by: Gabriel Krisman Bertazi <krisman <at> linux.vnet.ibm.com>

Reviewed-by: Wen Xiong<wenxiong@linux.vnet.ibm.com>