vmwgfx GL3 and other -next (4.3) pathches

vmwgfx GL3 and other -next (4.3) pathches

[Thomas Hellstrom]

Hi, all,

I've pushed the current upcoming vmwgfx patches for 4.3 into

git://people.freedesktop.org/~thomash/linux
branch vmwgfx-next for review.

There are quite a few patches so I figured that this would be easier
than posting all patches on the mailing list.
The patches are all internally reviewed, either by me, Sinclair Yeh,
Brian Paul or Charmaine Lee.

The patchset basically enables the following
- Screen targets - Use of a new device API for scanout buffers
- Command buffers - A device command buffer queue replacing the old ring
fifo.
- GL3 - support for a new device functionality called "DX" that enables
us to support GL3. Mesa gallium driver support for GL3 is about to be
published. The patches for DX support have been heavily squashed.

Please let me know if anybody has any objections against this.

Thanks,
Thomas



_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: vmwgfx GL3 and other -next (4.3) pathches

[Daniel Vetter]

On Wed, Aug 12, 2015 at 08:31:09PM +0200, Thomas Hellstrom wrote:
> Hi, all,
> 
> I've pushed the current upcoming vmwgfx patches for 4.3 into
> 
> git://people.freedesktop.org/~thomash/linux
> branch vmwgfx-next for review.
> 
> There are quite a few patches so I figured that this would be easier
> than posting all patches on the mailing list.
> The patches are all internally reviewed, either by me, Sinclair Yeh,
> Brian Paul or Charmaine Lee.
> 
> The patchset basically enables the following
> - Screen targets - Use of a new device API for scanout buffers
> - Command buffers - A device command buffer queue replacing the old ring
> fifo.
> - GL3 - support for a new device functionality called "DX" that enables
> us to support GL3. Mesa gallium driver support for GL3 is about to be
> published. The patches for DX support have been heavily squashed.
> 
> Please let me know if anybody has any objections against this.

Just submit it to dri-devel, it's really not that much compared to other
big patch series here ;-)
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: vmwgfx GL3 and other -next (4.3) pathches

[Daniel Vetter]

On Wed, Aug 12, 2015 at 08:31:09PM +0200, Thomas Hellstrom wrote:
> Hi, all,
> 
> I've pushed the current upcoming vmwgfx patches for 4.3 into
> 
> git://people.freedesktop.org/~thomash/linux
> branch vmwgfx-next for review.
> 
> There are quite a few patches so I figured that this would be easier
> than posting all patches on the mailing list.
> The patches are all internally reviewed, either by me, Sinclair Yeh,
> Brian Paul or Charmaine Lee.
> 
> The patchset basically enables the following
> - Screen targets - Use of a new device API for scanout buffers
> - Command buffers - A device command buffer queue replacing the old ring
> fifo.
> - GL3 - support for a new device functionality called "DX" that enables
> us to support GL3. Mesa gallium driver support for GL3 is about to be
> published. The patches for DX support have been heavily squashed.
> 
> Please let me know if anybody has any objections against this.

Out of curiosity I did take a (very) quick look and also tried to find the
corresponding userspace parts. On a quick search I didn't find anything
for libdrm or mesa, neither on mailing lists or already committed. Where
are those pieces?
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: vmwgfx GL3 and other -next (4.3) pathches

[Thomas Hellstrom]

Hi,

On 08/12/2015 11:07 PM, Daniel Vetter wrote:
> On Wed, Aug 12, 2015 at 08:31:09PM +0200, Thomas Hellstrom wrote:
>> Hi, all,
>>
>> I've pushed the current upcoming vmwgfx patches for 4.3 into
>>
>> git://people.freedesktop.org/~thomash/linux
>> branch vmwgfx-next for review.
>>
>> There are quite a few patches so I figured that this would be easier
>> than posting all patches on the mailing list.
>> The patches are all internally reviewed, either by me, Sinclair Yeh,
>> Brian Paul or Charmaine Lee.
>>
>> The patchset basically enables the following
>> - Screen targets - Use of a new device API for scanout buffers
>> - Command buffers - A device command buffer queue replacing the old ring
>> fifo.
>> - GL3 - support for a new device functionality called "DX" that enables
>> us to support GL3. Mesa gallium driver support for GL3 is about to be
>> published. The patches for DX support have been heavily squashed.
>>
>> Please let me know if anybody has any objections against this.
> Out of curiosity I did take a (very) quick look and also tried to find the
> corresponding userspace parts. On a quick search I didn't find anything
> for libdrm or mesa, neither on mailing lists or already committed. Where
> are those pieces?
> -Daniel

The mesa code is ready and working but undergoing final tidying before
upstreaming. The aim is of course to release it well before linux 4.3 is
out. However our kernel interface has just undergone very minor changes.

Typically we don't use libdrm for any vmwgfx-specific code. At least not
yet. The corresponding code sits in the gallium winsys.

Thanks,
Thomas

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: vmwgfx GL3 and other -next (4.3) pathches

[Thomas Hellstrom]

On 08/12/2015 11:02 PM, Daniel Vetter wrote:
> On Wed, Aug 12, 2015 at 08:31:09PM +0200, Thomas Hellstrom wrote:
>> Hi, all,
>>
>> I've pushed the current upcoming vmwgfx patches for 4.3 into
>>
>> git://people.freedesktop.org/~thomash/linux
>> branch vmwgfx-next for review.
>>
>> There are quite a few patches so I figured that this would be easier
>> than posting all patches on the mailing list.
>> The patches are all internally reviewed, either by me, Sinclair Yeh,
>> Brian Paul or Charmaine Lee.
>>
>> The patchset basically enables the following
>> - Screen targets - Use of a new device API for scanout buffers
>> - Command buffers - A device command buffer queue replacing the old ring
>> fifo.
>> - GL3 - support for a new device functionality called "DX" that enables
>> us to support GL3. Mesa gallium driver support for GL3 is about to be
>> published. The patches for DX support have been heavily squashed.
>>
>> Please let me know if anybody has any objections against this.
> Just submit it to dri-devel, it's really not that much compared to other
> big patch series here ;-)
> -Daniel
OK, I'll do that. I spoke briefly to Dave some time ago and he suggested
using a tree in this way, unless someone on dri-devel objected.

Thanks,
Thomas.

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: vmwgfx GL3 and other -next (4.3) pathches

[Daniel Vetter]

On Thu, Aug 13, 2015 at 7:04 AM, Thomas Hellstrom <thellstrom@vmware.com> wrote:
>> Out of curiosity I did take a (very) quick look and also tried to find the
>> corresponding userspace parts. On a quick search I didn't find anything
>> for libdrm or mesa, neither on mailing lists or already committed. Where
>> are those pieces?
>> -Daniel
>
> The mesa code is ready and working but undergoing final tidying before
> upstreaming. The aim is of course to release it well before linux 4.3 is
> out. However our kernel interface has just undergone very minor change

In my opinion userspace must be ready for merging (and public) before
the kernel code can go in. That's at least what I enforce for i915 and
how all other drivers are handled.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: vmwgfx GL3 and other -next (4.3) pathches

[Thomas Hellstrom]

On 08/13/2015 08:38 AM, Daniel Vetter wrote:
> On Thu, Aug 13, 2015 at 7:04 AM, Thomas Hellstrom <thellstrom@vmware.com> wrote:
>>> Out of curiosity I did take a (very) quick look and also tried to find the
>>> corresponding userspace parts. On a quick search I didn't find anything
>>> for libdrm or mesa, neither on mailing lists or already committed. Where
>>> are those pieces?
>>> -Daniel
>> The mesa code is ready and working but undergoing final tidying before
>> upstreaming. The aim is of course to release it well before linux 4.3 is
>> out. However our kernel interface has just undergone very minor change
> In my opinion userspace must be ready for merging (and public) before
> the kernel code can go in. That's at least what I enforce for i915 and
> how all other drivers are handled.
> -Daniel

OK. I was under the impression that this was only enforced on big
user-space interface changes, new drivers or if there was a suspicion
that the user-space part would never be open-sourced. Let's see what we
can do to speed this up.

Thanks,
Thomas

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: vmwgfx GL3 and other -next (4.3) pathches

[Emil Velikov]

Hi Thomas,

On 12 August 2015 at 19:31, Thomas Hellstrom <thellstrom@vmware.com> wrote:
...
> - GL3 - support for a new device functionality called "DX"
Out of curiosity - what what does DX stand for ?

Thanks
Emil
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: vmwgfx GL3 and other -next (4.3) pathches

[Thomas Hellstrom]

On 08/13/2015 01:47 PM, Emil Velikov wrote:
> Hi Thomas,
>
> On 12 August 2015 at 19:31, Thomas Hellstrom <thellstrom@vmware.com> wrote:
> ...
>> - GL3 - support for a new device functionality called "DX"
> Out of curiosity - what what does DX stand for ?

Hmm. I'm not 100% sure. Given the history of the device interface I
guess it started out as "DX10" but to avoid legal issues it was renamed
to DX.

/Thomas

>
> Thanks
> Emil
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel


_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: vmwgfx GL3 and other -next (4.3) pathches

[Thomas Hellstrom]

On 08/13/2015 08:38 AM, Daniel Vetter wrote:
> On Thu, Aug 13, 2015 at 7:04 AM, Thomas Hellstrom <thellstrom@vmware.com> wrote:
>>> Out of curiosity I did take a (very) quick look and also tried to find the
>>> corresponding userspace parts. On a quick search I didn't find anything
>>> for libdrm or mesa, neither on mailing lists or already committed. Where
>>> are those pieces?
>>> -Daniel
>> The mesa code is ready and working but undergoing final tidying before
>> upstreaming. The aim is of course to release it well before linux 4.3 is
>> out. However our kernel interface has just undergone very minor change
> In my opinion userspace must be ready for merging (and public) before
> the kernel code can go in. That's at least what I enforce for i915 and
> how all other drivers are handled.
> -Daniel

OK, so the mesa code has now been published here:

http://cgit.freedesktop.org/~thomash/mesa/log/?h=svga-gl3-merge

While it's in principle ready for merging, it lacks some final reviewing
and testing but otherwise should work fine.

/Thomas

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: vmwgfx GL3 and other -next (4.3) pathches

[Emil Velikov]

Hi Thomas,

On 14 August 2015 at 12:29, Thomas Hellstrom <thellstrom@vmware.com> wrote:
> On 08/13/2015 08:38 AM, Daniel Vetter wrote:
>> On Thu, Aug 13, 2015 at 7:04 AM, Thomas Hellstrom <thellstrom@vmware.com> wrote:
>>>> Out of curiosity I did take a (very) quick look and also tried to find the
>>>> corresponding userspace parts. On a quick search I didn't find anything
>>>> for libdrm or mesa, neither on mailing lists or already committed. Where
>>>> are those pieces?
>>>> -Daniel
>>> The mesa code is ready and working but undergoing final tidying before
>>> upstreaming. The aim is of course to release it well before linux 4.3 is
>>> out. However our kernel interface has just undergone very minor change
>> In my opinion userspace must be ready for merging (and public) before
>> the kernel code can go in. That's at least what I enforce for i915 and
>> how all other drivers are handled.
>> -Daniel
>
> OK, so the mesa code has now been published here:
>
> http://cgit.freedesktop.org/~thomash/mesa/log/?h=svga-gl3-merge
>
> While it's in principle ready for merging, it lacks some final reviewing
> and testing but otherwise should work fine.
>
I cannot see the series ever making it to the (mesa-dev) mailing list.
Did it got stuck due to its size or you forgot to send it over ?
Mildly related - the mesa 11.0 branchpoint is just a few hours away,
so it seems that this work will miss it :(

Thanks
Emil
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: vmwgfx GL3 and other -next (4.3) pathches

[Thomas Hellstrom]

Hi, Emil

On 08/21/2015 02:31 PM, Emil Velikov wrote:
> Hi Thomas,
>
> On 14 August 2015 at 12:29, Thomas Hellstrom <thellstrom@vmware.com> wrote:
>> On 08/13/2015 08:38 AM, Daniel Vetter wrote:
>>> On Thu, Aug 13, 2015 at 7:04 AM, Thomas Hellstrom <thellstrom@vmware.com> wrote:
>>>>> Out of curiosity I did take a (very) quick look and also tried to find the
>>>>> corresponding userspace parts. On a quick search I didn't find anything
>>>>> for libdrm or mesa, neither on mailing lists or already committed. Where
>>>>> are those pieces?
>>>>> -Daniel
>>>> The mesa code is ready and working but undergoing final tidying before
>>>> upstreaming. The aim is of course to release it well before linux 4.3 is
>>>> out. However our kernel interface has just undergone very minor change
>>> In my opinion userspace must be ready for merging (and public) before
>>> the kernel code can go in. That's at least what I enforce for i915 and
>>> how all other drivers are handled.
>>> -Daniel
>> OK, so the mesa code has now been published here:
>>
>> http://cgit.freedesktop.org/~thomash/mesa/log/?h=svga-gl3-merge
>>
>> While it's in principle ready for merging, it lacks some final reviewing
>> and testing but otherwise should work fine.
>>
> I cannot see the series ever making it to the (mesa-dev) mailing list.
> Did it got stuck due to its size or you forgot to send it over ?
> Mildly related - the mesa 11.0 branchpoint is just a few hours away,
> so it seems that this work will miss it :(

The reason is basically because I want to get a final internal review
and go-ahead. Unfortunately I wasn't aware that the mesa 11.0
branchpoint was immediately upcoming. I guess there's not much we can do
about it at this point? Even if I post the patches now we can't just
expect them to be reviewed within a couple of hours...

Thomas

>
> Thanks
> Emil
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel


_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: vmwgfx GL3 and other -next (4.3) pathches

[Emil Velikov]

On 21/08/15 13:42, Thomas Hellstrom wrote:
> Hi, Emil
> 
> On 08/21/2015 02:31 PM, Emil Velikov wrote:
>> Hi Thomas,
>>
>> On 14 August 2015 at 12:29, Thomas Hellstrom <thellstrom@vmware.com> wrote:
>>> On 08/13/2015 08:38 AM, Daniel Vetter wrote:
>>>> On Thu, Aug 13, 2015 at 7:04 AM, Thomas Hellstrom <thellstrom@vmware.com> wrote:
>>>>>> Out of curiosity I did take a (very) quick look and also tried to find the
>>>>>> corresponding userspace parts. On a quick search I didn't find anything
>>>>>> for libdrm or mesa, neither on mailing lists or already committed. Where
>>>>>> are those pieces?
>>>>>> -Daniel
>>>>> The mesa code is ready and working but undergoing final tidying before
>>>>> upstreaming. The aim is of course to release it well before linux 4.3 is
>>>>> out. However our kernel interface has just undergone very minor change
>>>> In my opinion userspace must be ready for merging (and public) before
>>>> the kernel code can go in. That's at least what I enforce for i915 and
>>>> how all other drivers are handled.
>>>> -Daniel
>>> OK, so the mesa code has now been published here:
>>>
>>> http://cgit.freedesktop.org/~thomash/mesa/log/?h=svga-gl3-merge
>>>
>>> While it's in principle ready for merging, it lacks some final reviewing
>>> and testing but otherwise should work fine.
>>>
>> I cannot see the series ever making it to the (mesa-dev) mailing list.
>> Did it got stuck due to its size or you forgot to send it over ?
>> Mildly related - the mesa 11.0 branchpoint is just a few hours away,
>> so it seems that this work will miss it :(
> 
> The reason is basically because I want to get a final internal review
> and go-ahead.
Ack. What are the chances of gradually adding (stubbing) and using the
functionality rather than the current "add file X, but don't build
and/or use it" approach ?

> Unfortunately I wasn't aware that the mesa 11.0
> branchpoint was immediately upcoming.
It was mentioned on the mailing list (search for "release schedule")
with a few reminders, plus a note in the #dri-devel IRC channel topic.

If you can think of a way to make the process/timeline more obvious/well
known, please let me know.

> I guess there's not much we can do
> about it at this point? Even if I post the patches now we can't just
> expect them to be reviewed within a couple of hours...
> 
Unfortunately it seems like it. Guess I should have checked earlier.

Cheers
Emil

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: vmwgfx GL3 and other -next (4.3) pathches

[Thomas Hellstrom]

Hi

On 08/21/2015 04:39 PM, Emil Velikov wrote:
> On 21/08/15 13:42, Thomas Hellstrom wrote:
>> Unfortunately I wasn't aware that the mesa 11.0
>> branchpoint was immediately upcoming.
> It was mentioned on the mailing list (search for "release schedule")
> with a few reminders, plus a note in the #dri-devel IRC channel topic.
>
> If you can think of a way to make the process/timeline more obvious/well
> known, please let me know.
>

No. Entirely my fault. Been to busy with the kernel patches and other stuff.

Thanks,
Thomas
 
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: vmwgfx GL3 and other -next (4.3) pathches

[Ilia Mirkin]

On Fri, Aug 21, 2015 at 10:39 AM, Emil Velikov <emil.l.velikov@gmail.com> wrote:
> On 21/08/15 13:42, Thomas Hellstrom wrote:
>> I guess there's not much we can do
>> about it at this point? Even if I post the patches now we can't just
>> expect them to be reviewed within a couple of hours...
>>
> Unfortunately it seems like it. Guess I should have checked earlier.

The release process is there to help, not hurt. IMO it is perfectly
acceptable for a driver maintainer to insert random features into
their drivers at random times (subject to the usual release timing
constraints). If you (as the vmwgfx driver maintainer) are comfortable
with dumping the code into the release without the end-user testing
that the -rc's would get (very little for vmwgfx I'd imagine) and
suffering the consequences of a Mesa 11.0.0 release with a broken
vmwgfx (due to some hypothetical error on your end), then it's fine
for you to request a list of patches get cherry-picked (or provide a
branch to be merged in) at the 11th hour.

That said, releases come about every 3 months now, and the expectation
is that new features don't get into the minor point releases. However
I think the pre-major-release time is a bit different than the usual
stable maintenance, even though the actual release process is quite
similar.

Cheers,

  -ilia
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel