Re: [Qemu-devel] [PATCH RFC 5/5] qapi: Allow anonymous base for flat union

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1472 bytes --]

On 08/19/2015 05:04 PM, Eric Blake wrote:
> Rather than requiring all flat unions to explicitly create
> a separate base struct, we want to allow the qapi schema
> to specify the common fields via an inline dictionary. This
> is similar to how commands can specify inline types for the
> arguments.
> 
> Now that the feature is legal, we can drop the former
> flat-union-bad-base negative test, and instead change the
> positive tests in qapi-schema-test to use it.
> 
> Signed-off-by: Eric Blake <eblake@redhat.com>
> ---
>  scripts/qapi-commands.py                   |  2 +-
>  scripts/qapi-types.py                      |  2 +-
>  scripts/qapi-visit.py                      | 13 +++++++---
>  scripts/qapi.py                            | 39 ++++++++++++++++++------------
>  tests/Makefile                             |  3 +--
>  tests/qapi-schema/flat-union-bad-base.err  |  1 -
>  tests/qapi-schema/flat-union-bad-base.exit |  1 -
>  tests/qapi-schema/flat-union-bad-base.json | 13 ----------
>  tests/qapi-schema/flat-union-bad-base.out  |  0
>  tests/qapi-schema/qapi-schema-test.json    |  2 +-
>  tests/qapi-schema/qapi-schema-test.out     |  5 +++-
>  11 files changed, 41 insertions(+), 40 deletions(-)

Of course, I forgot to include changes to docs/qapi-code-gen.txt. They
will be present in the next (non-RFC) version.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]