All of lore.kernel.org
 help / color / mirror / Atom feed
From: Xishi Qiu <qiuxishi@huawei.com>
To: Rik van Riel <riel@redhat.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Linux MM <linux-mm@kvack.org>, Xiexiuqi <xiexiuqi@huawei.com>
Subject: Re: is this a problem of numactl in RedHat7.0 ?
Date: Mon, 24 Aug 2015 12:15:07 +0800	[thread overview]
Message-ID: <55DA9A4B.10203@huawei.com> (raw)
In-Reply-To: <55D78FB0.9040906@redhat.com>

On 2015/8/22 4:53, Rik van Riel wrote:

> On 08/21/2015 05:27 AM, Xishi Qiu wrote:
>> I use numactl(--localalloc) tool run a test case, but it shows that
>> the numa policy is prefer, I don't know why.
> 
> The kernel implements MPOL_PREFERRED and MPOL_LOCAL
> in the same way. Look at this code in mpol_new(),
> in mm/mempolicy.c:
> 

user:
"numactl --localalloc" wil call
	main()
	  numa_set_localalloc()
	    setpol(MPOL_DEFAULT, numa_no_nodes_ptr);
	      set_mempolicy()
	        syscall(__NR_set_mempolicy,mode,nmask,maxnode);

kernel:
	do_set_mempolicy()
	  mpol_new()
		if (mode == MPOL_DEFAULT) {
			if (nodes && !nodes_empty(*nodes))
				return ERR_PTR(-EINVAL);
			return NULL;  // return from here
		}

>         /*
>          * MPOL_PREFERRED cannot be used with MPOL_F_STATIC_NODES or
>          * MPOL_F_RELATIVE_NODES if the nodemask is empty (local allocation).
>          * All other modes require a valid pointer to a non-empty nodemask.
>          */
>         if (mode == MPOL_PREFERRED) {
>                 if (nodes_empty(*nodes)) {
>                         if (((flags & MPOL_F_STATIC_NODES) ||
>                              (flags & MPOL_F_RELATIVE_NODES)))
>                                 return ERR_PTR(-EINVAL);
>                 }
>         } else if (mode == MPOL_LOCAL) {
>                 if (!nodes_empty(*nodes))
>                         return ERR_PTR(-EINVAL);
>                 mode = MPOL_PREFERRED;
>         } else if (nodes_empty(*nodes))
>                 return ERR_PTR(-EINVAL);
> 
> 
> 
> 



--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Xishi Qiu <qiuxishi@huawei.com>
To: Rik van Riel <riel@redhat.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Linux MM <linux-mm@kvack.org>, Xiexiuqi <xiexiuqi@huawei.com>
Subject: Re: is this a problem of numactl in RedHat7.0 ?
Date: Mon, 24 Aug 2015 12:15:07 +0800	[thread overview]
Message-ID: <55DA9A4B.10203@huawei.com> (raw)
In-Reply-To: <55D78FB0.9040906@redhat.com>

On 2015/8/22 4:53, Rik van Riel wrote:

> On 08/21/2015 05:27 AM, Xishi Qiu wrote:
>> I use numactl(--localalloc) tool run a test case, but it shows that
>> the numa policy is prefer, I don't know why.
> 
> The kernel implements MPOL_PREFERRED and MPOL_LOCAL
> in the same way. Look at this code in mpol_new(),
> in mm/mempolicy.c:
> 

user:
"numactl --localalloc" wil call
	main()
	  numa_set_localalloc()
	    setpol(MPOL_DEFAULT, numa_no_nodes_ptr);
	      set_mempolicy()
	        syscall(__NR_set_mempolicy,mode,nmask,maxnode);

kernel:
	do_set_mempolicy()
	  mpol_new()
		if (mode == MPOL_DEFAULT) {
			if (nodes && !nodes_empty(*nodes))
				return ERR_PTR(-EINVAL);
			return NULL;  // return from here
		}

>         /*
>          * MPOL_PREFERRED cannot be used with MPOL_F_STATIC_NODES or
>          * MPOL_F_RELATIVE_NODES if the nodemask is empty (local allocation).
>          * All other modes require a valid pointer to a non-empty nodemask.
>          */
>         if (mode == MPOL_PREFERRED) {
>                 if (nodes_empty(*nodes)) {
>                         if (((flags & MPOL_F_STATIC_NODES) ||
>                              (flags & MPOL_F_RELATIVE_NODES)))
>                                 return ERR_PTR(-EINVAL);
>                 }
>         } else if (mode == MPOL_LOCAL) {
>                 if (!nodes_empty(*nodes))
>                         return ERR_PTR(-EINVAL);
>                 mode = MPOL_PREFERRED;
>         } else if (nodes_empty(*nodes))
>                 return ERR_PTR(-EINVAL);
> 
> 
> 
> 




  parent reply	other threads:[~2015-08-24  4:23 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-21  9:27 is this a problem of numactl in RedHat7.0 ? Xishi Qiu
2015-08-21  9:27 ` Xishi Qiu
2015-08-21 20:53 ` Rik van Riel
2015-08-21 20:53   ` Rik van Riel
2015-08-24  3:28   ` Xishi Qiu
2015-08-24  3:28     ` Xishi Qiu
2015-08-24  4:15   ` Xishi Qiu [this message]
2015-08-24  4:15     ` Xishi Qiu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55DA9A4B.10203@huawei.com \
    --to=qiuxishi@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=riel@redhat.com \
    --cc=xiexiuqi@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.