All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Graf <agraf@suse.de>
To: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
	qemu-devel@nongnu.org, qemu-ppc@nongnu.org,
	qemu-stable@nongnu.org, jsnow@redhat.com, aurelien@aurel32.net
Subject: Re: [Qemu-devel] [PATCH] mac_dbdma: always clear FLUSH bit once DBDMA channel flush is complete
Date: Sun, 23 Aug 2015 22:24:58 -0700	[thread overview]
Message-ID: <55DAAAAA.1000402@suse.de> (raw)
In-Reply-To: <1440327055-29695-1-git-send-email-mark.cave-ayland@ilande.co.uk>



On 23.08.15 03:50, Mark Cave-Ayland wrote:
> The code to flush the DBDMA channel was effectively duplicated in
> dbdma_control_write(), except for the fact that the copy executed outside of a
> RUN bit transition was broken by not clearing the FLUSH bit once the flush was
> complete.
> 
> Newer PPC Linux kernels would timeout waiting for the FLUSH bit to clear again
> after submitting a FLUSH command. Fix this by always clearing the FLUSH bit
> once the channel flush is complete and removing the repeated code.
> 
> Reported-by: Aurelien Jarno <aurelien@aurel32.net>
> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> Reviewed-by: Aurelien Jarno <aurelien@aurel32.net>

Thanks, applied to ppc-next.


Alex

      reply	other threads:[~2015-08-24  5:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-23 10:50 [Qemu-devel] [PATCH] mac_dbdma: always clear FLUSH bit once DBDMA channel flush is complete Mark Cave-Ayland
2015-08-24  5:24 ` Alexander Graf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55DAAAAA.1000402@suse.de \
    --to=agraf@suse.de \
    --cc=aurelien@aurel32.net \
    --cc=jsnow@redhat.com \
    --cc=mark.cave-ayland@ilande.co.uk \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.