From: Nikolay Dimitrov <picmaster@mail.bg>
To: Otavio Salvador <otavio.salvador@ossystems.com.br>
Cc: "meta-freescale@yoctoproject.org" <meta-freescale@yoctoproject.org>
Subject: Re: [meta-fsl-arm][PATCH v8] pulseaudio: Add PulseAudio configuration
Date: Tue, 25 Aug 2015 11:55:28 +0300 [thread overview]
Message-ID: <55DC2D80.80908@mail.bg> (raw)
In-Reply-To: <CAP9ODKpOVxGvjhERau3UCe6401nHsKM8-LA84c_xwCbGP9TTHA@mail.gmail.com>
Hi Otavio,
On 08/22/2015 12:16 AM, Otavio Salvador wrote:
> On Fri, Aug 21, 2015 at 11:38 AM, Yuqing Zhu <b54851@freescale.com> wrote:
>> +IMX_PATCHES = " file://daemon.conf \
>> + file://default.pa \
>> +"
>> +SRC_URI_append_mx6 = "${IMX_PATCHES}"
>> +SRC_URI_append_mx7 = "${IMX_PATCHES}"
>
> I see no need to add a new variable for such simple append. You can
> rewrite this as:
>
> SRC_URI_append_mx6 = " file://daemon.conf file://default.pa"
> SRC_URI_append_mx7 = " file://daemon.conf file://default.pa"
The only wrong thing here is the variable name (IMX_PATCHES), as these
are config files and not patches. A better one would be IMX_PA_CONFIGS.
The change you proposed will now force the developer to duplicate and
manually keep in sync the 2 lists of config files.
Regards,
Nikolay
next prev parent reply other threads:[~2015-08-25 8:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-21 14:38 [meta-fsl-arm][PATCH v8] pulseaudio: Add PulseAudio configuration Yuqing Zhu
2015-08-21 21:16 ` Otavio Salvador
2015-08-25 8:55 ` Nikolay Dimitrov [this message]
2015-08-25 17:08 ` Otavio Salvador
-- strict thread matches above, loose matches on Subject: below --
2015-08-10 10:44 [meta-fsl-arm][PATCH v8] 3.14.38-6QP_Beta release Yuqing Zhu
2015-08-10 10:44 ` [meta-fsl-arm][PATCH v8] pulseaudio: Add PulseAudio configuration Yuqing Zhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55DC2D80.80908@mail.bg \
--to=picmaster@mail.bg \
--cc=meta-freescale@yoctoproject.org \
--cc=otavio.salvador@ossystems.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.