From: Stefan Priebe - Profihost AG <s.priebe@profihost.ag>
To: Christoph Hellwig <hch@lst.de>
Cc: "linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>,
linux-fsdevel@vger.kernel.org
Subject: Re: btrfs regression since 4.X kernel NULL pointer dereference
Date: Tue, 25 Aug 2015 11:44:13 +0200 [thread overview]
Message-ID: <55DC38ED.9060502@profihost.ag> (raw)
In-Reply-To: <20150825090030.GF31630@lst.de>
Am 25.08.2015 um 11:00 schrieb Christoph Hellwig:
> I think this is btrfs using a struct block_device that doesn't have
> a valid queue pointer in it's gendisk for ->s_bdev. And there are
> some fishy looking ->s_bdev assignments in the code which I suspect
> are related to it:
>
> fs/btrfs/dev-replace.c: if (fs_info->sb->s_bdev == src_device->bdev)
> fs/btrfs/dev-replace.c: fs_info->sb->s_bdev = tgt_device->bdev;
> fs/btrfs/volumes.c: if (device->bdev == root->fs_info->sb->s_bdev)
> fs/btrfs/volumes.c: root->fs_info->sb->s_bdev = next_device->bdev;
> fs/btrfs/volumes.c: if (tgtdev->bdev == fs_info->sb->s_bdev)
> fs/btrfs/volumes.c: fs_info->sb->s_bdev = next_device->bdev;
>
Would be very nice if anyone from btrfs can pick this up.
Stefan
next prev parent reply other threads:[~2015-08-25 9:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-22 17:29 btrfs regression since 4.X kernel NULL pointer dereference Stefan Priebe
2015-08-25 9:00 ` Christoph Hellwig
2015-08-25 9:44 ` Stefan Priebe - Profihost AG [this message]
2015-08-25 13:51 ` Chris Mason
2015-08-31 17:32 ` Stefan Priebe - Profihost AG
2015-09-01 0:06 ` Chris Mason
2015-09-01 4:41 ` Stefan Priebe
2015-09-11 23:21 ` Christoph Biedl
2015-09-10 22:21 ` Jeff Mahoney
2015-09-11 4:55 ` Stefan Priebe
2015-09-11 18:55 ` Jeff Mahoney
2015-09-11 19:05 ` Jeff Mahoney
2015-09-11 23:31 ` Stefan Priebe
2015-09-11 19:34 ` Chris Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55DC38ED.9060502@profihost.ag \
--to=s.priebe@profihost.ag \
--cc=hch@lst.de \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.