All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Priebe <s.priebe@profihost.ag>
To: Chris Mason <clm@fb.com>, Christoph Hellwig <hch@lst.de>,
	"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>,
	"<linux-fsdevel@vger.kernel.org>" <linux-fsdevel@vger.kernel.org>
Subject: Re: btrfs regression since 4.X kernel NULL pointer dereference
Date: Tue, 1 Sep 2015 06:41:17 +0200	[thread overview]
Message-ID: <55E52C6D.6050504@profihost.ag> (raw)
In-Reply-To: <20150901000610.GC5136@ret.masoncoding.com>

Am 01.09.2015 um 02:06 schrieb Chris Mason:
> On Mon, Aug 31, 2015 at 07:32:09PM +0200, Stefan Priebe - Profihost AG wrote:
>>> Am 25.08.2015 um 15:51 schrieb Chris Mason <clm@fb.com>:
>>>
>>>> On Tue, Aug 25, 2015 at 11:00:30AM +0200, Christoph Hellwig wrote:
>>>> I think this is btrfs using a struct block_device that doesn't have
>>>> a valid queue pointer in it's gendisk for ->s_bdev.  And there are
>>>> some fishy looking ->s_bdev assignments in the code which I suspect
>>>> are related to it:
>>>>
>>>> fs/btrfs/dev-replace.c: if (fs_info->sb->s_bdev == src_device->bdev)
>>>> fs/btrfs/dev-replace.c:         fs_info->sb->s_bdev = tgt_device->bdev;
>>>> fs/btrfs/volumes.c:     if (device->bdev == root->fs_info->sb->s_bdev)
>>>> fs/btrfs/volumes.c:             root->fs_info->sb->s_bdev = next_device->bdev;
>>>> fs/btrfs/volumes.c:     if (tgtdev->bdev == fs_info->sb->s_bdev)
>>>> fs/btrfs/volumes.c:             fs_info->sb->s_bdev = next_device->bdev;
>>>
>>> We've had trouble with this in the past, I'll take a look.
>>
>> Any news?
>
> Haven't been able to reproduce yet, I'll try again in the morning.

Thanks. We're using schroot like the user in this bugreport:
https://bugzilla.kernel.org/show_bug.cgi?id=100911

But he also claims he found another way to reproduce using vfcgbackup 
(last comment).

Stefan

>
> -chris
>

  reply	other threads:[~2015-09-01  4:41 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-22 17:29 btrfs regression since 4.X kernel NULL pointer dereference Stefan Priebe
2015-08-25  9:00 ` Christoph Hellwig
2015-08-25  9:44   ` Stefan Priebe - Profihost AG
2015-08-25 13:51   ` Chris Mason
2015-08-31 17:32     ` Stefan Priebe - Profihost AG
2015-09-01  0:06       ` Chris Mason
2015-09-01  4:41         ` Stefan Priebe [this message]
2015-09-11 23:21           ` Christoph Biedl
2015-09-10 22:21         ` Jeff Mahoney
2015-09-11  4:55           ` Stefan Priebe
2015-09-11 18:55   ` Jeff Mahoney
2015-09-11 19:05     ` Jeff Mahoney
2015-09-11 23:31       ` Stefan Priebe
2015-09-11 19:34     ` Chris Mason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55E52C6D.6050504@profihost.ag \
    --to=s.priebe@profihost.ag \
    --cc=clm@fb.com \
    --cc=hch@lst.de \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.