From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: Christoph Lameter <cl@linux.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Pekka Enberg <penberg@kernel.org>,
David Rientjes <rientjes@google.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>
Subject: Re: [PATCH 02/10] mm: make slab_common.c explicitly non-modular
Date: Tue, 25 Aug 2015 11:33:34 -0400 [thread overview]
Message-ID: <55DC8ACE.1080804@windriver.com> (raw)
In-Reply-To: <alpine.DEB.2.11.1508250959200.15945@east.gentwo.org>
On 2015-08-25 10:59 AM, Christoph Lameter wrote:
> On Mon, 24 Aug 2015, Paul Gortmaker wrote:
>
>> @@ -1113,7 +1113,7 @@ static int __init slab_proc_init(void)
>> &proc_slabinfo_operations);
>> return 0;
>> }
>> -module_init(slab_proc_init);
>> +device_initcall(slab_proc_init);
>> #endif /* CONFIG_SLABINFO */
>>
>> static __always_inline void *__do_krealloc(const void *p, size_t new_size,
>
> True memory management is not a module. But its also not a device.
Per the 0/N I'd rather make it equivalent to what it was already
at this point in time and then consider making it a core_initcall
or post_core early in the next dev cycle if we want to give it
a more appropriately matching category, so we can then watch for
init reordering fallout with more time on our hands.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: Christoph Lameter <cl@linux.com>
Cc: Andrew Morton <akpm@linux-foundation.org>, <linux-mm@kvack.org>,
<linux-kernel@vger.kernel.org>, Pekka Enberg <penberg@kernel.org>,
David Rientjes <rientjes@google.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>
Subject: Re: [PATCH 02/10] mm: make slab_common.c explicitly non-modular
Date: Tue, 25 Aug 2015 11:33:34 -0400 [thread overview]
Message-ID: <55DC8ACE.1080804@windriver.com> (raw)
In-Reply-To: <alpine.DEB.2.11.1508250959200.15945@east.gentwo.org>
On 2015-08-25 10:59 AM, Christoph Lameter wrote:
> On Mon, 24 Aug 2015, Paul Gortmaker wrote:
>
>> @@ -1113,7 +1113,7 @@ static int __init slab_proc_init(void)
>> &proc_slabinfo_operations);
>> return 0;
>> }
>> -module_init(slab_proc_init);
>> +device_initcall(slab_proc_init);
>> #endif /* CONFIG_SLABINFO */
>>
>> static __always_inline void *__do_krealloc(const void *p, size_t new_size,
>
> True memory management is not a module. But its also not a device.
Per the 0/N I'd rather make it equivalent to what it was already
at this point in time and then consider making it a core_initcall
or post_core early in the next dev cycle if we want to give it
a more appropriately matching category, so we can then watch for
init reordering fallout with more time on our hands.
next prev parent reply other threads:[~2015-08-25 15:33 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-24 22:14 [PATCH 00/10] mm: fix instances of non-modular code using modular fcns Paul Gortmaker
2015-08-24 22:14 ` Paul Gortmaker
2015-08-24 22:14 ` [PATCH 01/10] mm: make cleancache.c explicitly non-modular Paul Gortmaker
2015-08-24 22:14 ` Paul Gortmaker
2015-08-25 0:10 ` Konrad Rzeszutek Wilk
2015-08-25 0:10 ` Konrad Rzeszutek Wilk
2015-08-25 1:10 ` Paul Gortmaker
2015-08-25 1:10 ` Paul Gortmaker
2015-09-22 15:20 ` Konrad Rzeszutek Wilk
2015-09-22 15:20 ` Konrad Rzeszutek Wilk
2015-09-22 21:28 ` Paul Gortmaker
2015-09-22 21:28 ` Paul Gortmaker
2015-08-24 22:14 ` [PATCH 02/10] mm: make slab_common.c " Paul Gortmaker
2015-08-24 22:14 ` Paul Gortmaker
2015-08-25 14:59 ` Christoph Lameter
2015-08-25 14:59 ` Christoph Lameter
2015-08-25 15:33 ` Paul Gortmaker [this message]
2015-08-25 15:33 ` Paul Gortmaker
2015-08-24 22:14 ` [PATCH 03/10] mm: make hugetlb.c " Paul Gortmaker
2015-08-24 22:14 ` Paul Gortmaker
2015-08-26 16:47 ` Mike Kravetz
2015-08-26 16:47 ` Mike Kravetz
2015-08-24 22:14 ` [PATCH 04/10] mm: make vmscan.c " Paul Gortmaker
2015-08-24 22:14 ` Paul Gortmaker
2015-08-24 22:14 ` [PATCH 05/10] mm: make page_alloc.c " Paul Gortmaker
2015-08-24 22:14 ` Paul Gortmaker
2015-08-24 22:14 ` [PATCH 06/10] mm: make vmstat.c " Paul Gortmaker
2015-08-24 22:14 ` Paul Gortmaker
2015-08-24 22:14 ` [PATCH 07/10] mm: make workingset.c " Paul Gortmaker
2015-08-24 22:14 ` Paul Gortmaker
2015-08-24 22:14 ` [PATCH 08/10] mm: make vmalloc.c " Paul Gortmaker
2015-08-24 22:14 ` Paul Gortmaker
2015-08-24 22:14 ` [PATCH 09/10] mm: make frontswap.c " Paul Gortmaker
2015-08-24 22:14 ` Paul Gortmaker
2015-09-22 15:28 ` Konrad Rzeszutek Wilk
2015-09-22 15:28 ` Konrad Rzeszutek Wilk
2015-08-24 22:14 ` [PATCH 10/10] mm: make kasan.c " Paul Gortmaker
2015-08-24 22:14 ` Paul Gortmaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55DC8ACE.1080804@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.