[PATCH] PCI: tegra: use __pgprot() around static pgprot_t initializer

[PATCH] PCI: tegra: use __pgprot() around static pgprot_t initializer

[Ard Biesheuvel]

In order to comply with the rules that apply when STRICT_MM_TYPECHECKS
is defined, wrap the initializer for a pgprot_t in __pgprot().

Signed-off-by: Ard Biesheuvel <ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
---
 drivers/pci/host/pci-tegra.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/pci/host/pci-tegra.c b/drivers/pci/host/pci-tegra.c
index 00e92720d7f7..f8a70b64b55c 100644
--- a/drivers/pci/host/pci-tegra.c
+++ b/drivers/pci/host/pci-tegra.c
@@ -382,8 +382,8 @@ static unsigned long tegra_pcie_conf_offset(unsigned int devfn, int where)
 static struct tegra_pcie_bus *tegra_pcie_bus_alloc(struct tegra_pcie *pcie,
 						   unsigned int busnr)
 {
-	pgprot_t prot = L_PTE_PRESENT | L_PTE_YOUNG | L_PTE_DIRTY | L_PTE_XN |
-			L_PTE_MT_DEV_SHARED | L_PTE_SHARED;
+	pgprot_t prot = __pgprot(L_PTE_PRESENT | L_PTE_YOUNG | L_PTE_DIRTY |
+				 L_PTE_XN | L_PTE_MT_DEV_SHARED | L_PTE_SHARED);
 	phys_addr_t cs = pcie->cs->start;
 	struct tegra_pcie_bus *bus;
 	unsigned int i;
-- 
1.9.1

Re: [PATCH] PCI: tegra: use __pgprot() around static pgprot_t initializer

[Ard Biesheuvel]

On 30 June 2015 at 18:30, Ard Biesheuvel <ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> wrote:
> In order to comply with the rules that apply when STRICT_MM_TYPECHECKS
> is defined, wrap the initializer for a pgprot_t in __pgprot().
>
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> ---
>  drivers/pci/host/pci-tegra.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/host/pci-tegra.c b/drivers/pci/host/pci-tegra.c
> index 00e92720d7f7..f8a70b64b55c 100644
> --- a/drivers/pci/host/pci-tegra.c
> +++ b/drivers/pci/host/pci-tegra.c
> @@ -382,8 +382,8 @@ static unsigned long tegra_pcie_conf_offset(unsigned int devfn, int where)
>  static struct tegra_pcie_bus *tegra_pcie_bus_alloc(struct tegra_pcie *pcie,
>                                                    unsigned int busnr)
>  {
> -       pgprot_t prot = L_PTE_PRESENT | L_PTE_YOUNG | L_PTE_DIRTY | L_PTE_XN |
> -                       L_PTE_MT_DEV_SHARED | L_PTE_SHARED;
> +       pgprot_t prot = __pgprot(L_PTE_PRESENT | L_PTE_YOUNG | L_PTE_DIRTY |
> +                                L_PTE_XN | L_PTE_MT_DEV_SHARED | L_PTE_SHARED);
>         phys_addr_t cs = pcie->cs->start;
>         struct tegra_pcie_bus *bus;
>         unsigned int i;

Ping?

Re: [PATCH] PCI: tegra: use __pgprot() around static pgprot_t initializer

[Stephen Warren]

On 08/25/2015 09:05 AM, Ard Biesheuvel wrote:
> On 30 June 2015 at 18:30, Ard Biesheuvel <ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> wrote:
>> In order to comply with the rules that apply when STRICT_MM_TYPECHECKS
>> is defined, wrap the initializer for a pgprot_t in __pgprot().
...
>
> Ping?

You forgot to send this to the PCI maintainer or mailing list, so I 
imagine they never received it.

Re: [PATCH] PCI: tegra: use __pgprot() around static pgprot_t initializer

[Ard Biesheuvel]

On 25 August 2015 at 17:56, Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org> wrote:
> On 08/25/2015 09:05 AM, Ard Biesheuvel wrote:
>>
>> On 30 June 2015 at 18:30, Ard Biesheuvel <ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
>> wrote:
>>>
>>> In order to comply with the rules that apply when STRICT_MM_TYPECHECKS
>>> is defined, wrap the initializer for a pgprot_t in __pgprot().
>
> ...
>>
>>
>> Ping?
>
>
> You forgot to send this to the PCI maintainer or mailing list, so I imagine
> they never received it.

Oops, my bad. Resent it just now

Thanks,
Ard.