From: Xiao Guangrong <guangrong.xiao@linux.intel.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: pbonzini@redhat.com, imammedo@redhat.com, gleb@kernel.org,
mtosatti@redhat.com, stefanha@redhat.com, mst@redhat.com,
rth@twiddle.net, kvm@vger.kernel.org, qemu-devel@nongnu.org
Subject: Re: [PATCH] target-i386: enable cflushopt/clwb/pcommit instructions
Date: Wed, 26 Aug 2015 18:51:34 +0800 [thread overview]
Message-ID: <55DD9A36.8070809@linux.intel.com> (raw)
In-Reply-To: <20150821160508.GC5575@thinpad.lan.raisama.net>
On 08/22/2015 12:05 AM, Eduardo Habkost wrote:
> On Fri, Aug 21, 2015 at 01:05:12PM +0800, Xiao Guangrong wrote:
>> These instructions are used by NVDIMM drivers and the specification
>> locates at:
>> https://software.intel.com/sites/default/files/managed/0d/53/319433-022.pdf
>>
>> Let them be enabled on Broadwell on default
>>
>> Signed-off-by: Xiao Guangrong <guangrong.xiao@linux.intel.com>
>
> This breaks the ABI. If you change a CPU model you need machine compat
> code (see the TYPE_X86_CPU entries in PC_COMPAT_2_3 for example).
>
> And you can only change the CPU model in a new machine-type if that
> doesn't affect the runnability of a VM. In other words:
>
> If:
> -machine pc-i440fx-2.4 -cpu <model>,enforcec
> is runnable in a given host, then
> -machine pc-i440fx-2.5 -cpu <model>,enforce
> should be runnable too.
>
Eduardo, thanks for your info. I will dig into the code and fix this
issue in the next version.
WARNING: multiple messages have this Message-ID (diff)
From: Xiao Guangrong <guangrong.xiao@linux.intel.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: kvm@vger.kernel.org, mst@redhat.com, gleb@kernel.org,
mtosatti@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com,
imammedo@redhat.com, pbonzini@redhat.com, rth@twiddle.net
Subject: Re: [Qemu-devel] [PATCH] target-i386: enable cflushopt/clwb/pcommit instructions
Date: Wed, 26 Aug 2015 18:51:34 +0800 [thread overview]
Message-ID: <55DD9A36.8070809@linux.intel.com> (raw)
In-Reply-To: <20150821160508.GC5575@thinpad.lan.raisama.net>
On 08/22/2015 12:05 AM, Eduardo Habkost wrote:
> On Fri, Aug 21, 2015 at 01:05:12PM +0800, Xiao Guangrong wrote:
>> These instructions are used by NVDIMM drivers and the specification
>> locates at:
>> https://software.intel.com/sites/default/files/managed/0d/53/319433-022.pdf
>>
>> Let them be enabled on Broadwell on default
>>
>> Signed-off-by: Xiao Guangrong <guangrong.xiao@linux.intel.com>
>
> This breaks the ABI. If you change a CPU model you need machine compat
> code (see the TYPE_X86_CPU entries in PC_COMPAT_2_3 for example).
>
> And you can only change the CPU model in a new machine-type if that
> doesn't affect the runnability of a VM. In other words:
>
> If:
> -machine pc-i440fx-2.4 -cpu <model>,enforcec
> is runnable in a given host, then
> -machine pc-i440fx-2.5 -cpu <model>,enforce
> should be runnable too.
>
Eduardo, thanks for your info. I will dig into the code and fix this
issue in the next version.
next prev parent reply other threads:[~2015-08-26 10:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-21 5:05 [PATCH] target-i386: enable cflushopt/clwb/pcommit instructions Xiao Guangrong
2015-08-21 5:05 ` [Qemu-devel] " Xiao Guangrong
2015-08-21 16:05 ` Eduardo Habkost
2015-08-21 16:05 ` [Qemu-devel] " Eduardo Habkost
2015-08-26 10:51 ` Xiao Guangrong [this message]
2015-08-26 10:51 ` Xiao Guangrong
-- strict thread matches above, loose matches on Subject: below --
2015-10-29 7:31 Xiao Guangrong
2015-10-30 20:54 ` [Qemu-devel] " Richard Henderson
2015-11-04 19:35 ` Eduardo Habkost
2015-11-05 7:51 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55DD9A36.8070809@linux.intel.com \
--to=guangrong.xiao@linux.intel.com \
--cc=ehabkost@redhat.com \
--cc=gleb@kernel.org \
--cc=imammedo@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.