From: Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>
To: "David S . Miller" <davem@davemloft.net>,
Stephen Hemminger <stephen@networkplumber.org>
Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org
Subject: Re: [Bridge] [PATCH net-next] bridge: Add netlink support for vlan_protocol attribute
Date: Thu, 27 Aug 2015 15:22:45 +0900 [thread overview]
Message-ID: <55DEACB5.9050105@lab.ntt.co.jp> (raw)
In-Reply-To: <1440655205-14247-1-git-send-email-makita.toshiaki@lab.ntt.co.jp>
On 2015/08/27 15:00, Toshiaki Makita wrote:
> This enables bridge vlan_protocol to be configured through netlink.
>
> When CONFIG_BRIDGE_VLAN_FILTERING is disabled, kernel behaves the
> same way as this feature is not implemented.
>
> Signed-off-by: Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>
> ---
...
> static int br_changelink(struct net_device *brdev, struct nlattr *tb[],
> @@ -784,6 +800,16 @@ static int br_changelink(struct net_device *brdev, struct nlattr *tb[],
> return err;
> }
>
> +#ifdef CONFIG_BRIDGE_VLAN_FILTERING
> + if (data[IFLA_BR_VLAN_PROTOCOL]) {
> + u16 vlan_proto = nla_get_be16(data[IFLA_BR_VLAN_PROTOCOL]);
This u16 should have been __be16...
Sorry, will send v2.
Toshiaki Makita
WARNING: multiple messages have this Message-ID (diff)
From: Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>
To: "David S . Miller" <davem@davemloft.net>,
Stephen Hemminger <stephen@networkplumber.org>
Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org
Subject: Re: [PATCH net-next] bridge: Add netlink support for vlan_protocol attribute
Date: Thu, 27 Aug 2015 15:22:45 +0900 [thread overview]
Message-ID: <55DEACB5.9050105@lab.ntt.co.jp> (raw)
In-Reply-To: <1440655205-14247-1-git-send-email-makita.toshiaki@lab.ntt.co.jp>
On 2015/08/27 15:00, Toshiaki Makita wrote:
> This enables bridge vlan_protocol to be configured through netlink.
>
> When CONFIG_BRIDGE_VLAN_FILTERING is disabled, kernel behaves the
> same way as this feature is not implemented.
>
> Signed-off-by: Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>
> ---
...
> static int br_changelink(struct net_device *brdev, struct nlattr *tb[],
> @@ -784,6 +800,16 @@ static int br_changelink(struct net_device *brdev, struct nlattr *tb[],
> return err;
> }
>
> +#ifdef CONFIG_BRIDGE_VLAN_FILTERING
> + if (data[IFLA_BR_VLAN_PROTOCOL]) {
> + u16 vlan_proto = nla_get_be16(data[IFLA_BR_VLAN_PROTOCOL]);
This u16 should have been __be16...
Sorry, will send v2.
Toshiaki Makita
next prev parent reply other threads:[~2015-08-27 6:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-27 6:00 [Bridge] [PATCH net-next] bridge: Add netlink support for vlan_protocol attribute Toshiaki Makita
2015-08-27 6:00 ` Toshiaki Makita
2015-08-27 6:22 ` Toshiaki Makita [this message]
2015-08-27 6:22 ` Toshiaki Makita
2015-08-27 15:48 ` [Bridge] " Nikolay Aleksandrov
2015-08-27 15:48 ` Nikolay Aleksandrov
2015-08-28 11:06 ` [Bridge] " Toshiaki Makita
2015-08-28 15:25 ` Nikolay Aleksandrov
2015-08-28 15:25 ` Nikolay Aleksandrov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55DEACB5.9050105@lab.ntt.co.jp \
--to=makita.toshiaki@lab.ntt.co.jp \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.