All of lore.kernel.org
 help / color / mirror / Atom feed
* [meta-multimedia][PATCH] vlc: fix for libtool error
@ 2015-08-27  4:35 Tim Orling
  2015-08-27  8:41 ` Andreas Oberritter
  0 siblings, 1 reply; 4+ messages in thread
From: Tim Orling @ 2015-08-27  4:35 UTC (permalink / raw)
  To: openembedded-devel

Patch recommended by:
  Rafaël Carré funman@videolan.org

Signed-off-by: Tim Orling <TicoTimo@gmail.com>
---
 meta-multimedia/recipes-multimedia/vlc/vlc.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta-multimedia/recipes-multimedia/vlc/vlc.inc b/meta-multimedia/recipes-multimedia/vlc/vlc.inc
index bf7ce0c..c4548c7 100644
--- a/meta-multimedia/recipes-multimedia/vlc/vlc.inc
+++ b/meta-multimedia/recipes-multimedia/vlc/vlc.inc
@@ -63,7 +63,7 @@ do_configure_prepend() {
 
 do_configure_append() {
     sed -i -e s:'$(MOC) $(DEFS) $(CPPFLAGS)':'$(MOC) $(DEFS)'\ -I${B}/include\ -DSYS_LINUX:g ${B}/modules/gui/qt4/Makefile
-    sed -i -e s:'${top_builddir_slash}libtool':${TARGET_SYS}-libtool:g ${B}/doltlibtool
+    sed -i -e s:'${top_builddir_slash}libtool':'${top_buildir_slash}'${TARGET_SYS}-libtool:g ${B}/doltlibtool
 }
 
 # This recipe packages vlc as a library as well, so qt4 dependencies
-- 
2.1.0



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [meta-multimedia][PATCH] vlc: fix for libtool error
  2015-08-27  4:35 [meta-multimedia][PATCH] vlc: fix for libtool error Tim Orling
@ 2015-08-27  8:41 ` Andreas Oberritter
  2015-08-28  3:50   ` Khem Raj
  0 siblings, 1 reply; 4+ messages in thread
From: Andreas Oberritter @ 2015-08-27  8:41 UTC (permalink / raw)
  To: openembedded-devel

Hallo Tim,

On 27.08.2015 06:35, Tim Orling wrote:
> Patch recommended by:
>   Rafaël Carré funman@videolan.org
> 
> Signed-off-by: Tim Orling <TicoTimo@gmail.com>
> ---
>  meta-multimedia/recipes-multimedia/vlc/vlc.inc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta-multimedia/recipes-multimedia/vlc/vlc.inc b/meta-multimedia/recipes-multimedia/vlc/vlc.inc
> index bf7ce0c..c4548c7 100644
> --- a/meta-multimedia/recipes-multimedia/vlc/vlc.inc
> +++ b/meta-multimedia/recipes-multimedia/vlc/vlc.inc
> @@ -63,7 +63,7 @@ do_configure_prepend() {
>  
>  do_configure_append() {
>      sed -i -e s:'$(MOC) $(DEFS) $(CPPFLAGS)':'$(MOC) $(DEFS)'\ -I${B}/include\ -DSYS_LINUX:g ${B}/modules/gui/qt4/Makefile
> -    sed -i -e s:'${top_builddir_slash}libtool':${TARGET_SYS}-libtool:g ${B}/doltlibtool
> +    sed -i -e s:'${top_builddir_slash}libtool':'${top_buildir_slash}'${TARGET_SYS}-libtool:g ${B}/doltlibtool
                                                              ^
this looks like a typo (missing d).

Regards,
Andreas



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [meta-multimedia][PATCH] vlc: fix for libtool error
  2015-08-27  8:41 ` Andreas Oberritter
@ 2015-08-28  3:50   ` Khem Raj
  2015-08-28  4:03     ` Tim Orling
  0 siblings, 1 reply; 4+ messages in thread
From: Khem Raj @ 2015-08-28  3:50 UTC (permalink / raw)
  To: openembeded-devel

On Thu, Aug 27, 2015 at 1:41 AM, Andreas Oberritter
<obi@opendreambox.org> wrote:
>> +    sed -i -e s:'${top_builddir_slash}libtool':'${top_buildir_slash}'${TARGET_SYS}-libtool:g ${B}/doltlibtool
>                                                               ^
> this looks like a typo (missing d).
>

did not understand where 'd' should be, but I hope '' around
${top_builddir_slash} will avoid bitbake exapnding it.


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [meta-multimedia][PATCH] vlc: fix for libtool error
  2015-08-28  3:50   ` Khem Raj
@ 2015-08-28  4:03     ` Tim Orling
  0 siblings, 0 replies; 4+ messages in thread
From: Tim Orling @ 2015-08-28  4:03 UTC (permalink / raw)
  To: openembedded-devel@lists.openembedded.org

On Thu, Aug 27, 2015 at 8:50 PM, Khem Raj <raj.khem@gmail.com> wrote:

> On Thu, Aug 27, 2015 at 1:41 AM, Andreas Oberritter
> <obi@opendreambox.org> wrote:
> >> +    sed -i -e
> s:'${top_builddir_slash}libtool':'${top_buildir_slash}'${TARGET_SYS}-libtool:g
> ${B}/doltlibtool
> >                                                               ^
> > this looks like a typo (missing d).
> >
>
> did not understand where 'd' should be, but I hope '' around
> ${top_builddir_slash} will avoid bitbake exapnding it.
> --
>

Correct.  Already submitted v2 patch:
http://patchwork.openembedded.org/patch/101809/


> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2015-08-28  4:03 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-27  4:35 [meta-multimedia][PATCH] vlc: fix for libtool error Tim Orling
2015-08-27  8:41 ` Andreas Oberritter
2015-08-28  3:50   ` Khem Raj
2015-08-28  4:03     ` Tim Orling

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.