[PATCH/RFC 10/10] Local: Hack: arm64: dts: r8a7795: add ravb phy max-speed 100 for Salvator-X board

[PATCH/RFC 10/10] Local: Hack: arm64: dts: r8a7795: add ravb phy max-speed 100 for Salvator-X board

[Simon Horman]

From: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>

This is a work-around for limitations in the driver implementation.

Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
[horms: updated filename to salvator-x; updated changelog]
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
 arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts b/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
index 109261ea60bd..2e2329451791 100644
--- a/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
+++ b/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
@@ -134,6 +134,7 @@
 		reg = <0>;
 		interrupt-parent = <&gpio2>;
 		interrupts = <11 IRQ_TYPE_LEVEL_LOW>;
+		max-speed = <100>;
 	};
 
 };
-- 
2.1.4

Re: [PATCH/RFC 10/10] Local: Hack: arm64: dts: r8a7795: add ravb phy max-speed 100 for Salvator-X bo

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 322 bytes --]

On Thu, Aug 27, 2015 at 06:24:10PM +0900, Simon Horman wrote:
> From: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
> 
> This is a work-around for limitations in the driver implementation.

I know this is marked "local: hack:", still: If this is a driver
limitation, shouldn't it rather be in the dtsi then?


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH/RFC 10/10] Local: Hack: arm64: dts: r8a7795: add ravb phy max-speed 100 for Salvator-X bo

[Geert Uytterhoeven]

On Thu, Aug 27, 2015 at 1:57 PM, Wolfram Sang <wsa@the-dreams.de> wrote:
> On Thu, Aug 27, 2015 at 06:24:10PM +0900, Simon Horman wrote:
>> From: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
>>
>> This is a work-around for limitations in the driver implementation.
>
> I know this is marked "local: hack:", still: If this is a driver
> limitation, shouldn't it rather be in the dtsi then?

You mean, in the driver?

DT decribes the hardware, not driver limitations.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH/RFC 10/10] Local: Hack: arm64: dts: r8a7795: add ravb phy max-speed 100 for Salvator-X bo

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 775 bytes --]

On Thu, Aug 27, 2015 at 01:59:32PM +0200, Geert Uytterhoeven wrote:
> On Thu, Aug 27, 2015 at 1:57 PM, Wolfram Sang <wsa@the-dreams.de> wrote:
> > On Thu, Aug 27, 2015 at 06:24:10PM +0900, Simon Horman wrote:
> >> From: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
> >>
> >> This is a work-around for limitations in the driver implementation.
> >
> > I know this is marked "local: hack:", still: If this is a driver
> > limitation, shouldn't it rather be in the dtsi then?
> 
> You mean, in the driver?
> 
> DT decribes the hardware, not driver limitations.

I wanted to ensure that this workaround goes into all dts files
including the r8a7795 dtsi, even custom ones for testing. This is rather
SoC than board specific, no? And yes, still a hack :)


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH/RFC 10/10] Local: Hack: arm64: dts: r8a7795: add ravb phy max-speed 100 for Salvator-X bo

[Sergei Shtylyov]

On 8/27/2015 12:24 PM, Simon Horman wrote:

> From: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
>
> This is a work-around for limitations in the driver implementation.
>
> Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
> [horms: updated filename to salvator-x; updated changelog]
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> ---
>   arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts b/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
> index 109261ea60bd..2e2329451791 100644
> --- a/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
> @@ -134,6 +134,7 @@
>   		reg = <0>;
>   		interrupt-parent = <&gpio2>;
>   		interrupts = <11 IRQ_TYPE_LEVEL_LOW>;

    Actually, the GPIO interrupt was also used to overcome the driver's 
limitation. The AVB_PHY_IRQ is directly reflected in the AVB registers, I just 
didn't want to use a thread in order to call phy_mac_interrupt().

> +		max-speed = <100>;
>   	};
>
>   };

MBR, Sergei

Re: [PATCH/RFC 10/10] Local: Hack: arm64: dts: r8a7795: add ravb phy max-speed 100 for Salvator-X bo

[Sergei Shtylyov]

On 8/27/2015 3:46 PM, Wolfram Sang wrote:

>>>> From: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
>>>>
>>>> This is a work-around for limitations in the driver implementation.
>>>
>>> I know this is marked "local: hack:", still: If this is a driver
>>> limitation, shouldn't it rather be in the dtsi then?
>>
>> You mean, in the driver?
>>
>> DT decribes the hardware, not driver limitations.
>
> I wanted to ensure that this workaround goes into all dts files
> including the r8a7795 dtsi, even custom ones for testing. This is rather
> SoC than board specific, no?

    I don't think so. BTW, the prop is specified for the PHY device which is 
not a part of SoC, so your question is pointless.

MBR, Sergei

Re: [PATCH/RFC 10/10] Local: Hack: arm64: dts: r8a7795: add ravb phy max-speed 100 for Salvator-X bo

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 138 bytes --]


>    I don't think so. BTW, the prop is specified for the PHY device which is
> not a part of SoC, so your question is pointless.

Ack.


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH/RFC 10/10] Local: Hack: arm64: dts: r8a7795: add ravb phy max-speed 100 for Salvator-X bo

[Simon Horman]

On Thu, Aug 27, 2015 at 01:59:32PM +0200, Geert Uytterhoeven wrote:
> On Thu, Aug 27, 2015 at 1:57 PM, Wolfram Sang <wsa@the-dreams.de> wrote:
> > On Thu, Aug 27, 2015 at 06:24:10PM +0900, Simon Horman wrote:
> >> From: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
> >>
> >> This is a work-around for limitations in the driver implementation.
> >
> > I know this is marked "local: hack:", still: If this is a driver
> > limitation, shouldn't it rather be in the dtsi then?
> 
> You mean, in the driver?
> 
> DT decribes the hardware, not driver limitations.

Yes indeed, that was my main reason behind labelling it as a local hack.

Re: [PATCH/RFC 10/10] Local: Hack: arm64: dts: r8a7795: add ravb phy max-speed 100 for Salvator-X bo

[Magnus Damm]

Hi Geert,

On Thu, Aug 27, 2015 at 8:59 PM, Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
> On Thu, Aug 27, 2015 at 1:57 PM, Wolfram Sang <wsa@the-dreams.de> wrote:
>> On Thu, Aug 27, 2015 at 06:24:10PM +0900, Simon Horman wrote:
>>> From: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
>>>
>>> This is a work-around for limitations in the driver implementation.
>>
>> I know this is marked "local: hack:", still: If this is a driver
>> limitation, shouldn't it rather be in the dtsi then?
>
> You mean, in the driver?

I also think it would make sense to have this kind of short term hack
in the _driver_ and not in the DTS.

> DT decribes the hardware, not driver limitations.

Totally agree!

/ magnus

Re: [PATCH/RFC 10/10] Local: Hack: arm64: dts: r8a7795: add ravb phy max-speed 100 for Salvator-X bo

[Simon Horman]

On Fri, Aug 28, 2015 at 09:46:16AM +0900, Magnus Damm wrote:
> Hi Geert,
> 
> On Thu, Aug 27, 2015 at 8:59 PM, Geert Uytterhoeven
> <geert@linux-m68k.org> wrote:
> > On Thu, Aug 27, 2015 at 1:57 PM, Wolfram Sang <wsa@the-dreams.de> wrote:
> >> On Thu, Aug 27, 2015 at 06:24:10PM +0900, Simon Horman wrote:
> >>> From: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
> >>>
> >>> This is a work-around for limitations in the driver implementation.
> >>
> >> I know this is marked "local: hack:", still: If this is a driver
> >> limitation, shouldn't it rather be in the dtsi then?
> >
> > You mean, in the driver?
> 
> I also think it would make sense to have this kind of short term hack
> in the _driver_ and not in the DTS.

I agree having it in DTS is not nice.
Which driver would you see it fitting into?

Re: [PATCH/RFC 10/10] Local: Hack: arm64: dts: r8a7795: add ravb phy max-speed 100 for Salvator-X bo

[Magnus Damm]

Hi Simon,

On Fri, Aug 28, 2015 at 2:23 PM, Simon Horman <horms@verge.net.au> wrote:
> On Fri, Aug 28, 2015 at 09:46:16AM +0900, Magnus Damm wrote:
>> Hi Geert,
>>
>> On Thu, Aug 27, 2015 at 8:59 PM, Geert Uytterhoeven
>> <geert@linux-m68k.org> wrote:
>> > On Thu, Aug 27, 2015 at 1:57 PM, Wolfram Sang <wsa@the-dreams.de> wrote:
>> >> On Thu, Aug 27, 2015 at 06:24:10PM +0900, Simon Horman wrote:
>> >>> From: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
>> >>>
>> >>> This is a work-around for limitations in the driver implementation.
>> >>
>> >> I know this is marked "local: hack:", still: If this is a driver
>> >> limitation, shouldn't it rather be in the dtsi then?
>> >
>> > You mean, in the driver?
>>
>> I also think it would make sense to have this kind of short term hack
>> in the _driver_ and not in the DTS.
>
> I agree having it in DTS is not nice.
> Which driver would you see it fitting into?

Based on the commit message it must be "in the driver implementation". =)

Cheers,

/ magnus