All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stanimir Varbanov <svarbanov@mm-sol.com>
To: Andy Gross <agross@codeaurora.org>, linux-arm-msm@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Bjorn Andersson <bjorn.andersson@sonymobile.com>
Subject: Re: [PATCH v2] soc: qcom: smd: Use correct remote processor ID
Date: Thu, 27 Aug 2015 18:26:45 +0300	[thread overview]
Message-ID: <55DF2C35.4030207@mm-sol.com> (raw)
In-Reply-To: <1440618165-9410-1-git-send-email-agross@codeaurora.org>

On 08/26/2015 10:42 PM, Andy Gross wrote:
> This patch fixes SMEM addressing issues when remote processors need to use
> secure SMEM partitions.
> 
> Signed-off-by: Andy Gross <agross@codeaurora.org>
> ---
>  .../devicetree/bindings/soc/qcom/qcom,smd.txt      |    6 ++++++
>  drivers/soc/qcom/smd.c                             |   15 +++++++++++----
>  2 files changed, 17 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,smd.txt b/Documentation/devicetree/bindings/soc/qcom/qcom,smd.txt
> index f65c76d..97d9b3e 100644
> --- a/Documentation/devicetree/bindings/soc/qcom/qcom,smd.txt
> +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,smd.txt
> @@ -37,6 +37,12 @@ The edge is described by the following properties:
>  	Definition: the identifier of the remote processor in the smd channel
>  		    allocation table
>  
> +- qcom,remote-pid:
> +	Usage: optional
> +	Value type: <u32>
> +	Definition: the identifier for the remote processor as known by the rest
> +		    of the system.
> +
>  = SMD DEVICES
>  
>  In turn, subnodes of the "edges" represent devices tied to SMD channels on that
> diff --git a/drivers/soc/qcom/smd.c b/drivers/soc/qcom/smd.c
> index 327adcf..5706a81 100644
> --- a/drivers/soc/qcom/smd.c
> +++ b/drivers/soc/qcom/smd.c
> @@ -111,6 +111,7 @@ struct qcom_smd_edge {
>  	struct qcom_smd *smd;
>  	struct device_node *of_node;
>  	unsigned edge_id;
> +	unsigned remote_pid;

Andy, you forgot to add this new field in structure description header.

<snip>

-- 
regards,
Stan

WARNING: multiple messages have this Message-ID (diff)
From: svarbanov@mm-sol.com (Stanimir Varbanov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] soc: qcom: smd: Use correct remote processor ID
Date: Thu, 27 Aug 2015 18:26:45 +0300	[thread overview]
Message-ID: <55DF2C35.4030207@mm-sol.com> (raw)
In-Reply-To: <1440618165-9410-1-git-send-email-agross@codeaurora.org>

On 08/26/2015 10:42 PM, Andy Gross wrote:
> This patch fixes SMEM addressing issues when remote processors need to use
> secure SMEM partitions.
> 
> Signed-off-by: Andy Gross <agross@codeaurora.org>
> ---
>  .../devicetree/bindings/soc/qcom/qcom,smd.txt      |    6 ++++++
>  drivers/soc/qcom/smd.c                             |   15 +++++++++++----
>  2 files changed, 17 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,smd.txt b/Documentation/devicetree/bindings/soc/qcom/qcom,smd.txt
> index f65c76d..97d9b3e 100644
> --- a/Documentation/devicetree/bindings/soc/qcom/qcom,smd.txt
> +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,smd.txt
> @@ -37,6 +37,12 @@ The edge is described by the following properties:
>  	Definition: the identifier of the remote processor in the smd channel
>  		    allocation table
>  
> +- qcom,remote-pid:
> +	Usage: optional
> +	Value type: <u32>
> +	Definition: the identifier for the remote processor as known by the rest
> +		    of the system.
> +
>  = SMD DEVICES
>  
>  In turn, subnodes of the "edges" represent devices tied to SMD channels on that
> diff --git a/drivers/soc/qcom/smd.c b/drivers/soc/qcom/smd.c
> index 327adcf..5706a81 100644
> --- a/drivers/soc/qcom/smd.c
> +++ b/drivers/soc/qcom/smd.c
> @@ -111,6 +111,7 @@ struct qcom_smd_edge {
>  	struct qcom_smd *smd;
>  	struct device_node *of_node;
>  	unsigned edge_id;
> +	unsigned remote_pid;

Andy, you forgot to add this new field in structure description header.

<snip>

-- 
regards,
Stan

  parent reply	other threads:[~2015-08-27 15:26 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-26 19:42 [PATCH v2] soc: qcom: smd: Use correct remote processor ID Andy Gross
2015-08-26 19:42 ` Andy Gross
2015-08-26 20:39 ` Bjorn Andersson
2015-08-26 20:39   ` Bjorn Andersson
2015-08-26 20:39   ` Bjorn Andersson
2015-08-27 15:26 ` Stanimir Varbanov [this message]
2015-08-27 15:26   ` Stanimir Varbanov
2015-08-27 16:32   ` Andy Gross
2015-08-27 16:32     ` Andy Gross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55DF2C35.4030207@mm-sol.com \
    --to=svarbanov@mm-sol.com \
    --cc=agross@codeaurora.org \
    --cc=bjorn.andersson@sonymobile.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.