From: "Denis V. Lunev" <den-lists@parallels.com>
To: "Marc-André Lureau" <marcandre.lureau@gmail.com>,
"Denis V. Lunev" <den@openvz.org>
Cc: QEMU <qemu-devel@nongnu.org>, Michael Roth <mdroth@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH v4 04/13] qga: make split_list() return allocated strings
Date: Thu, 27 Aug 2015 19:15:04 +0300 [thread overview]
Message-ID: <55DF3788.9020104@parallels.com> (raw)
In-Reply-To: <CAJ+F1CLoX1piRRxBCXyDpWazB+e_BPU6Gwmc3ktTCaA0S3TaRA@mail.gmail.com>
On 08/27/2015 05:30 PM, Marc-André Lureau wrote:
> Hi
>
> On Thu, Aug 27, 2015 at 11:17 AM, Denis V. Lunev <den@openvz.org> wrote:
>> why not to
>> __str = g_strsplit(str, delim, -1);
>>>> + strv = g_strsplit(str, delim, -1);
>>>> + for (i = 0; strv[i]; i++) {
>>>> + list = g_list_prepend(list, strv[i]);
>>>> }
>>>> + g_free(strv);
>> g_free(__str);
>>
>> This will remove all burden from callers.
>> You will be able to use const char * as argument too.
>
> Sorry, I don't understand, could you propose a different patch?
>
you are right, me wrong :) I have mis-read the code.
This one is perfect.
Reviewed-by: Denis V. Lunev <den@openvz.org>
next prev parent reply other threads:[~2015-08-27 16:15 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-26 23:34 [Qemu-devel] [PATCH v4 00/13] qemu-ga: add a configuration file marcandre.lureau
2015-08-26 23:34 ` [Qemu-devel] [PATCH v4 01/13] qga: misc spelling marcandre.lureau
2015-08-26 23:34 ` [Qemu-devel] [PATCH v4 02/13] qga: use exit() when parsing options marcandre.lureau
2015-08-26 23:34 ` [Qemu-devel] [PATCH v4 03/13] qga: move string split in separate function marcandre.lureau
2015-08-27 9:18 ` Denis V. Lunev
2015-08-26 23:34 ` [Qemu-devel] [PATCH v4 04/13] qga: make split_list() return allocated strings marcandre.lureau
2015-08-27 9:13 ` Denis V. Lunev
2015-08-27 9:17 ` Denis V. Lunev
2015-08-27 14:30 ` Marc-André Lureau
2015-08-27 16:15 ` Denis V. Lunev [this message]
2015-08-26 23:34 ` [Qemu-devel] [PATCH v4 05/13] qga: rename 'path' to 'channel_path' marcandre.lureau
2015-08-26 23:34 ` [Qemu-devel] [PATCH v4 06/13] qga: copy argument strings marcandre.lureau
2015-08-27 9:53 ` Denis V. Lunev
2015-08-26 23:34 ` [Qemu-devel] [PATCH v4 07/13] qga: move option parsing to separate function marcandre.lureau
2015-08-26 23:34 ` [Qemu-devel] [PATCH v4 08/13] qga: fill default options in main() marcandre.lureau
2015-08-26 23:34 ` [Qemu-devel] [PATCH v4 09/13] qga: move agent run in a separate function marcandre.lureau
2015-08-26 23:34 ` [Qemu-devel] [PATCH v4 10/13] qga: free a bit more marcandre.lureau
2015-08-26 23:34 ` [Qemu-devel] [PATCH v4 11/13] qga: add an optional qemu-ga.conf system configuration marcandre.lureau
2015-08-27 10:02 ` Denis V. Lunev
2015-08-26 23:34 ` [Qemu-devel] [PATCH v4 12/13] qga: add --dump-conf option marcandre.lureau
2015-08-26 23:38 ` Marc-André Lureau
2015-08-27 9:56 ` Denis V. Lunev
2015-08-27 9:57 ` Denis V. Lunev
2015-08-26 23:34 ` [Qemu-devel] [PATCH v4 13/13] qga: start a man page marcandre.lureau
2015-08-28 21:44 ` Eric Blake
2015-08-31 23:28 ` Michael Roth
2015-09-01 15:11 ` Eric Blake
2015-08-27 16:32 ` [Qemu-devel] [PATCH v4 00/13] qemu-ga: add a configuration file Denis V. Lunev
2015-08-27 23:47 ` Michael Roth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55DF3788.9020104@parallels.com \
--to=den-lists@parallels.com \
--cc=den@openvz.org \
--cc=marcandre.lureau@gmail.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.