From: Stefan Weil <sw@weilnetz.de>
To: Samuel Thibault <samuel.thibault@gnu.org>
Cc: QEMU Trivial <qemu-trivial@nongnu.org>, qemu-devel@nongnu.org
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] baum: Fix build with debugging enabled
Date: Sun, 30 Aug 2015 17:39:38 +0200 [thread overview]
Message-ID: <55E323BA.8030402@weilnetz.de> (raw)
In-Reply-To: <20150830151213.GE3238@var.home>
[-- Attachment #1: Type: text/plain, Size: 876 bytes --]
Am 30.08.2015 um 17:12 schrieb Samuel Thibault:
> cur and buf are pointers, so the difference is a ptrdiff_t
>
> Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
>
> diff --git a/backends/baum.c b/backends/baum.c
> index a69aaff..1f9288e 100644
> --- a/backends/baum.c
> +++ b/backends/baum.c
> @@ -303,7 +303,7 @@ static int baum_eat_packet(BaumDriverState *baum, const uint8_t *buf, int len)
> return 0;
> cur++;
> }
> - DPRINTF("Dropped %d bytes!\n", cur - buf);
> + DPRINTF("Dropped %td bytes!\n", cur - buf);
> }
>
> #define EAT(c) do {\
>
Please don't send patches as reply to previous e-mails
and use a subject which shows the patch revision (here
"[PATCH v2] baum: Fix build with debugging enabled")
for future patches.
Reviewed-by: Stefan Weil <sw@weilnetz.de>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Stefan Weil <sw@weilnetz.de>
To: Samuel Thibault <samuel.thibault@gnu.org>
Cc: QEMU Trivial <qemu-trivial@nongnu.org>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] baum: Fix build with debugging enabled
Date: Sun, 30 Aug 2015 17:39:38 +0200 [thread overview]
Message-ID: <55E323BA.8030402@weilnetz.de> (raw)
In-Reply-To: <20150830151213.GE3238@var.home>
[-- Attachment #1: Type: text/plain, Size: 876 bytes --]
Am 30.08.2015 um 17:12 schrieb Samuel Thibault:
> cur and buf are pointers, so the difference is a ptrdiff_t
>
> Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
>
> diff --git a/backends/baum.c b/backends/baum.c
> index a69aaff..1f9288e 100644
> --- a/backends/baum.c
> +++ b/backends/baum.c
> @@ -303,7 +303,7 @@ static int baum_eat_packet(BaumDriverState *baum, const uint8_t *buf, int len)
> return 0;
> cur++;
> }
> - DPRINTF("Dropped %d bytes!\n", cur - buf);
> + DPRINTF("Dropped %td bytes!\n", cur - buf);
> }
>
> #define EAT(c) do {\
>
Please don't send patches as reply to previous e-mails
and use a subject which shows the patch revision (here
"[PATCH v2] baum: Fix build with debugging enabled")
for future patches.
Reviewed-by: Stefan Weil <sw@weilnetz.de>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-08-30 15:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-30 14:19 [Qemu-devel] [PATCH] baum: Fix build with debugging enabled Samuel Thibault
2015-08-30 14:38 ` Stefan Weil
2015-08-30 14:50 ` Samuel Thibault
2015-08-30 15:02 ` Stefan Weil
2015-08-30 15:12 ` Samuel Thibault
2015-08-30 15:39 ` Stefan Weil [this message]
2015-08-30 15:39 ` Stefan Weil
2015-09-06 11:03 ` [Qemu-trivial] " Michael Tokarev
2015-09-06 11:03 ` [Qemu-devel] " Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55E323BA.8030402@weilnetz.de \
--to=sw@weilnetz.de \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=samuel.thibault@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.