From: Kishon Vijay Abraham I <kishon@ti.com>
To: Tony Lindgren <tony@atomide.com>, Olof Johansson <olof@lixom.net>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
afenkart@gmail.com,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
linux-omap <linux-omap@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Sekhar Nori <nsekhar@ti.com>, Neil Brown <neilb@suse.de>
Subject: Re: [PATCH v3 02/15] mmc: host: omap_hsmmc: return on fatal errors from omap_hsmmc_reg_get
Date: Mon, 31 Aug 2015 11:14:17 +0530 [thread overview]
Message-ID: <55E3E9B1.8070908@ti.com> (raw)
In-Reply-To: <20150828190354.GZ4215@atomide.com>
Hi,
On Saturday 29 August 2015 12:33 AM, Tony Lindgren wrote:
> * Olof Johansson <olof@lixom.net> [150828 11:11]:
>> Hi,
>>
>> On Thu, Aug 27, 2015 at 2:13 AM, Kishon Vijay Abraham I <kishon@ti.com> wrote:
>>> Now return error only if the return value of
>>> devm_regulator_get_optional() is not the same as -ENODEV, since with
>>> -EPROBE_DEFER, the regulator can be obtained later and all other
>>> errors are fatal.
>>>
>>> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
>>> Tested-by: Tony Lindgren <tony@atomide.com>
>>
>> I bisected boot failures on Panda ES with multi_v7_defconfig down to
>> this commit on last night's -next build:
>>
>> http://arm-soc.lixom.net/bootlogs/next/next-20150828/pandaes-arm-multi_v7_defconfig.html
>
> MMC is working for me at least on Duovero. Interesting that you also
> have all kind of errors there, I guess this is some older revision
> of the board.
>
> Anyways, Kishon, care to look into what might be causing this?
I think this might be because my pbias fix [1] patch wasn't merged yet.
I'll try to get that resolved asap.
Thanks
Kishon
[1] -> http://lkml.iu.edu/hypermail/linux/kernel/1507.3/01594.html
>
> Regards,
>
> Tony
>
WARNING: multiple messages have this Message-ID (diff)
From: Kishon Vijay Abraham I <kishon@ti.com>
To: Tony Lindgren <tony@atomide.com>, Olof Johansson <olof@lixom.net>
Cc: Ulf Hansson <ulf.hansson@linaro.org>, <afenkart@gmail.com>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
linux-omap <linux-omap@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Sekhar Nori <nsekhar@ti.com>, Neil Brown <neilb@suse.de>
Subject: Re: [PATCH v3 02/15] mmc: host: omap_hsmmc: return on fatal errors from omap_hsmmc_reg_get
Date: Mon, 31 Aug 2015 11:14:17 +0530 [thread overview]
Message-ID: <55E3E9B1.8070908@ti.com> (raw)
In-Reply-To: <20150828190354.GZ4215@atomide.com>
Hi,
On Saturday 29 August 2015 12:33 AM, Tony Lindgren wrote:
> * Olof Johansson <olof@lixom.net> [150828 11:11]:
>> Hi,
>>
>> On Thu, Aug 27, 2015 at 2:13 AM, Kishon Vijay Abraham I <kishon@ti.com> wrote:
>>> Now return error only if the return value of
>>> devm_regulator_get_optional() is not the same as -ENODEV, since with
>>> -EPROBE_DEFER, the regulator can be obtained later and all other
>>> errors are fatal.
>>>
>>> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
>>> Tested-by: Tony Lindgren <tony@atomide.com>
>>
>> I bisected boot failures on Panda ES with multi_v7_defconfig down to
>> this commit on last night's -next build:
>>
>> http://arm-soc.lixom.net/bootlogs/next/next-20150828/pandaes-arm-multi_v7_defconfig.html
>
> MMC is working for me at least on Duovero. Interesting that you also
> have all kind of errors there, I guess this is some older revision
> of the board.
>
> Anyways, Kishon, care to look into what might be causing this?
I think this might be because my pbias fix [1] patch wasn't merged yet.
I'll try to get that resolved asap.
Thanks
Kishon
[1] -> http://lkml.iu.edu/hypermail/linux/kernel/1507.3/01594.html
>
> Regards,
>
> Tony
>
next prev parent reply other threads:[~2015-08-31 5:44 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-27 9:13 [PATCH v3 00/15] omap_hsmmc: regulator usage cleanup and fixes Kishon Vijay Abraham I
2015-08-27 9:13 ` Kishon Vijay Abraham I
2015-08-27 9:13 ` [PATCH v3 01/15] mmc: host: omap_hsmmc: use devm_regulator_get_optional() for vmmc Kishon Vijay Abraham I
2015-08-27 9:13 ` Kishon Vijay Abraham I
2015-08-27 9:13 ` [PATCH v3 02/15] mmc: host: omap_hsmmc: return on fatal errors from omap_hsmmc_reg_get Kishon Vijay Abraham I
2015-08-27 9:13 ` Kishon Vijay Abraham I
2015-08-28 18:07 ` Olof Johansson
2015-08-28 19:03 ` Tony Lindgren
2015-08-31 5:44 ` Kishon Vijay Abraham I [this message]
2015-08-31 5:44 ` Kishon Vijay Abraham I
2015-08-31 20:58 ` Tony Lindgren
2015-08-31 21:14 ` Tony Lindgren
2015-09-01 14:33 ` Grygorii Strashko
2015-09-01 14:33 ` Grygorii Strashko
2015-09-01 14:50 ` Tony Lindgren
2015-09-01 14:54 ` Grygorii Strashko
2015-09-01 14:54 ` Grygorii Strashko
2015-09-01 15:03 ` Tony Lindgren
2015-09-10 16:59 ` Kevin Hilman
2015-09-10 20:45 ` Tony Lindgren
2015-08-27 9:13 ` [PATCH v3 03/15] mmc: host: omap_hsmmc: cleanup omap_hsmmc_reg_get() Kishon Vijay Abraham I
2015-08-27 9:13 ` Kishon Vijay Abraham I
2015-08-27 9:13 ` [PATCH v3 04/15] mmc: host: omap_hsmmc: use the ocrmask provided by the vmmc regulator Kishon Vijay Abraham I
2015-08-27 9:13 ` Kishon Vijay Abraham I
2015-08-27 9:13 ` [PATCH v3 05/15] mmc: host: omap_hsmmc: use mmc_host's vmmc and vqmmc Kishon Vijay Abraham I
2015-08-27 9:13 ` Kishon Vijay Abraham I
2015-08-27 9:13 ` [PATCH v3 06/15] mmc: host: omap_hsmmc: remove unnecessary pbias set_voltage Kishon Vijay Abraham I
2015-08-27 9:13 ` Kishon Vijay Abraham I
2015-08-27 9:13 ` [PATCH v3 07/15] mmc: host: omap_hsmmc: return error if any of the regulator APIs fail Kishon Vijay Abraham I
2015-08-27 9:13 ` Kishon Vijay Abraham I
2015-08-27 9:14 ` [PATCH v3 08/15] mmc: host: omap_hsmmc: add separate functions for enable/disable supply Kishon Vijay Abraham I
2015-08-27 9:14 ` Kishon Vijay Abraham I
2015-08-27 9:14 ` [PATCH v3 09/15] mmc: host: omap_hsmmc: add separate function to set pbias Kishon Vijay Abraham I
2015-08-27 9:14 ` Kishon Vijay Abraham I
2015-08-27 9:14 ` [PATCH v3 10/15] mmc: host: omap_hsmmc: avoid pbias regulator enable on power off Kishon Vijay Abraham I
2015-08-27 9:14 ` Kishon Vijay Abraham I
2015-08-27 9:14 ` [PATCH v3 11/15] mmc: host: omap_hsmmc: don't use ->set_power to set initial regulator state Kishon Vijay Abraham I
2015-08-27 9:14 ` Kishon Vijay Abraham I
2015-08-27 9:14 ` [PATCH v3 12/15] mmc: host: omap_hsmmc: enable/disable vmmc_aux regulator based on previous state Kishon Vijay Abraham I
2015-08-27 9:14 ` Kishon Vijay Abraham I
2015-08-27 9:14 ` [PATCH v3 13/15] mmc: host: omap_hsmmc: use regulator_is_enabled to find pbias status Kishon Vijay Abraham I
2015-08-27 9:14 ` Kishon Vijay Abraham I
2015-08-27 12:41 ` Ulf Hansson
2015-08-27 12:42 ` Ulf Hansson
2015-08-27 12:47 ` Kishon Vijay Abraham I
2015-08-27 12:49 ` Ulf Hansson
2015-08-27 9:14 ` [PATCH v3 14/15] mmc: host: omap_hsmmc: use ios->vdd for setting vmmc voltage Kishon Vijay Abraham I
2015-08-27 9:14 ` Kishon Vijay Abraham I
2015-08-27 9:14 ` [PATCH v3 15/15] mmc: host: omap_hsmmc: remove CONFIG_REGULATOR check Kishon Vijay Abraham I
2015-08-27 9:14 ` Kishon Vijay Abraham I
2015-08-27 13:09 ` [PATCH v3 00/15] omap_hsmmc: regulator usage cleanup and fixes Ulf Hansson
2015-08-27 13:20 ` Kishon Vijay Abraham I
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55E3E9B1.8070908@ti.com \
--to=kishon@ti.com \
--cc=afenkart@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=neilb@suse.de \
--cc=nsekhar@ti.com \
--cc=olof@lixom.net \
--cc=tony@atomide.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.