From: maxime.coquelin@st.com (Maxime Coquelin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/7] dmaengine: st_fdma: Add STMicroelectronics FDMA engine driver support
Date: Mon, 31 Aug 2015 09:49:41 +0200 [thread overview]
Message-ID: <55E40715.1040204@st.com> (raw)
In-Reply-To: <1436429872.20619.77.camel@tiscali.nl>
Hi Paul,
On 07/09/2015 10:17 AM, Paul Bolle wrote:
>> >+static int __exit st_fdma_remove(struct platform_device *pdev)
>> >+{
>> >+ struct st_fdma_dev *fdev = platform_get_drvdata(pdev);
>> >+
>> >+ wait_for_completion(&fdev->fw_ack);
>> >+
>> >+ st_fdma_clk_disable(fdev);
>> >+
>> >+ return 0;
>> >+}
> Since this driver is built-in only this means st_fdma_remove() can never
> be used, right?
>
It's not because a driver is built-in only that it does not need a
remove callback.
An instance can be probed/removed any time via driver's bind/unbind
SysFS entries.
Am I missing something?
Kind regards,
Maxime
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Coquelin <maxime.coquelin@st.com>
To: Paul Bolle <pebolle@tiscali.nl>,
Peter Griffin <peter.griffin@linaro.org>
Cc: lee.jones@linaro.org, devicetree@vger.kernel.org,
dmaengine@vger.kernel.org, ludovic.barre@st.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, srinivas.kandagatla@gmail.com,
patrice.chotard@st.com, vinod.koul@intel.com,
dan.j.williams@intel.com
Subject: Re: [PATCH 3/7] dmaengine: st_fdma: Add STMicroelectronics FDMA engine driver support
Date: Mon, 31 Aug 2015 09:49:41 +0200 [thread overview]
Message-ID: <55E40715.1040204@st.com> (raw)
In-Reply-To: <1436429872.20619.77.camel@tiscali.nl>
Hi Paul,
On 07/09/2015 10:17 AM, Paul Bolle wrote:
>> >+static int __exit st_fdma_remove(struct platform_device *pdev)
>> >+{
>> >+ struct st_fdma_dev *fdev = platform_get_drvdata(pdev);
>> >+
>> >+ wait_for_completion(&fdev->fw_ack);
>> >+
>> >+ st_fdma_clk_disable(fdev);
>> >+
>> >+ return 0;
>> >+}
> Since this driver is built-in only this means st_fdma_remove() can never
> be used, right?
>
It's not because a driver is built-in only that it does not need a
remove callback.
An instance can be probed/removed any time via driver's bind/unbind
SysFS entries.
Am I missing something?
Kind regards,
Maxime
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Coquelin <maxime.coquelin@st.com>
To: Paul Bolle <pebolle@tiscali.nl>,
Peter Griffin <peter.griffin@linaro.org>
Cc: <lee.jones@linaro.org>, <devicetree@vger.kernel.org>,
<dmaengine@vger.kernel.org>, <ludovic.barre@st.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <srinivas.kandagatla@gmail.com>,
<patrice.chotard@st.com>, <vinod.koul@intel.com>,
<dan.j.williams@intel.com>
Subject: Re: [PATCH 3/7] dmaengine: st_fdma: Add STMicroelectronics FDMA engine driver support
Date: Mon, 31 Aug 2015 09:49:41 +0200 [thread overview]
Message-ID: <55E40715.1040204@st.com> (raw)
In-Reply-To: <1436429872.20619.77.camel@tiscali.nl>
Hi Paul,
On 07/09/2015 10:17 AM, Paul Bolle wrote:
>> >+static int __exit st_fdma_remove(struct platform_device *pdev)
>> >+{
>> >+ struct st_fdma_dev *fdev = platform_get_drvdata(pdev);
>> >+
>> >+ wait_for_completion(&fdev->fw_ack);
>> >+
>> >+ st_fdma_clk_disable(fdev);
>> >+
>> >+ return 0;
>> >+}
> Since this driver is built-in only this means st_fdma_remove() can never
> be used, right?
>
It's not because a driver is built-in only that it does not need a
remove callback.
An instance can be probed/removed any time via driver's bind/unbind
SysFS entries.
Am I missing something?
Kind regards,
Maxime
next prev parent reply other threads:[~2015-08-31 7:49 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-08 16:11 [PATCH 0/7] Add support for FDMA DMA controller found on STi chipsets Peter Griffin
2015-07-08 16:11 ` Peter Griffin
2015-07-08 16:11 ` [PATCH 1/7] dmaengine: st_fdma: Add STMicroelectronics FDMA DT binding documentation Peter Griffin
2015-07-08 16:11 ` Peter Griffin
2015-08-19 15:06 ` Vinod Koul
2015-08-19 15:06 ` Vinod Koul
2015-08-19 15:06 ` Vinod Koul
2015-08-25 17:08 ` Peter Griffin
2015-08-25 17:08 ` Peter Griffin
2015-08-26 7:12 ` Lee Jones
2015-08-26 7:12 ` Lee Jones
2015-08-26 7:12 ` Lee Jones
2015-09-03 9:18 ` Peter Griffin
2015-09-03 9:18 ` Peter Griffin
2015-07-08 16:11 ` [PATCH 2/7] dmaengine: st_fdma: Add STMicroelectronics FDMA xbar " Peter Griffin
2015-07-08 16:11 ` Peter Griffin
2015-07-08 16:11 ` Peter Griffin
2015-07-08 16:11 ` [PATCH 3/7] dmaengine: st_fdma: Add STMicroelectronics FDMA engine driver support Peter Griffin
2015-07-08 16:11 ` Peter Griffin
2015-07-08 16:11 ` Peter Griffin
2015-07-09 8:17 ` Paul Bolle
2015-07-09 8:17 ` Paul Bolle
2015-08-28 17:59 ` Peter Griffin
2015-08-28 17:59 ` Peter Griffin
2015-08-28 17:59 ` Peter Griffin
2015-08-31 7:49 ` Maxime Coquelin [this message]
2015-08-31 7:49 ` Maxime Coquelin
2015-08-31 7:49 ` Maxime Coquelin
2015-08-31 8:08 ` Paul Bolle
2015-08-31 8:08 ` Paul Bolle
2015-08-31 8:08 ` Paul Bolle
2015-08-31 8:44 ` Maxime Coquelin
2015-08-31 8:44 ` Maxime Coquelin
2015-08-31 8:44 ` Maxime Coquelin
2015-08-19 15:40 ` Vinod Koul
2015-08-19 15:40 ` Vinod Koul
2015-09-02 17:42 ` Peter Griffin
2015-09-02 17:42 ` Peter Griffin
2015-09-02 17:42 ` Peter Griffin
2015-07-08 16:11 ` [PATCH 4/7] dmaengine: st_fdma: Add xbar support Peter Griffin
2015-07-08 16:11 ` Peter Griffin
2015-07-08 16:11 ` Peter Griffin
2015-07-09 8:27 ` Paul Bolle
2015-07-09 8:27 ` Paul Bolle
2015-07-08 16:11 ` [PATCH 5/7] ARM: STi: DT: STiH407: Add FDMA driver and xbar driver dt nodes Peter Griffin
2015-07-08 16:11 ` Peter Griffin
2015-08-26 7:46 ` Lee Jones
2015-08-26 7:46 ` Lee Jones
2015-09-03 14:12 ` Peter Griffin
2015-09-03 14:12 ` Peter Griffin
2015-09-03 14:12 ` Peter Griffin
2015-07-08 16:11 ` [PATCH 6/7] MAINTAINERS: Add FDMA driver files to STi section Peter Griffin
2015-07-08 16:11 ` Peter Griffin
2015-08-26 7:33 ` Lee Jones
2015-08-26 7:33 ` Lee Jones
2015-08-26 7:33 ` Lee Jones
2015-09-02 15:14 ` Peter Griffin
2015-09-02 15:14 ` Peter Griffin
2015-09-02 15:14 ` Peter Griffin
2015-07-08 16:11 ` [PATCH 7/7] ARM: multi_v7_defconfig: Enable STi FDMA driver Peter Griffin
2015-07-08 16:11 ` Peter Griffin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55E40715.1040204@st.com \
--to=maxime.coquelin@st.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.