* [PATCH] drivers/nfc/s3fwrn5/Makefile: remove superfluous cflags
@ 2015-08-25 8:50 Valentin Rothberg
2015-08-31 7:54 ` Robert Baldyga
0 siblings, 1 reply; 4+ messages in thread
From: Valentin Rothberg @ 2015-08-25 8:50 UTC (permalink / raw)
To: clement.perrochaud, r.baldyga, linux-kernel; +Cc: Valentin Rothberg
NFC_DEBUG is not defined in Kconfig and since DEBUG is not used
anywhere in this directory, we can safely remove this line.
Signed-off-by: Valentin Rothberg <valentinrothberg@gmail.com>
---
I detected the issue with scripts/checkkconfigsymbols.py
drivers/nfc/s3fwrn5/Makefile | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/nfc/s3fwrn5/Makefile b/drivers/nfc/s3fwrn5/Makefile
index 3381c34faf62..ddfa7be7dd05 100644
--- a/drivers/nfc/s3fwrn5/Makefile
+++ b/drivers/nfc/s3fwrn5/Makefile
@@ -7,5 +7,3 @@ s3fwrn5_i2c-objs = i2c.o
obj-$(CONFIG_NFC_S3FWRN5) += s3fwrn5.o
obj-$(CONFIG_NFC_S3FWRN5_I2C) += s3fwrn5_i2c.o
-
-ccflags-$(CONFIG_NFC_DEBUG) := -DDEBUG
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] drivers/nfc/s3fwrn5/Makefile: remove superfluous cflags
2015-08-25 8:50 [PATCH] drivers/nfc/s3fwrn5/Makefile: remove superfluous cflags Valentin Rothberg
@ 2015-08-31 7:54 ` Robert Baldyga
2015-08-31 8:02 ` Robert Baldyga
0 siblings, 1 reply; 4+ messages in thread
From: Robert Baldyga @ 2015-08-31 7:54 UTC (permalink / raw)
To: Valentin Rothberg, clement.perrochaud, linux-kernel
On 08/25/2015 10:50 AM, Valentin Rothberg wrote:
> NFC_DEBUG is not defined in Kconfig and since DEBUG is not used
> anywhere in this directory, we can safely remove this line.
>
> Signed-off-by: Valentin Rothberg <valentinrothberg@gmail.com>
Acked-by: Robert Baldyga <r.baldyga@samsung.com>
Thanks,
Robert Baldyga
> ---
> I detected the issue with scripts/checkkconfigsymbols.py
>
> drivers/nfc/s3fwrn5/Makefile | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/nfc/s3fwrn5/Makefile b/drivers/nfc/s3fwrn5/Makefile
> index 3381c34faf62..ddfa7be7dd05 100644
> --- a/drivers/nfc/s3fwrn5/Makefile
> +++ b/drivers/nfc/s3fwrn5/Makefile
> @@ -7,5 +7,3 @@ s3fwrn5_i2c-objs = i2c.o
>
> obj-$(CONFIG_NFC_S3FWRN5) += s3fwrn5.o
> obj-$(CONFIG_NFC_S3FWRN5_I2C) += s3fwrn5_i2c.o
> -
> -ccflags-$(CONFIG_NFC_DEBUG) := -DDEBUG
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drivers/nfc/s3fwrn5/Makefile: remove superfluous cflags
2015-08-31 7:54 ` Robert Baldyga
@ 2015-08-31 8:02 ` Robert Baldyga
2015-10-06 23:44 ` Samuel Ortiz
0 siblings, 1 reply; 4+ messages in thread
From: Robert Baldyga @ 2015-08-31 8:02 UTC (permalink / raw)
To: Valentin Rothberg; +Cc: clement.perrochaud, linux-kernel, sameo, linux-nfc
[ +cc Samuel Ortiz and <linux-nfc@lists.01.org> ]
Hi Samuel,
Could you please apply this patch?
Thanks,
Robert
On 08/31/2015 09:54 AM, Robert Baldyga wrote:
> On 08/25/2015 10:50 AM, Valentin Rothberg wrote:
>> NFC_DEBUG is not defined in Kconfig and since DEBUG is not used
>> anywhere in this directory, we can safely remove this line.
>>
>> Signed-off-by: Valentin Rothberg <valentinrothberg@gmail.com>
>
> Acked-by: Robert Baldyga <r.baldyga@samsung.com>
>
> Thanks,
> Robert Baldyga
>
>> ---
>> I detected the issue with scripts/checkkconfigsymbols.py
>>
>> drivers/nfc/s3fwrn5/Makefile | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/nfc/s3fwrn5/Makefile b/drivers/nfc/s3fwrn5/Makefile
>> index 3381c34faf62..ddfa7be7dd05 100644
>> --- a/drivers/nfc/s3fwrn5/Makefile
>> +++ b/drivers/nfc/s3fwrn5/Makefile
>> @@ -7,5 +7,3 @@ s3fwrn5_i2c-objs = i2c.o
>>
>> obj-$(CONFIG_NFC_S3FWRN5) += s3fwrn5.o
>> obj-$(CONFIG_NFC_S3FWRN5_I2C) += s3fwrn5_i2c.o
>> -
>> -ccflags-$(CONFIG_NFC_DEBUG) := -DDEBUG
>>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drivers/nfc/s3fwrn5/Makefile: remove superfluous cflags
2015-08-31 8:02 ` Robert Baldyga
@ 2015-10-06 23:44 ` Samuel Ortiz
0 siblings, 0 replies; 4+ messages in thread
From: Samuel Ortiz @ 2015-10-06 23:44 UTC (permalink / raw)
To: Robert Baldyga
Cc: Valentin Rothberg, clement.perrochaud, linux-kernel, linux-nfc
Hi Robert,
On Mon, Aug 31, 2015 at 10:02:40AM +0200, Robert Baldyga wrote:
> [ +cc Samuel Ortiz and <linux-nfc@lists.01.org> ]
>
> Hi Samuel,
>
> Could you please apply this patch?
Applied, thanks.
Cheers,
Samuel.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-10-06 23:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-25 8:50 [PATCH] drivers/nfc/s3fwrn5/Makefile: remove superfluous cflags Valentin Rothberg
2015-08-31 7:54 ` Robert Baldyga
2015-08-31 8:02 ` Robert Baldyga
2015-10-06 23:44 ` Samuel Ortiz
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.