* [PATCH] perf tools: Fix random building error
@ 2015-09-01 5:56 Wang Nan
2015-09-01 6:24 ` Adrian Hunter
2015-09-02 7:27 ` [tip:perf/urgent] perf build: Fix Intel PT instruction decoder dependency problem tip-bot for Wang Nan
0 siblings, 2 replies; 5+ messages in thread
From: Wang Nan @ 2015-09-01 5:56 UTC (permalink / raw)
To: acme
Cc: linux-kernel, lizefan, pi3orama, Wang Nan,
Arnaldo Carvalho de Melo, Adrian Hunter
I hit following building error randomly:
...
/bin/sh: /path/to/kernel/buildperf/util/intel-pt-decoder/inat-tables.c: No such file or directory
...
LINK /path/to/kernel/buildperf/plugin_mac80211.so
LINK /path/to/kernel/buildperf/plugin_kmem.so
LINK /path/to/kernel/buildperf/plugin_xen.so
LINK /path/to/kernel/buildperf/plugin_hrtimer.so
In file included from util/intel-pt-decoder/intel-pt-insn-decoder.c:25:0:
util/intel-pt-decoder/inat.c:24:25: fatal error: inat-tables.c: No such file or directory
#include "inat-tables.c"
^
compilation terminated.
make[4]: *** [/path/to/kernel/buildperf/util/intel-pt-decoder/intel-pt-insn-decoder.o] Error 1
make[4]: *** Waiting for unfinished jobs....
LINK /path/to/kernel/buildperf/plugin_function.so
This is caused by tools/perf/util/intel-pt-decoder/Build that, it tries to
generate $(OUTPUT)util/intel-pt-decoder/inat-tables.c atomatically but
forget to ensure the existance of $(OUTPUT)util/intel-pt-decoder directory.
This patch fixes it by adding $(call rule_mkdir) like other similar rules.
Signed-off-by: Wang Nan <wangnan0@huawei.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
---
tools/perf/util/intel-pt-decoder/Build | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/perf/util/intel-pt-decoder/Build b/tools/perf/util/intel-pt-decoder/Build
index 240730d..2386322 100644
--- a/tools/perf/util/intel-pt-decoder/Build
+++ b/tools/perf/util/intel-pt-decoder/Build
@@ -4,6 +4,7 @@ inat_tables_script = util/intel-pt-decoder/gen-insn-attr-x86.awk
inat_tables_maps = util/intel-pt-decoder/x86-opcode-map.txt
$(OUTPUT)util/intel-pt-decoder/inat-tables.c: $(inat_tables_script) $(inat_tables_maps)
+ $(call rule_mkdir)
@$(call echo-cmd,gen)$(AWK) -f $(inat_tables_script) $(inat_tables_maps) > $@ || rm -f $@
$(OUTPUT)util/intel-pt-decoder/intel-pt-insn-decoder.o: util/intel-pt-decoder/inat.c $(OUTPUT)util/intel-pt-decoder/inat-tables.c
--
1.8.3.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] perf tools: Fix random building error
2015-09-01 5:56 [PATCH] perf tools: Fix random building error Wang Nan
@ 2015-09-01 6:24 ` Adrian Hunter
2015-09-01 6:41 ` Wangnan (F)
2015-09-01 10:40 ` Jiri Olsa
2015-09-02 7:27 ` [tip:perf/urgent] perf build: Fix Intel PT instruction decoder dependency problem tip-bot for Wang Nan
1 sibling, 2 replies; 5+ messages in thread
From: Adrian Hunter @ 2015-09-01 6:24 UTC (permalink / raw)
To: Jiri Olsa
Cc: Wang Nan, acme, linux-kernel, lizefan, pi3orama,
Arnaldo Carvalho de Melo
On 01/09/15 08:56, Wang Nan wrote:
> I hit following building error randomly:
Random presumably because there is a race to use/create the directory by
different make jobs (i.e. -j option).
>
> ...
> /bin/sh: /path/to/kernel/buildperf/util/intel-pt-decoder/inat-tables.c: No such file or directory
> ...
> LINK /path/to/kernel/buildperf/plugin_mac80211.so
> LINK /path/to/kernel/buildperf/plugin_kmem.so
> LINK /path/to/kernel/buildperf/plugin_xen.so
> LINK /path/to/kernel/buildperf/plugin_hrtimer.so
> In file included from util/intel-pt-decoder/intel-pt-insn-decoder.c:25:0:
> util/intel-pt-decoder/inat.c:24:25: fatal error: inat-tables.c: No such file or directory
> #include "inat-tables.c"
> ^
> compilation terminated.
> make[4]: *** [/path/to/kernel/buildperf/util/intel-pt-decoder/intel-pt-insn-decoder.o] Error 1
> make[4]: *** Waiting for unfinished jobs....
> LINK /path/to/kernel/buildperf/plugin_function.so
>
> This is caused by tools/perf/util/intel-pt-decoder/Build that, it tries to
> generate $(OUTPUT)util/intel-pt-decoder/inat-tables.c atomatically but
> forget to ensure the existance of $(OUTPUT)util/intel-pt-decoder directory.
>
> This patch fixes it by adding $(call rule_mkdir) like other similar rules.
>
> Signed-off-by: Wang Nan <wangnan0@huawei.com>
> Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
> Cc: Adrian Hunter <adrian.hunter@intel.com>
Looks ok to me. Jiri?
> ---
> tools/perf/util/intel-pt-decoder/Build | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/perf/util/intel-pt-decoder/Build b/tools/perf/util/intel-pt-decoder/Build
> index 240730d..2386322 100644
> --- a/tools/perf/util/intel-pt-decoder/Build
> +++ b/tools/perf/util/intel-pt-decoder/Build
> @@ -4,6 +4,7 @@ inat_tables_script = util/intel-pt-decoder/gen-insn-attr-x86.awk
> inat_tables_maps = util/intel-pt-decoder/x86-opcode-map.txt
>
> $(OUTPUT)util/intel-pt-decoder/inat-tables.c: $(inat_tables_script) $(inat_tables_maps)
> + $(call rule_mkdir)
> @$(call echo-cmd,gen)$(AWK) -f $(inat_tables_script) $(inat_tables_maps) > $@ || rm -f $@
>
> $(OUTPUT)util/intel-pt-decoder/intel-pt-insn-decoder.o: util/intel-pt-decoder/inat.c $(OUTPUT)util/intel-pt-decoder/inat-tables.c
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] perf tools: Fix random building error
2015-09-01 6:24 ` Adrian Hunter
@ 2015-09-01 6:41 ` Wangnan (F)
2015-09-01 10:40 ` Jiri Olsa
1 sibling, 0 replies; 5+ messages in thread
From: Wangnan (F) @ 2015-09-01 6:41 UTC (permalink / raw)
To: Adrian Hunter, Jiri Olsa
Cc: acme, linux-kernel, lizefan, pi3orama, Arnaldo Carvalho de Melo
On 2015/9/1 14:24, Adrian Hunter wrote:
> On 01/09/15 08:56, Wang Nan wrote:
>> I hit following building error randomly:
> Random presumably because there is a race to use/create the directory by
> different make jobs (i.e. -j option).
Yes, I use -j 160 :)
>> ...
>> /bin/sh: /path/to/kernel/buildperf/util/intel-pt-decoder/inat-tables.c: No such file or directory
>> ...
>> LINK /path/to/kernel/buildperf/plugin_mac80211.so
>> LINK /path/to/kernel/buildperf/plugin_kmem.so
>> LINK /path/to/kernel/buildperf/plugin_xen.so
>> LINK /path/to/kernel/buildperf/plugin_hrtimer.so
>> In file included from util/intel-pt-decoder/intel-pt-insn-decoder.c:25:0:
>> util/intel-pt-decoder/inat.c:24:25: fatal error: inat-tables.c: No such file or directory
>> #include "inat-tables.c"
>> ^
>> compilation terminated.
>> make[4]: *** [/path/to/kernel/buildperf/util/intel-pt-decoder/intel-pt-insn-decoder.o] Error 1
>> make[4]: *** Waiting for unfinished jobs....
>> LINK /path/to/kernel/buildperf/plugin_function.so
>>
>> This is caused by tools/perf/util/intel-pt-decoder/Build that, it tries to
>> generate $(OUTPUT)util/intel-pt-decoder/inat-tables.c atomatically but
>> forget to ensure the existance of $(OUTPUT)util/intel-pt-decoder directory.
>>
>> This patch fixes it by adding $(call rule_mkdir) like other similar rules.
>>
>> Signed-off-by: Wang Nan <wangnan0@huawei.com>
>> Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
>> Cc: Adrian Hunter <adrian.hunter@intel.com>
> Looks ok to me. Jiri?
>
>> ---
>> tools/perf/util/intel-pt-decoder/Build | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/tools/perf/util/intel-pt-decoder/Build b/tools/perf/util/intel-pt-decoder/Build
>> index 240730d..2386322 100644
>> --- a/tools/perf/util/intel-pt-decoder/Build
>> +++ b/tools/perf/util/intel-pt-decoder/Build
>> @@ -4,6 +4,7 @@ inat_tables_script = util/intel-pt-decoder/gen-insn-attr-x86.awk
>> inat_tables_maps = util/intel-pt-decoder/x86-opcode-map.txt
>>
>> $(OUTPUT)util/intel-pt-decoder/inat-tables.c: $(inat_tables_script) $(inat_tables_maps)
>> + $(call rule_mkdir)
>> @$(call echo-cmd,gen)$(AWK) -f $(inat_tables_script) $(inat_tables_maps) > $@ || rm -f $@
>>
>> $(OUTPUT)util/intel-pt-decoder/intel-pt-insn-decoder.o: util/intel-pt-decoder/inat.c $(OUTPUT)util/intel-pt-decoder/inat-tables.c
>>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] perf tools: Fix random building error
2015-09-01 6:24 ` Adrian Hunter
2015-09-01 6:41 ` Wangnan (F)
@ 2015-09-01 10:40 ` Jiri Olsa
1 sibling, 0 replies; 5+ messages in thread
From: Jiri Olsa @ 2015-09-01 10:40 UTC (permalink / raw)
To: Adrian Hunter
Cc: Wang Nan, acme, linux-kernel, lizefan, pi3orama,
Arnaldo Carvalho de Melo
On Tue, Sep 01, 2015 at 09:24:14AM +0300, Adrian Hunter wrote:
> On 01/09/15 08:56, Wang Nan wrote:
> > I hit following building error randomly:
>
> Random presumably because there is a race to use/create the directory by
> different make jobs (i.e. -j option).
>
> >
> > ...
> > /bin/sh: /path/to/kernel/buildperf/util/intel-pt-decoder/inat-tables.c: No such file or directory
> > ...
> > LINK /path/to/kernel/buildperf/plugin_mac80211.so
> > LINK /path/to/kernel/buildperf/plugin_kmem.so
> > LINK /path/to/kernel/buildperf/plugin_xen.so
> > LINK /path/to/kernel/buildperf/plugin_hrtimer.so
> > In file included from util/intel-pt-decoder/intel-pt-insn-decoder.c:25:0:
> > util/intel-pt-decoder/inat.c:24:25: fatal error: inat-tables.c: No such file or directory
> > #include "inat-tables.c"
> > ^
> > compilation terminated.
> > make[4]: *** [/path/to/kernel/buildperf/util/intel-pt-decoder/intel-pt-insn-decoder.o] Error 1
> > make[4]: *** Waiting for unfinished jobs....
> > LINK /path/to/kernel/buildperf/plugin_function.so
> >
> > This is caused by tools/perf/util/intel-pt-decoder/Build that, it tries to
> > generate $(OUTPUT)util/intel-pt-decoder/inat-tables.c atomatically but
> > forget to ensure the existance of $(OUTPUT)util/intel-pt-decoder directory.
> >
> > This patch fixes it by adding $(call rule_mkdir) like other similar rules.
> >
> > Signed-off-by: Wang Nan <wangnan0@huawei.com>
> > Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
> > Cc: Adrian Hunter <adrian.hunter@intel.com>
>
> Looks ok to me. Jiri?
right, each separate rule needs to have this
Acked-by: Jiri Olsa <jolsa@kernel.org>
thanks,
jirka
^ permalink raw reply [flat|nested] 5+ messages in thread
* [tip:perf/urgent] perf build: Fix Intel PT instruction decoder dependency problem
2015-09-01 5:56 [PATCH] perf tools: Fix random building error Wang Nan
2015-09-01 6:24 ` Adrian Hunter
@ 2015-09-02 7:27 ` tip-bot for Wang Nan
1 sibling, 0 replies; 5+ messages in thread
From: tip-bot for Wang Nan @ 2015-09-02 7:27 UTC (permalink / raw)
To: linux-tip-commits
Cc: adrian.hunter, acme, mingo, lizefan, jolsa, wangnan0,
linux-kernel, hpa, tglx
Commit-ID: 04aa90b529ee45c5ee88997bc214202e07b26979
Gitweb: http://git.kernel.org/tip/04aa90b529ee45c5ee88997bc214202e07b26979
Author: Wang Nan <wangnan0@huawei.com>
AuthorDate: Tue, 1 Sep 2015 05:56:45 +0000
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Tue, 1 Sep 2015 13:03:46 -0300
perf build: Fix Intel PT instruction decoder dependency problem
I hit following building error randomly:
...
/bin/sh: /path/to/kernel/buildperf/util/intel-pt-decoder/inat-tables.c: No such file or directory
...
LINK /path/to/kernel/buildperf/plugin_mac80211.so
LINK /path/to/kernel/buildperf/plugin_kmem.so
LINK /path/to/kernel/buildperf/plugin_xen.so
LINK /path/to/kernel/buildperf/plugin_hrtimer.so
In file included from util/intel-pt-decoder/intel-pt-insn-decoder.c:25:0:
util/intel-pt-decoder/inat.c:24:25: fatal error: inat-tables.c: No such file or directory
#include "inat-tables.c"
^
compilation terminated.
make[4]: *** [/path/to/kernel/buildperf/util/intel-pt-decoder/intel-pt-insn-decoder.o] Error 1
make[4]: *** Waiting for unfinished jobs....
LINK /path/to/kernel/buildperf/plugin_function.so
This is caused by tools/perf/util/intel-pt-decoder/Build that, it tries
to generate $(OUTPUT)util/intel-pt-decoder/inat-tables.c atomatically
but forget to ensure the existance of $(OUTPUT)util/intel-pt-decoder
directory.
This patch fixes it by adding $(call rule_mkdir) like other similar rules.
Signed-off-by: Wang Nan <wangnan0@huawei.com>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
Acked-by: Jiri Olsa <jolsa@kernel.org>
Cc: Zefan Li <lizefan@huawei.com>
Cc: pi3orama@163.com
Link: http://lkml.kernel.org/r/1441087005-107540-1-git-send-email-wangnan0@huawei.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/intel-pt-decoder/Build | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/perf/util/intel-pt-decoder/Build b/tools/perf/util/intel-pt-decoder/Build
index 240730d..2386322 100644
--- a/tools/perf/util/intel-pt-decoder/Build
+++ b/tools/perf/util/intel-pt-decoder/Build
@@ -4,6 +4,7 @@ inat_tables_script = util/intel-pt-decoder/gen-insn-attr-x86.awk
inat_tables_maps = util/intel-pt-decoder/x86-opcode-map.txt
$(OUTPUT)util/intel-pt-decoder/inat-tables.c: $(inat_tables_script) $(inat_tables_maps)
+ $(call rule_mkdir)
@$(call echo-cmd,gen)$(AWK) -f $(inat_tables_script) $(inat_tables_maps) > $@ || rm -f $@
$(OUTPUT)util/intel-pt-decoder/intel-pt-insn-decoder.o: util/intel-pt-decoder/inat.c $(OUTPUT)util/intel-pt-decoder/inat-tables.c
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-09-02 7:28 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-01 5:56 [PATCH] perf tools: Fix random building error Wang Nan
2015-09-01 6:24 ` Adrian Hunter
2015-09-01 6:41 ` Wangnan (F)
2015-09-01 10:40 ` Jiri Olsa
2015-09-02 7:27 ` [tip:perf/urgent] perf build: Fix Intel PT instruction decoder dependency problem tip-bot for Wang Nan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.