All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jarkko Nikula <jarkko.nikula-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: Tan Jui Nee <jui.nee.tan-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org
Cc: linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	mika.westerberg-VuQAYsv1563Yd54FQh9/CA@public.gmane.org
Subject: Re: [PATCH] spi: spi-pxa2xx: Check status register to determine if SSSR_TINT is disabled
Date: Tue, 01 Sep 2015 10:41:50 +0300	[thread overview]
Message-ID: <55E556BE.1020705@linux.intel.com> (raw)
In-Reply-To: <1441074171-23265-1-git-send-email-jui.nee.tan-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>

On 09/01/2015 05:22 AM, Tan Jui Nee wrote:
> From: "Tan, Jui Nee" <jui.nee.tan-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
>
> On Intel Baytrail, there is case when interrupt handler get called, no SPI
> message is captured. The RX FIFO is indeed empty when RX timeout pending
> interrupt (SSSR_TINT) happens.
>
> Use the BIOS version where both HSUART and SPI are on the same IRQ. Both
> drivers are using IRQF_SHARED when calling the request_irq function. When
> running two separate and independent SPI and HSUART application that
> generate data traffic on both components, user will see messages like
> below on the console:
>
>    pxa2xx-spi pxa2xx-spi.0: bad message state in interrupt handler
>
> This commit will fix this by first checking Receiver Time-out Interrupt,
> if it is disabled, ignore the request and return without servicing.
>
> Signed-off-by: Tan, Jui Nee <jui.nee.tan-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> ---
>   drivers/spi/spi-pxa2xx.c | 4 ++++
>   1 file changed, 4 insertions(+)
>
Acked-by: Jarkko Nikula <jarkko.nikula-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Jarkko Nikula <jarkko.nikula@linux.intel.com>
To: Tan Jui Nee <jui.nee.tan@intel.com>, broonie@kernel.org
Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
	mika.westerberg@linux.intel.com
Subject: Re: [PATCH] spi: spi-pxa2xx: Check status register to determine if SSSR_TINT is disabled
Date: Tue, 01 Sep 2015 10:41:50 +0300	[thread overview]
Message-ID: <55E556BE.1020705@linux.intel.com> (raw)
In-Reply-To: <1441074171-23265-1-git-send-email-jui.nee.tan@intel.com>

On 09/01/2015 05:22 AM, Tan Jui Nee wrote:
> From: "Tan, Jui Nee" <jui.nee.tan@intel.com>
>
> On Intel Baytrail, there is case when interrupt handler get called, no SPI
> message is captured. The RX FIFO is indeed empty when RX timeout pending
> interrupt (SSSR_TINT) happens.
>
> Use the BIOS version where both HSUART and SPI are on the same IRQ. Both
> drivers are using IRQF_SHARED when calling the request_irq function. When
> running two separate and independent SPI and HSUART application that
> generate data traffic on both components, user will see messages like
> below on the console:
>
>    pxa2xx-spi pxa2xx-spi.0: bad message state in interrupt handler
>
> This commit will fix this by first checking Receiver Time-out Interrupt,
> if it is disabled, ignore the request and return without servicing.
>
> Signed-off-by: Tan, Jui Nee <jui.nee.tan@intel.com>
> ---
>   drivers/spi/spi-pxa2xx.c | 4 ++++
>   1 file changed, 4 insertions(+)
>
Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>

  parent reply	other threads:[~2015-09-01  7:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-01  2:22 [PATCH] spi: spi-pxa2xx: Check status register to determine if SSSR_TINT is disabled Tan Jui Nee
2015-09-01  2:22 ` Tan Jui Nee
     [not found] ` <1441074171-23265-1-git-send-email-jui.nee.tan-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-09-01  7:41   ` Jarkko Nikula [this message]
2015-09-01  7:41     ` Jarkko Nikula
2015-09-02 12:12   ` Applied "spi: spi-pxa2xx: Check status register to determine if SSSR_TINT is disabled" to the spi tree Mark Brown
2015-09-02 12:12     ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55E556BE.1020705@linux.intel.com \
    --to=jarkko.nikula-vuqaysv1563yd54fqh9/ca@public.gmane.org \
    --cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=jui.nee.tan-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mika.westerberg-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.