All of lore.kernel.org
 help / color / mirror / Atom feed
From: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Sudip Mukherjee
	<sudipm.mukherjee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Mike Marciniszyn
	<infinipath-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	Greg Kroah-Hartman
	<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	devel-gWbeCf7V1WCQmaza687I9mD2FQJk+8+b@public.gmane.org,
	Jim Davis <jim.epost-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH] staging: ipath: fix build failure
Date: Tue, 1 Sep 2015 10:52:55 -0400	[thread overview]
Message-ID: <55E5BBC7.1020007@redhat.com> (raw)
In-Reply-To: <1441112498-22057-1-git-send-email-sudipm.mukherjee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 1917 bytes --]

On 09/01/2015 09:01 AM, Sudip Mukherjee wrote:
> building of ipath depends on infiniband. And if ipath is selected and
> infiniband is not then build fails with:
> ERROR: "ib_alloc_device" [drivers/staging/ipath/ib_ipath.ko] undefined!
> ERROR: "ib_dealloc_device" [drivers/staging/ipath/ib_ipath.ko] undefined!
> ERROR: "ib_dispatch_event" [drivers/staging/ipath/ib_ipath.ko] undefined!
> ERROR: "ib_register_device" [drivers/staging/ipath/ib_ipath.ko] undefined!
> ERROR: "ib_unregister_device" [drivers/staging/ipath/ib_ipath.ko] undefined!
> ERROR: "ib_modify_qp_is_ok" [drivers/staging/ipath/ib_ipath.ko] undefined!
> ERROR: "ib_wq" [drivers/staging/ipath/ib_ipath.ko] undefined!
> 
> Config at: https://lkml.org/lkml/2015/8/31/328
> 
> Reported-by: Jim Davis <jim.epost-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Signed-off-by: Sudip Mukherjee <sudip-ofJRbWXBVFamYgehrs7/Lw@public.gmane.org>
> ---
>  drivers/staging/ipath/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/ipath/Kconfig b/drivers/staging/ipath/Kconfig
> index 041ce06..1edc21b 100644
> --- a/drivers/staging/ipath/Kconfig
> +++ b/drivers/staging/ipath/Kconfig
> @@ -1,6 +1,7 @@
>  config INFINIBAND_IPATH
>  	tristate "QLogic HTX HCA support"
>  	depends on 64BIT && NET && HT_IRQ
> +	depends on INFINIBAND
>  	---help---
>  	This is a driver for the deprecated QLogic Hyper-Transport
>  	IB host channel adapter (model QHT7140),
> 

The ipath driver was moved to staging/rdma/ipath and has proper
protection against being built without the InfiniBand subsystem.  Where
are you seeing this tree?  I'm curious because I no longer have this
driver in this location in my tree and I never pushed it anywhere other
than one of my trees.  Is this maybe in linux-next?

-- 
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
              GPG KeyID: 0E572FDD



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Doug Ledford <dledford@redhat.com>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
	Mike Marciniszyn <infinipath@intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org,
	devel@driverdev.osuosl.org, Jim Davis <jim.epost@gmail.com>
Subject: Re: [PATCH] staging: ipath: fix build failure
Date: Tue, 1 Sep 2015 10:52:55 -0400	[thread overview]
Message-ID: <55E5BBC7.1020007@redhat.com> (raw)
In-Reply-To: <1441112498-22057-1-git-send-email-sudipm.mukherjee@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1834 bytes --]

On 09/01/2015 09:01 AM, Sudip Mukherjee wrote:
> building of ipath depends on infiniband. And if ipath is selected and
> infiniband is not then build fails with:
> ERROR: "ib_alloc_device" [drivers/staging/ipath/ib_ipath.ko] undefined!
> ERROR: "ib_dealloc_device" [drivers/staging/ipath/ib_ipath.ko] undefined!
> ERROR: "ib_dispatch_event" [drivers/staging/ipath/ib_ipath.ko] undefined!
> ERROR: "ib_register_device" [drivers/staging/ipath/ib_ipath.ko] undefined!
> ERROR: "ib_unregister_device" [drivers/staging/ipath/ib_ipath.ko] undefined!
> ERROR: "ib_modify_qp_is_ok" [drivers/staging/ipath/ib_ipath.ko] undefined!
> ERROR: "ib_wq" [drivers/staging/ipath/ib_ipath.ko] undefined!
> 
> Config at: https://lkml.org/lkml/2015/8/31/328
> 
> Reported-by: Jim Davis <jim.epost@gmail.com>
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> ---
>  drivers/staging/ipath/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/ipath/Kconfig b/drivers/staging/ipath/Kconfig
> index 041ce06..1edc21b 100644
> --- a/drivers/staging/ipath/Kconfig
> +++ b/drivers/staging/ipath/Kconfig
> @@ -1,6 +1,7 @@
>  config INFINIBAND_IPATH
>  	tristate "QLogic HTX HCA support"
>  	depends on 64BIT && NET && HT_IRQ
> +	depends on INFINIBAND
>  	---help---
>  	This is a driver for the deprecated QLogic Hyper-Transport
>  	IB host channel adapter (model QHT7140),
> 

The ipath driver was moved to staging/rdma/ipath and has proper
protection against being built without the InfiniBand subsystem.  Where
are you seeing this tree?  I'm curious because I no longer have this
driver in this location in my tree and I never pushed it anywhere other
than one of my trees.  Is this maybe in linux-next?

-- 
Doug Ledford <dledford@redhat.com>
              GPG KeyID: 0E572FDD



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]

  parent reply	other threads:[~2015-09-01 14:52 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-01 13:01 [PATCH] staging: ipath: fix build failure Sudip Mukherjee
2015-09-01 13:01 ` Sudip Mukherjee
     [not found] ` <1441112498-22057-1-git-send-email-sudipm.mukherjee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-09-01 14:52   ` Doug Ledford [this message]
2015-09-01 14:52     ` Doug Ledford
2015-09-01 16:54     ` Jim Davis
2015-09-01 16:54       ` Jim Davis
     [not found]       ` <CA+r1ZhjwFP4Odiy_dUnFWNtjuW0KEZeGY1ynx9kf-WScPbYvQA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-09-01 16:59         ` Doug Ledford
2015-09-01 16:59           ` Doug Ledford

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55E5BBC7.1020007@redhat.com \
    --to=dledford-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
    --cc=devel-gWbeCf7V1WCQmaza687I9mD2FQJk+8+b@public.gmane.org \
    --cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
    --cc=infinipath-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=jim.epost-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=sudipm.mukherjee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.