[PATCH] arch/x86/mm/srat: Print non-volatile flag in SRAT

[PATCH] arch/x86/mm/srat: Print non-volatile flag in SRAT

[Linda Knippers]

Nobody checks this flag but it would be interesting to know if it's being
set on any platforms.

Signed-off-by: Linda Knippers <linda.knippers@hp.com>
---
 arch/x86/mm/srat.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/arch/x86/mm/srat.c b/arch/x86/mm/srat.c
index 66338a6..c2aea63 100644
--- a/arch/x86/mm/srat.c
+++ b/arch/x86/mm/srat.c
@@ -192,10 +192,11 @@ acpi_numa_memory_affinity_init(struct acpi_srat_mem_affinity *ma)
 
 	node_set(node, numa_nodes_parsed);
 
-	pr_info("SRAT: Node %u PXM %u [mem %#010Lx-%#010Lx]%s\n",
+	pr_info("SRAT: Node %u PXM %u [mem %#010Lx-%#010Lx]%s%s\n",
 		node, pxm,
 		(unsigned long long) start, (unsigned long long) end - 1,
-		hotpluggable ? " hotplug" : "");
+		hotpluggable ? " hotplug" : "",
+		ma->flags & ACPI_SRAT_MEM_NON_VOLATILE ? " non-volatile" : "");
 
 	/* Mark hotplug range in memblock. */
 	if (hotpluggable && memblock_mark_hotplug(start, ma->length))
-- 
1.8.3.1

Re: [PATCH] arch/x86/mm/srat: Print non-volatile flag in SRAT

[Thomas Gleixner]

On Tue, 1 Sep 2015, Linda Knippers wrote:
> Nobody checks this flag but it would be interesting to know if it's being
> set on any platforms.

What you're omitting to explain, is WHY it would be interesting.

Thanks,

	tglx

Re: [PATCH] arch/x86/mm/srat: Print non-volatile flag in SRAT

[Linda Knippers]

On 9/1/2015 3:17 PM, Thomas Gleixner wrote:
> On Tue, 1 Sep 2015, Linda Knippers wrote:
>> Nobody checks this flag but it would be interesting to know if it's being
>> set on any platforms.
> 
> What you're omitting to explain, is WHY it would be interesting.

With the addition of NVDIMM support, a question came up as to whether
NVDIMM ranges should be in the SRAT with this bit set.  I think the
consensus was no because the ranges are in the NFIT with proximity
domain information there.

ACPI is not clear on the meaning of this bit in the SRAT.
If someone is setting it, we might want to ask them what they expect
to happen with it.

Right now this bit is only printed if all the ACPI debug information is
turned on.

Sorry, I should have explained more.

-- ljk

> 
> Thanks,
> 
> 	tglx
> 

Re: [PATCH] arch/x86/mm/srat: Print non-volatile flag in SRAT

[Thomas Gleixner]

On Tue, 1 Sep 2015, Linda Knippers wrote:
> On 9/1/2015 3:17 PM, Thomas Gleixner wrote:
> > On Tue, 1 Sep 2015, Linda Knippers wrote:
> >> Nobody checks this flag but it would be interesting to know if it's being
> >> set on any platforms.
> > 
> > What you're omitting to explain, is WHY it would be interesting.
> 
> With the addition of NVDIMM support, a question came up as to whether
> NVDIMM ranges should be in the SRAT with this bit set.  I think the
> consensus was no because the ranges are in the NFIT with proximity
> domain information there.
> 
> ACPI is not clear on the meaning of this bit in the SRAT.
> If someone is setting it, we might want to ask them what they expect
> to happen with it.
> 
> Right now this bit is only printed if all the ACPI debug information is
> turned on.
> 
> Sorry, I should have explained more.

Indeed. And that explanation wants to be in the changelog. Care to resend?

Thanks,

	tglx