From: Mugunthan V N <mugunthanvnm@ti.com>
To: Tony Lindgren <tony@atomide.com>
Cc: netdev@vger.kernel.org, "David S . Miller" <davem@davemloft.net>,
Sekhar Nori <nsekhar@ti.com>,
linux-omap@vger.kernel.org
Subject: Re: [net-next PATCH] drivers: net: cpsw: Add support to make gpio drive which slave connected to phy
Date: Wed, 2 Sep 2015 12:03:10 +0530 [thread overview]
Message-ID: <55E69826.7090503@ti.com> (raw)
In-Reply-To: <20150901153621.GI4215@atomide.com>
On Tuesday 01 September 2015 09:06 PM, Tony Lindgren wrote:
> * Mugunthan V N <mugunthanvnm@ti.com> [150901 04:28]:
>> --- a/Documentation/devicetree/bindings/net/cpsw.txt
>> +++ b/Documentation/devicetree/bindings/net/cpsw.txt
>> @@ -26,6 +26,9 @@ Optional properties:
>> - dual_emac : Specifies Switch to act as Dual EMAC
>> - syscon : Phandle to the system control device node, which is
>> the control module device of the am33x
>> +- select-slave-gpio : Should be added if a gpio line is required to
>> + select which slave is connected to phy
>> +
>
> How about using something more generic here for the name?
> Something like mode-gpios?
>
Yeah, agreed, for DRA72x it is used for connecting to phy, if some other
board wanted to drive a GPIO for something else we can use this node to
drive GPIO.
Will submit a v2 with name change
Regards
Mugunthan V N
WARNING: multiple messages have this Message-ID (diff)
From: Mugunthan V N <mugunthanvnm@ti.com>
To: Tony Lindgren <tony@atomide.com>
Cc: <netdev@vger.kernel.org>,
"David S . Miller" <davem@davemloft.net>,
Sekhar Nori <nsekhar@ti.com>, <linux-omap@vger.kernel.org>
Subject: Re: [net-next PATCH] drivers: net: cpsw: Add support to make gpio drive which slave connected to phy
Date: Wed, 2 Sep 2015 12:03:10 +0530 [thread overview]
Message-ID: <55E69826.7090503@ti.com> (raw)
In-Reply-To: <20150901153621.GI4215@atomide.com>
On Tuesday 01 September 2015 09:06 PM, Tony Lindgren wrote:
> * Mugunthan V N <mugunthanvnm@ti.com> [150901 04:28]:
>> --- a/Documentation/devicetree/bindings/net/cpsw.txt
>> +++ b/Documentation/devicetree/bindings/net/cpsw.txt
>> @@ -26,6 +26,9 @@ Optional properties:
>> - dual_emac : Specifies Switch to act as Dual EMAC
>> - syscon : Phandle to the system control device node, which is
>> the control module device of the am33x
>> +- select-slave-gpio : Should be added if a gpio line is required to
>> + select which slave is connected to phy
>> +
>
> How about using something more generic here for the name?
> Something like mode-gpios?
>
Yeah, agreed, for DRA72x it is used for connecting to phy, if some other
board wanted to drive a GPIO for something else we can use this node to
drive GPIO.
Will submit a v2 with name change
Regards
Mugunthan V N
next prev parent reply other threads:[~2015-09-02 6:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-01 11:25 [net-next PATCH] drivers: net: cpsw: Add support to make gpio drive which slave connected to phy Mugunthan V N
2015-09-01 11:25 ` Mugunthan V N
2015-09-01 15:36 ` Tony Lindgren
2015-09-02 6:33 ` Mugunthan V N [this message]
2015-09-02 6:33 ` Mugunthan V N
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55E69826.7090503@ti.com \
--to=mugunthanvnm@ti.com \
--cc=davem@davemloft.net \
--cc=linux-omap@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.