From: Thomas Huth <thuth@redhat.com>
To: Paul Mackerras <paulus@ozlabs.org>
Cc: kvm-ppc@vger.kernel.org, Alexander Graf <agraf@suse.com>,
kvm@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] KVM: ppc: Fix size of the PSPB register
Date: Wed, 02 Sep 2015 07:16:21 +0000 [thread overview]
Message-ID: <55E6A245.2050108@redhat.com> (raw)
In-Reply-To: <20150901222434.GA23007@fergus.ozlabs.ibm.com>
On 02/09/15 00:24, Paul Mackerras wrote:
> On Tue, Sep 01, 2015 at 11:41:18PM +0200, Thomas Huth wrote:
>> The size of the Problem State Priority Boost Register is only
>> 32 bits, so let's change the type of the corresponding variable
>> accordingly to avoid future trouble.
>
> Since we're already using lwz/stw in the assembly code in
> book3s_hv_rmhandlers.S, this is actually a bug fix, isn't it?
> How did you find it? Did you observe a failure of some kind, or did
> you just find it by code inspection?
Code inspection. I was looking for similar problems like the issue with
the XER register that we've hit recently
(https://patchwork.ozlabs.org/patch/476872/) while I was trying to debug
a similar problem.
Thomas
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Huth <thuth@redhat.com>
To: Paul Mackerras <paulus@ozlabs.org>
Cc: kvm-ppc@vger.kernel.org, Alexander Graf <agraf@suse.com>,
kvm@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] KVM: ppc: Fix size of the PSPB register
Date: Wed, 2 Sep 2015 09:16:21 +0200 [thread overview]
Message-ID: <55E6A245.2050108@redhat.com> (raw)
In-Reply-To: <20150901222434.GA23007@fergus.ozlabs.ibm.com>
On 02/09/15 00:24, Paul Mackerras wrote:
> On Tue, Sep 01, 2015 at 11:41:18PM +0200, Thomas Huth wrote:
>> The size of the Problem State Priority Boost Register is only
>> 32 bits, so let's change the type of the corresponding variable
>> accordingly to avoid future trouble.
>
> Since we're already using lwz/stw in the assembly code in
> book3s_hv_rmhandlers.S, this is actually a bug fix, isn't it?
> How did you find it? Did you observe a failure of some kind, or did
> you just find it by code inspection?
Code inspection. I was looking for similar problems like the issue with
the XER register that we've hit recently
(https://patchwork.ozlabs.org/patch/476872/) while I was trying to debug
a similar problem.
Thomas
next prev parent reply other threads:[~2015-09-02 7:16 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-01 21:41 [PATCH] KVM: ppc: Fix size of the PSPB register Thomas Huth
2015-09-01 21:41 ` Thomas Huth
2015-09-01 22:24 ` Paul Mackerras
2015-09-01 22:24 ` Paul Mackerras
2015-09-01 22:30 ` Benjamin Herrenschmidt
2015-09-01 22:30 ` Benjamin Herrenschmidt
2015-09-02 7:16 ` Thomas Huth [this message]
2015-09-02 7:16 ` Thomas Huth
2015-09-01 22:25 ` Benjamin Herrenschmidt
2015-09-01 22:25 ` Benjamin Herrenschmidt
2015-09-01 22:45 ` Paul Mackerras
2015-09-01 22:45 ` Paul Mackerras
2015-09-01 22:45 ` Paul Mackerras
2015-09-01 22:55 ` Benjamin Herrenschmidt
2015-09-01 22:55 ` Benjamin Herrenschmidt
2015-09-02 7:26 ` Thomas Huth
2015-09-02 7:26 ` Thomas Huth
2015-09-02 8:26 ` Alexander Graf
2015-09-02 8:26 ` Alexander Graf
2015-09-02 8:35 ` Thomas Huth
2015-09-02 8:35 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55E6A245.2050108@redhat.com \
--to=thuth@redhat.com \
--cc=agraf@suse.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.