All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vladimir Barinov <vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
To: Lars-Peter Clausen <lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>,
	Daniel Baluta
	<daniel.baluta-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	jlbec-aKy9MeLSZ9dg9hUCZPvPmw@public.gmane.org,
	linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: knaack.h-Mmb7MZpHnFY@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	octavian.purdila-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
	pebolle-IWqWACnzNjzz+pZb47iToQ@public.gmane.org,
	patrick.porlan-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
	adriana.reus-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
	constantin.musca-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
	marten-4zOpVvZifTgX8gGd4fc/mEEOCMrvLtNR@public.gmane.org,
	cristina.opriceana-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	pmeerw-jW+XmwGofnusTnJN9+BGXg@public.gmane.org,
	hch-jcswGhMUV9g@public.gmane.org,
	viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org,
	akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org
Subject: Re: [PATCH v7 4/5] iio: trigger: Introduce IIO hrtimer based trigger
Date: Wed, 02 Sep 2015 15:16:42 +0300	[thread overview]
Message-ID: <55E6E8AA.6070108@cogentembedded.com> (raw)
In-Reply-To: <55E46B45.8040909-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>

Hi Lars,

On 31.08.2015 17:57, Lars-Peter Clausen wrote:
> On 08/17/2015 02:45 PM, Vladimir Barinov wrote:
>> Hello Daniel,
>>
>> I've verified that your hrtimer trigger works.
>>
>> I have minor suggestions.
>>
>> Will not it be useful to have ability to stop/start hrtimer polling
>> not only during attach/detach trigger.
>>
>> f.e. writing 0 to sampling_frequency will hrtimer_cancel
>> and writing any valid frequency will hrtimer_start.
> What's the use case for this?
Setting sampling frequency to 0 Hz.

I do agree that 0Hz is meaningless and the same effect
is achieved by removing trigger from iio device,
but having 0 Hz frequency could probably be more consecutive
for this trigger instead of returning EINVAL.

Regards,
Vladimir

WARNING: multiple messages have this Message-ID (diff)
From: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
To: Lars-Peter Clausen <lars@metafoo.de>,
	Daniel Baluta <daniel.baluta@intel.com>,
	jic23@kernel.org, jlbec@evilplan.org, linux-iio@vger.kernel.org,
	linux-fsdevel@vger.kernel.org
Cc: knaack.h@gmx.de, linux-kernel@vger.kernel.org,
	octavian.purdila@intel.com, pebolle@tiscali.nl,
	patrick.porlan@intel.com, adriana.reus@intel.com,
	constantin.musca@intel.com, marten@intuitiveaerial.com,
	cristina.opriceana@gmail.com, pmeerw@pmeerw.net, hch@lst.de,
	viro@zeniv.linux.org.uk, akpm@linux-foundation.org
Subject: Re: [PATCH v7 4/5] iio: trigger: Introduce IIO hrtimer based trigger
Date: Wed, 02 Sep 2015 15:16:42 +0300	[thread overview]
Message-ID: <55E6E8AA.6070108@cogentembedded.com> (raw)
In-Reply-To: <55E46B45.8040909@metafoo.de>

Hi Lars,

On 31.08.2015 17:57, Lars-Peter Clausen wrote:
> On 08/17/2015 02:45 PM, Vladimir Barinov wrote:
>> Hello Daniel,
>>
>> I've verified that your hrtimer trigger works.
>>
>> I have minor suggestions.
>>
>> Will not it be useful to have ability to stop/start hrtimer polling
>> not only during attach/detach trigger.
>>
>> f.e. writing 0 to sampling_frequency will hrtimer_cancel
>> and writing any valid frequency will hrtimer_start.
> What's the use case for this?
Setting sampling frequency to 0 Hz.

I do agree that 0Hz is meaningless and the same effect
is achieved by removing trigger from iio device,
but having 0 Hz frequency could probably be more consecutive
for this trigger instead of returning EINVAL.

Regards,
Vladimir


  parent reply	other threads:[~2015-09-02 12:16 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-10 22:42 [PATCH v7 0/5] Add initial configfs support for IIO Daniel Baluta
     [not found] ` <1439246562-17515-1-git-send-email-daniel.baluta-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-08-10 22:42   ` [PATCH v7 1/5] configfs: Allow dynamic group (un)registration Daniel Baluta
2015-08-10 22:42     ` Daniel Baluta
2015-08-31 16:02     ` Lars-Peter Clausen
2015-08-10 22:42 ` [PATCH v7 2/5] iio: core: Introduce IIO configfs support Daniel Baluta
2015-08-10 22:42 ` [PATCH v7 3/5] iio: core: Introduce IIO software triggers Daniel Baluta
2015-08-17 11:31   ` Vladimir Barinov
     [not found]   ` <1439246562-17515-4-git-send-email-daniel.baluta-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-08-31 14:41     ` Lars-Peter Clausen
2015-08-31 14:41       ` Lars-Peter Clausen
2015-08-10 22:42 ` [PATCH v7 4/5] iio: trigger: Introduce IIO hrtimer based trigger Daniel Baluta
     [not found]   ` <1439246562-17515-5-git-send-email-daniel.baluta-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-08-17 12:45     ` Vladimir Barinov
2015-08-17 12:45       ` Vladimir Barinov
2015-08-17 12:49       ` Daniel Baluta
2015-08-31 14:57       ` Lars-Peter Clausen
     [not found]         ` <55E46B45.8040909-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>
2015-09-02 12:16           ` Vladimir Barinov [this message]
2015-09-02 12:16             ` Vladimir Barinov
2015-08-31 15:13   ` Lars-Peter Clausen
2015-08-10 22:42 ` [PATCH v7 5/5] iio: Documentation: Add IIO configfs documentation Daniel Baluta
     [not found]   ` <1439246562-17515-6-git-send-email-daniel.baluta-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-08-17 12:01     ` Vladimir Barinov
2015-08-17 12:01       ` Vladimir Barinov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55E6E8AA.6070108@cogentembedded.com \
    --to=vladimir.barinov-m4dtvfq/zs1mrggop+s0pdbpr1lh4cv8@public.gmane.org \
    --cc=adriana.reus-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
    --cc=constantin.musca-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=cristina.opriceana-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=daniel.baluta-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=hch-jcswGhMUV9g@public.gmane.org \
    --cc=jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=jlbec-aKy9MeLSZ9dg9hUCZPvPmw@public.gmane.org \
    --cc=knaack.h-Mmb7MZpHnFY@public.gmane.org \
    --cc=lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org \
    --cc=linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=marten-4zOpVvZifTgX8gGd4fc/mEEOCMrvLtNR@public.gmane.org \
    --cc=octavian.purdila-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=patrick.porlan-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=pebolle-IWqWACnzNjzz+pZb47iToQ@public.gmane.org \
    --cc=pmeerw-jW+XmwGofnusTnJN9+BGXg@public.gmane.org \
    --cc=viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.